You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/13 14:41:50 UTC

[GitHub] [incubator-dolphinscheduler] chengshiwen opened a new pull request #4910: [Improvement][CI] Replace token with github secrets

chengshiwen opened a new pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910


   ## What is the purpose of the pull request
   
   *Replace token with github secrets*
   
   This closes the outdated pr #4102
   
   ## Brief change log
   
     - *Replace `CODECOV_TOKEN` with github secrets*
     - *Replace `SONAR_TOKEN` with github secrets*
   
   ## Requirements
   
   The following variables need to be set under the `Actions secrets` in the `Secrets` settings page of `apache/incubator-dolphinscheduler` repository:
   
     - `CODECOV_TOKEN`
     - `SONAR_TOKEN` 
   
   ![image](https://user-images.githubusercontent.com/4902714/109522019-e05b1900-7ae8-11eb-8090-71d3d9e9af4d.png)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] chengshiwen closed pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
chengshiwen closed pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-801816837


   hi, any progress?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-801831543


   > hi, any progress?
   
   I found a trigger event [pull_request_target](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target) which maybe resolves the problem of accessing the base repository's secrets from a forked repository. The event `pull_request_target` has been used in some opensource repositories. I have tested it for a few hours last weekend, but it hasn’t been successful yet. I’ll go further and solve it next.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-797881425


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=h1) Report
   > Merging [#4910](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=desc) (7cc701f) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/beb5adb9855521341e8b88a31440075b9708b852?el=desc) (beb5adb) will **decrease** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4910      +/-   ##
   ============================================
   - Coverage     47.35%   47.21%   -0.14%     
   + Complexity     3697     3683      -14     
   ============================================
     Files           569      569              
     Lines         23928    23928              
     Branches       2759     2759              
   ============================================
   - Hits          11330    11298      -32     
   - Misses        11562    11596      +34     
   + Partials       1036     1034       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `16.66% <0.00%> (-16.67%)` | `1.00% <0.00%> (ø%)` | |
   | [...lphinscheduler/remote/future/ReleaseSemaphore.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZWxlYXNlU2VtYXBob3JlLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `29.82% <0.00%> (-5.27%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `70.73% <0.00%> (-4.88%)` | `9.00% <0.00%> (-1.00%)` | |
   | [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `16.66% <0.00%> (-4.63%)` | `10.00% <0.00%> (-3.00%)` | |
   | [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (-2.00%)` | `25.00% <0.00%> (ø%)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <0.00%> (-1.41%)` | `11.00% <0.00%> (-1.00%)` | |
   | [...olphinscheduler/plugin/alert/email/MailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvTWFpbFNlbmRlci5qYXZh) | `72.72% <0.00%> (-1.40%)` | `19.00% <0.00%> (-1.00%)` | |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=footer). Last update [beb5adb...7cc701f](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-788136484


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4910&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4910&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4910&metric=duplicated_lines_density&view=list) No Duplication information
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-797881425


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=h1) Report
   > Merging [#4910](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=desc) (a7f01ce) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/a3153b5e44d40cceea6e705f2406c4a4ec5f99c9?el=desc) (a3153b5) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4910      +/-   ##
   ============================================
   - Coverage     47.01%   46.93%   -0.09%     
   + Complexity     3681     3671      -10     
   ============================================
     Files           570      570              
     Lines         23941    23941              
     Branches       2757     2757              
   ============================================
   - Hits          11257    11236      -21     
   - Misses        11661    11682      +21     
     Partials       1023     1023              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...he/dolphinscheduler/remote/utils/ChannelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0NoYW5uZWxVdGlscy5qYXZh) | `16.66% <0.00%> (-16.67%)` | `1.00% <0.00%> (ø%)` | |
   | [...lphinscheduler/remote/future/ReleaseSemaphore.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZWxlYXNlU2VtYXBob3JlLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...inscheduler/remote/handler/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2hhbmRsZXIvTmV0dHlDbGllbnRIYW5kbGVyLmphdmE=) | `29.82% <0.00%> (-5.27%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `16.66% <0.00%> (-4.63%)` | `10.00% <0.00%> (-3.00%)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <0.00%> (-1.41%)` | `11.00% <0.00%> (-1.00%)` | |
   | [...olphinscheduler/plugin/alert/email/MailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvTWFpbFNlbmRlci5qYXZh) | `72.72% <0.00%> (-1.40%)` | `19.00% <0.00%> (-1.00%)` | |
   | [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `71.23% <0.00%> (-1.37%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...pache/dolphinscheduler/remote/command/Command.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ29tbWFuZC5qYXZh) | `60.60% <0.00%> (ø)` | `11.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=footer). Last update [a3153b5...a7f01ce](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on pull request #4910: [Improvement][CI] Replace token with github secrets

Posted by GitBox <gi...@apache.org>.
Jave-Chen commented on pull request #4910:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4910#issuecomment-790156349


   > Hi, workflows on pull request events can't read the token of base repository.
   > Maybe you can work aroud by pull_request_target event.
   > https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
   > https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull_request_target
   
   ref: https://github.com/apache/incubator-dolphinscheduler/pull/4102


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org