You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/12 16:05:28 UTC

[GitHub] [arrow] returnString edited a comment on pull request #9970: ARROW-12277: [Rust][DataFusion] Implement Sum/Count/Min/Max aggregates for Timestamp(_,_)

returnString edited a comment on pull request #9970:
URL: https://github.com/apache/arrow/pull/9970#issuecomment-817931084


   Thinking more about this: do we need to be careful about numeric limits? E.g. the current implementation of `AvgAccumulator` in the physical plan tracks the whole sum and count, and does `sum / count` at the end, meaning we might hit `i64::MAX` in the sum component given enough entries in an `avg` input with a sufficiently high-precision timestamp type.
   
   Edit: don't mind me, it forces an f64 accumulator - I saw `ScalarValue` and panicked :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org