You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/08/16 23:52:50 UTC
Review Request 68403: Updated tests for XFS disk resource statistics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68403/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.
Bugs: MESOS-5158
https://issues.apache.org/jira/browse/MESOS-5158
Repository: mesos
Description
-------
Updated the `disk/xfs` resource statistics tests to ensure that
statistics for persistent volumes are collected and published
correctly.
Diffs
-----
src/tests/containerizer/xfs_quota_tests.cpp 59ec182c1c3af3978156044f03d9e3d784d51fce
Diff: https://reviews.apache.org/r/68403/diff/1/
Testing
-------
sudo make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 68403: Updated tests for XFS disk resource
statistics.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68403/
-----------------------------------------------------------
(Updated Sept. 27, 2018, 6:02 p.m.)
Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.
Bugs: MESOS-5158
https://issues.apache.org/jira/browse/MESOS-5158
Repository: mesos
Description
-------
Updated the `disk/xfs` resource statistics tests to ensure that
statistics for persistent volumes are collected and published
correctly.
Diffs (updated)
-----
src/tests/containerizer/xfs_quota_tests.cpp 2b3a2e25f5075357f090d47826698e7bb6fdf969
Diff: https://reviews.apache.org/r/68403/diff/5/
Changes: https://reviews.apache.org/r/68403/diff/4-5/
Testing
-------
sudo make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 68403: Updated tests for XFS disk resource
statistics.
Posted by James Peach <jp...@apache.org>.
> On Sept. 20, 2018, 10:15 p.m., Ilya Pronin wrote:
> > src/tests/containerizer/xfs_quota_tests.cpp
> > Lines 879-881 (original), 904-906 (patched)
> > <https://reviews.apache.org/r/68403/diff/4/?file=2087669#file2087669line906>
> >
> > Nit: move `usage()` call below the started/working "locks" checking?
I'm going to drop this one. The `AWAIT` happens first so that we don't busy-poll on the filesystem state (it is basically rate-limiting the poll).
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68403/#review208818
-----------------------------------------------------------
On Aug. 16, 2018, 11:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68403/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 11:52 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the `disk/xfs` resource statistics tests to ensure that
> statistics for persistent volumes are collected and published
> correctly.
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 2b3a2e25f5075357f090d47826698e7bb6fdf969
>
>
> Diff: https://reviews.apache.org/r/68403/diff/4/
>
>
> Testing
> -------
>
> sudo make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 68403: Updated tests for XFS disk resource
statistics.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68403/#review208818
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/xfs_quota_tests.cpp
Lines 879-881 (original), 904-906 (patched)
<https://reviews.apache.org/r/68403/#comment293029>
Nit: move `usage()` call below the started/working "locks" checking?
src/tests/containerizer/xfs_quota_tests.cpp
Lines 983-985 (original), 1055-1057 (patched)
<https://reviews.apache.org/r/68403/#comment293030>
Ditto, move the call closer to where its result is used.
- Ilya Pronin
On Aug. 16, 2018, 4:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68403/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 4:52 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the `disk/xfs` resource statistics tests to ensure that
> statistics for persistent volumes are collected and published
> correctly.
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 2b3a2e25f5075357f090d47826698e7bb6fdf969
>
>
> Diff: https://reviews.apache.org/r/68403/diff/4/
>
>
> Testing
> -------
>
> sudo make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>