You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/11 11:14:09 UTC
[GitHub] [flink] shuttie commented on issue #10529: [FLINK-15171]
[serialization] fix performance regression caused by too many buffer
allocations on string serialization
shuttie commented on issue #10529: [FLINK-15171] [serialization] fix performance regression caused by too many buffer allocations on string serialization
URL: https://github.com/apache/flink/pull/10529#issuecomment-564494341
Raw serialization microbenchmarks:
before this PR:
```
[info] Benchmark (length) (stringType) Mode Cnt Score Error Units
[info] StringSerializerBenchmark.serializeImproved 1 ascii avgt 10 29.746 ± 1.522 ns/op
[info] StringSerializerBenchmark.serializeImproved 2 ascii avgt 10 31.293 ± 1.636 ns/op
[info] StringSerializerBenchmark.serializeImproved 4 ascii avgt 10 34.226 ± 1.311 ns/op
[info] StringSerializerBenchmark.serializeImproved 8 ascii avgt 10 38.368 ± 1.015 ns/op
[info] StringSerializerBenchmark.serializeImproved 16 ascii avgt 10 44.410 ± 0.674 ns/op
[info] StringSerializerBenchmark.serializeImproved 32 ascii avgt 10 56.724 ± 1.874 ns/op
[info] Benchmark (length) (stringType) Mode Cnt Score Error Units
[info] StringDeserializerBenchmark.deserializeImproved 1 ascii avgt 10 50.539 ± 1.434 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 2 ascii avgt 10 50.799 ± 1.676 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 4 ascii avgt 10 50.866 ± 1.856 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 8 ascii avgt 10 53.086 ± 2.656 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 16 ascii avgt 10 54.627 ± 0.142 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 32 ascii avgt 10 70.481 ± 11.272 ns/op
```
After this PR:
```
[info] Benchmark (length) (stringType) Mode Cnt Score Error Units
[info] StringSerializerBenchmark.serializeImproved 1 ascii avgt 10 25.427 ± 0.236 ns/op
[info] StringSerializerBenchmark.serializeImproved 2 ascii avgt 10 25.435 ± 0.640 ns/op
[info] StringSerializerBenchmark.serializeImproved 4 ascii avgt 10 31.293 ± 0.523 ns/op
[info] StringSerializerBenchmark.serializeImproved 8 ascii avgt 10 28.790 ± 0.183 ns/op
[info] StringSerializerBenchmark.serializeImproved 16 ascii avgt 10 32.189 ± 1.750 ns/op
[info] StringSerializerBenchmark.serializeImproved 32 ascii avgt 10 42.216 ± 1.703 ns/op
[info] Benchmark (length) (stringType) Mode Cnt Score Error Units
[info] StringDeserializerBenchmark.deserializeImproved 1 ascii avgt 10 50.706 ± 2.197 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 2 ascii avgt 10 50.994 ± 1.868 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 4 ascii avgt 10 51.580 ± 1.658 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 8 ascii avgt 10 53.936 ± 2.266 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 16 ascii avgt 10 62.628 ± 3.479 ns/op
[info] StringDeserializerBenchmark.deserializeImproved 32 ascii avgt 10 62.392 ± 0.559 ns/op
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services