[GitHub] [qpid-proton] astitcher commented on issue #181: PROTON-2040 [cpp] Allow connection options to be updated for reconnect

[GitBox <gi...@apache.org>]

astitcher commented on issue #181: PROTON-2040 [cpp] Allow connection options to be updated for reconnect
URL: https://github.com/apache/qpid-proton/pull/181#issuecomment-489131518
 
 
   I don't think I like this design much.
   
   If I understand it correctly when you get to the reconnect you can't modify the connection options but only overwrite them completely.
   
   This means that you have to keep around the original connection options and then update them with any changes. This is IMO inconvenient, but worse isn't what the API seems to offer with the name `reconnect_update()` - even if the comment is correct.
   
   I think it would it be better for the connection to keep around the connection options used and then you could really update them. If we implement it this way we could offer a more general `connection::connection_options()` accessor and allow that to be updated with the existing `connection_options::update()` API and not need the `reconnect_update()` API which is strangely specifically named for something that actually just overwrites the connection options and is not really related to reconnect (except by intention).
   
   In any event, I think that in order to sensibly offer this functionality someone has to remember the connection options so it might as well be the binding.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org