[GitHub] [arrow] pitrou commented on a diff in pull request #13385: ARROW-16521 [C++][R] Configure curl timeout policy for S3

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13385:
URL: https://github.com/apache/arrow/pull/13385#discussion_r898941480


##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -102,6 +102,8 @@ struct ARROW_EXPORT S3Options {
   /// the region (environment variables, configuration profile, EC2 metadata
   /// server).
   std::string region;
+  long request_timeout_ms = -1;
+  long connect_timeout_ms = -1;

Review Comment:
   We would probably want to be consistent accross the codebase and expose it as seconds, so perhaps:
   ```c++
     /// \brief Request timeout in seconds
     ///
     /// If not specified, the AWS SDK's default value will be used.
     util::optional<double> request_timeout;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org