[jira] [Commented] (S2GRAPH-127) Refactor ExceptionHander Object into Class.

["DOYUNG YOON (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652831#comment-15652831 ] 

DOYUNG YOON commented on S2GRAPH-127:
-------------------------------------

[~daewon] I agree the motivation and big +1 for it. We have not discussed about exception structure so I think it would be beneficial to open discussion for it specifically.

> Refactor ExceptionHander Object into Class.
> -------------------------------------------
>
>                 Key: S2GRAPH-127
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-127
>             Project: S2Graph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Daewon Jeong
>            Priority: Minor
>
> Improvement
> We are using one single global object ExceptionHandler to handle both of following fail scenario.
> # To publish all incoming requests({{WALLOG}}) into kafka topic.
> # To publish failed mutations when {{Storage}} failed to mutate into backend storage.
> {{WALLOG}} should be handled on REST server layer, not in {{s2core}}.
> {{FAILLOG}} on storage backend should be handled in {{s2core}}.
> Let's separate two case by changing ExceptionHandler from object to class so each case can use separate class instance for each usage.
> Basically, any failure on s2core should throw exception so client can decide how to process exception, but this can be large issue so let's make it separate issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)