You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/14 03:55:44 UTC
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5993
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
[mini_master] reorder methods in .cc to match .h order
Re-ordered methods in the mini_master.cc to match their declaration
order in mini_master.h. Also, added const modifier and updated
a couple of getter methods to return const reference instead of a copy.
This patch does not contain any functional changes.
Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
---
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
4 files changed, 74 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5993/1
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
Patch Set 2: Code-Review+2
Propagating +2 from Adar's review.
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5993
to look at the new patch set (#2).
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
[mini_master] reorder methods in .cc to match .h order
Re-ordered methods in the mini_master.cc to match their declaration
order in mini_master.h. Also, added const modifier and updated
a couple of getter methods to return const reference instead of a copy.
This patch does not contain any functional changes.
Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
---
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
4 files changed, 41 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5993/2
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [mini master] reorder methods in .cc to match .h order
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [mini_master] reorder methods in .cc to match .h order
......................................................................
[mini_master] reorder methods in .cc to match .h order
Re-ordered methods in the mini_master.cc to match their declaration
order in mini_master.h. Also, added const modifier and updated
a couple of getter methods to return const reference instead of a copy.
This patch does not contain any functional changes.
Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Reviewed-on: http://gerrit.cloudera.org:8080/5993
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
4 files changed, 41 insertions(+), 42 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4d30f9e7611e5a3d62019d3c740c7e262bfbd26
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>