You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2015/02/19 04:12:15 UTC
[GitHub] spark pull request: [SPARK-5816] Add huge compatibility warning in...
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/4687
[SPARK-5816] Add huge compatibility warning in DriverWrapper
The stability of the new submission gateway assumes that the arguments in `DriverWrapper` are consistent across multiple Spark versions. However, this is not at all clear from the code itself. In fact, this was broken in 20a6013106b56a1a1cc3e8cda092330ffbe77cc3, which is fortunately OK because both that commit and the original commit that added this gateway are part of the same release.
To prevent this from happening again we should at the very least add a huge warning where appropriate.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark driver-wrapper-warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4687
----
commit 7989b56f7dafc809cd25e5114cb6da044c42c79f
Author: Andrew Or <an...@databricks.com>
Date: 2015-02-19T03:07:52Z
Add huge compatibility warning
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5816] Add huge compatibility warning in...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4687#issuecomment-74998158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27705/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5816] Add huge compatibility warning in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5816] Add huge compatibility warning in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4687#issuecomment-74998155
[Test build #27705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27705/consoleFull) for PR 4687 at commit [`7989b56`](https://github.com/apache/spark/commit/7989b56f7dafc809cd25e5114cb6da044c42c79f).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class JavaFPGrowthExample `
* `public class JavaPowerIterationClusteringExample `
* `class Partitioner(object):`
* `class SparkJobInfo(namedtuple("SparkJobInfo", "jobId stageIds status")):`
* `class SparkStageInfo(namedtuple("SparkStageInfo",`
* `class StatusTracker(object):`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5816] Add huge compatibility warning in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4687#issuecomment-74993116
[Test build #27705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27705/consoleFull) for PR 4687 at commit [`7989b56`](https://github.com/apache/spark/commit/7989b56f7dafc809cd25e5114cb6da044c42c79f).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org