You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 02:19:41 UTC
[GitHub] [flink-ml] jiangxin369 opened a new pull request, #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly
jiangxin369 opened a new pull request, #167:
URL: https://github.com/apache/flink-ml/pull/167
<!--
*Thank you very much for contributing to Apache Flink ML - we are happy that you want to help us improve Flink ML. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to one [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] Title of the pull request`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Replace `FeaturesCol` with `InputCol` in VarianceThresholdSelector.
## Brief change log
- Add Javadoc for `HasFeaturesCol` to distinguish `HasInputCol`
- Replace `FeaturesCol` with `InputCol` in VarianceThresholdSelector.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 closed pull request #167: [FLINK-29786] VarianceThresholdSelector should implement HasInputCol
Posted by GitBox <gi...@apache.org>.
lindong28 closed pull request #167: [FLINK-29786] VarianceThresholdSelector should implement HasInputCol
URL: https://github.com/apache/flink-ml/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on pull request #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly
Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #167:
URL: https://github.com/apache/flink-ml/pull/167#issuecomment-1294918502
Thanks for the update. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on a diff in pull request #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly
Posted by GitBox <gi...@apache.org>.
lindong28 commented on code in PR #167:
URL: https://github.com/apache/flink-ml/pull/167#discussion_r1007646156
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeaturesCol.java:
##########
@@ -24,6 +24,14 @@
import org.apache.flink.ml.param.WithParams;
/** Interface for the shared featuresCol param. */
+
+/**
+ * Interface for the shared featuresCol param.
Review Comment:
Should we remove the redundant description above?
And it might be simpler and softer to use the following doc:
```
/**
* Interface for the shared featuresCol param.
*
* {@link HasFeaturesCol} is typically used for {@link Stage}s that implement {@link HasLabelCol}. It is preferred
* to use {@link HasInputCol} for other cases.
*/
```
Please also update the corresponding python doc if we make the change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #167: [FLINK-29786] VarianceThresholdSelector Uses FeaturesCol Incorrectly
Posted by GitBox <gi...@apache.org>.
jiangxin369 commented on code in PR #167:
URL: https://github.com/apache/flink-ml/pull/167#discussion_r1007777855
##########
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeaturesCol.java:
##########
@@ -24,6 +24,14 @@
import org.apache.flink.ml.param.WithParams;
/** Interface for the shared featuresCol param. */
+
+/**
+ * Interface for the shared featuresCol param.
Review Comment:
Thanks for the review, I updated the docs of Java and Python according to your expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org