[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class
URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r380689645
 
 

 ##########
 File path: extensions/http-curl/client/HTTPCallback.h
 ##########
 @@ -33,148 +34,195 @@ namespace minifi {
 namespace utils {
 
 /**
- * will stream as items are processed.
+ * The original class here was deadlock-prone, undocumented and was a smorgasbord of multithreading primitives used inconsistently.
+ * This is a rewrite based on the contract inferred from this class's usage in utils::HTTPClient
+ * through HTTPStream and the non-buggy part of the behaviour of the original class.
+ * Based on these:
 
 Review comment:
   Code comments meant to document the current state of the code, not its history. Use commit messages, PR description and/or release notes for documenting the history of the class.
   
   The points (below) documenting the behavior are nice and appreciated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services