You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/02/17 21:02:27 UTC
[jira] Created: (THRIFT-707) Support old-style constructors for
Union structs
Support old-style constructors for Union structs
------------------------------------------------
Key: THRIFT-707
URL: https://issues.apache.org/jira/browse/THRIFT-707
Project: Thrift
Issue Type: Improvement
Components: Library (Ruby)
Affects Versions: 0.2
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Fix For: 0.3
It would be pretty handy if the new Union struct constructors could also take in the old-style hash constructor. This would lead to less code breakage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-707) Support old-style constructors for
Union structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-707:
---------------------------------
Attachment: thrift-707.patch
This patch make the constructor check if the first arg is a hash, and if so, it unwraps it before carrying on.
If there are no objections, I will commit this today.
> Support old-style constructors for Union structs
> ------------------------------------------------
>
> Key: THRIFT-707
> URL: https://issues.apache.org/jira/browse/THRIFT-707
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-707.patch
>
>
> It would be pretty handy if the new Union struct constructors could also take in the old-style hash constructor. This would lead to less code breakage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-707) Support old-style constructors for
Union structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-707.
--------------------------------
Resolution: Fixed
I just committed this patch.
> Support old-style constructors for Union structs
> ------------------------------------------------
>
> Key: THRIFT-707
> URL: https://issues.apache.org/jira/browse/THRIFT-707
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-707.patch
>
>
> It would be pretty handy if the new Union struct constructors could also take in the old-style hash constructor. This would lead to less code breakage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.