[jira] [Commented] (QPID-5517) Build system ignores user-defined CFLAGS

["Andrew Stitcher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883227#comment-13883227 ] 

Andrew Stitcher commented on QPID-5517:
---------------------------------------

This is an incorrect and fragile fix.

This is because the original CMake configuration is wrong but looks good enough to confuse you into "fixing" it rather than solving the problem.

Instead of using CMAKE_C_FLAGS the cmake configuration should probably be using

add_compile_options() to affect every file compiled in this directory or lower (I think this is what is wanted here)

[CMAKE_C_FLAGS should not be changed inside the CMake configuration files its use is really reserved for overall configuration]

> Build system ignores user-defined CFLAGS
> ----------------------------------------
>
>                 Key: QPID-5517
>                 URL: https://issues.apache.org/jira/browse/QPID-5517
>             Project: Qpid
>          Issue Type: Bug
>          Components: Qpid Dispatch
>            Reporter: Darryl L. Pierce
>            Assignee: Darryl L. Pierce
>         Attachments: qpid-dispatch-cflags.patch
>
>
> When setting the CFLAGS in CMakeLists.txt, the system should append the project's flags to those defined by the user when setting the value.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org