[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11393: feat: support round cap for polar bars

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #11393: feat: support round cap for polar bars
URL: https://github.com/apache/incubator-echarts/pull/11393#discussion_r335112410
 
 

 ##########
 File path: src/layout/barPolar.js
 ##########
 @@ -79,6 +79,8 @@ function barLayoutPolar(seriesType, ecModel, api) {
         var valueDim = data.mapDimension(valueAxis.dim);
         var baseDim = data.mapDimension(baseAxis.dim);
         var stacked = isDimensionStacked(data, valueDim /*, baseDim*/);
+        var clampLayout = baseDim !== 'radius'
 
 Review comment:
   baseDim is not necessarily `'radius'` if `encode` is used in option, but `baseAxis.dim` must be `'radius'` if it is a radius axis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org