[GitHub] [curator] Randgalt opened a new pull request #337: CURATOR-549

[GitBox <gi...@apache.org>]

Randgalt opened a new pull request #337: CURATOR-549
URL: https://github.com/apache/curator/pull/337
 
 
   ### 3.6.0 has many changes
   
   ZooKeeper 3.6.0 has some significant changes from previous versions and a significant portion of this PR is only bringing Curator up to date. Some of these changes are:
   
   - The reconfig APIs have moved into a new class, `ZooKeeperAdmin`. This class existed in 3.5.x but wasn't required. Now it is. 
   - `DefaultZookeeperFactory` now checks `Compatibility.hasZooKeeperAdmin()` and creates a `ZooKeeperAdmin` if it's available
   - A bunch of little things changed in the ZK server code which affected Curator's test classes. I moved it all into reflection based calls in `Compatibility.java` in the test module. We now have modules that test ZK 3.4, 3.5 and 3.6 so we're safe with compatibility.
   - ZooKeeper's `MultiTransactionRecord` has been removed it seems. That forced `CuratorMultiTransactionRecord` to be re-written. It's not a public class so hopefully it won't affect anyone.
   
   ### New module
   
   There is a new module, `curator-test-zk35`. It forces ZooKeeper 3.5.6 and performs selected tests from the other modules to ensure compatibility. Tests annotated with TestNG groups `zk35` and `zk35Compatibility` are tested. Group `zk36` is excluded. Note: these tests will only run from Maven. I don't think IntelliJ/Eclipse support the Maven syntax I used.
   
   ### 3 More PRs coming
   
   I have 3 more PRs that will be separate from this to avoid too much review pain:
   
   - #335 
   - #336

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services