[GitHub] [helix] narendly commented on a change in pull request #601: Add new constructors and close() to Helix API

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #601: Add new constructors and close() to Helix API
URL: https://github.com/apache/helix/pull/601#discussion_r345952014
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
 ##########
 @@ -90,12 +90,16 @@
 
   private final HelixZkClient _zkClient;
   private final ConfigAccessor _configAccessor;
+  // true if ZKHelixAdmin was instantiated with a HelixZkClient, false otherwise
+  // This is used for close() to determine how ZKHelixAdmin should close the underlying ZkClient
+  private boolean _usesExternalZkClient;
 
 Review comment:
   Added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org