[GitHub] [airflow] monti-python commented on a change in pull request #15637: Fix WasbHook.delete_file broken when using prefix

[GitBox <gi...@apache.org>]

monti-python commented on a change in pull request #15637:
URL: https://github.com/apache/airflow/pull/15637#discussion_r625564602



##########
File path: airflow/providers/microsoft/azure/hooks/wasb.py
##########
@@ -407,7 +407,7 @@ def delete_file(
         :type kwargs: object
         """
         if is_prefix:
-            blobs_to_delete = self.get_blobs_list(container_name, prefix=blob_name, **kwargs)
+            blobs_to_delete = self.get_blobs_list(container_name, prefix=blob_name, delimiter='', **kwargs)

Review comment:
       Hi @ephraimbuddy, thanks a lot for reviewing. 
   
   Using a delimiter other than the empty string `''` might lead to non-terminal blob _paths_. Would you suggest declaring the delimiter as a local variable, and then passing it to `get_blobs_list` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org