You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/09/04 02:03:30 UTC
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18937
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
IMPALA-11490: Add more metrics for event processor
This patch adds more metrics to debug event processing lagging behind.
The latest event id in HMS is added so users can compare it with the
last synced event id to know how many events are waiting to be synced.
The event time of the last synced event and latest event in HMS are also
added. Users can compare them to know how long catalogd is lagging
behind. The update of the latest event id and event time are done in a
dedicated thread in case the event-processor thread is blocked by slow
metadata reloading or waiting for table locks.
This patch also fixes the wrong metrics on events fetching and
processing duration. Previously the method we used is
Timer.getMeanRate() which returns the mean rate at which the duration is
recorded. The correct method should be Timer.getSnapshot().getMean(). By
getting the snapshot, we can also expose metrics of the 75th/95th/99th
percentiles.
To facilitate metrics collection, the last durations of events fetching
and processing are also exposed.
Tests:
- Manually verified the metrics when running some Hive workloads
Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
---
M be/src/util/event-metrics.cc
M be/src/util/event-metrics.h
M common/thrift/JniCatalog.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
6 files changed, 374 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/18937/1
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18937/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/18937/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@893
PS1, Line 893: LOG.info("Latest event in HMS: id={}, time={}", currentEventId, event.getEventTime());
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 04 Sep 2022 02:04:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@878
PS2, Line 878: CurrentNotificationEventId currentNotificationEventId =
: msClient.getHiveClient().getCurrentNotificationEventId();
> Can't this make a slow HMS even slower? If I understand correctly these cal
Yeah, it needs to query the underlying database of HMS. But I think this is a light weight operation and we already use it in many places, e.g. create/drop a database/table, alterTable, loading table, etc.
https://github.com/apache/impala/blob/b6d6e86f1ec3fc45dccdbdc0933a235668dae2c4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L2535
https://github.com/apache/impala/blob/b25e250d321f329b98e017c648df75d052497963/fe/src/main/java/org/apache/impala/catalog/TableLoader.java#L98
https://github.com/apache/impala/blob/4186727fe6cc35a10a0565214d1c593b9006d862/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java#L286
https://github.com/apache/impala/blob/da3d6fc7f7c656b118bb3570cedf7d7c3158bd0b/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L3402
https://github.com/apache/impala/blob/da3d6fc7f7c656b118bb3570cedf7d7c3158bd0b/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L4610
If HMS is slow due to catalogd, maybe the cause come from other operations instead of this.
One concern on polling all events into a queue is that the buffer size cannot be limited (otherwise the update of latest event id is stuck again). I've seen a case that there are around 200k pending events to be processing. The event contains the hmsTable or hmsPartition objects which could have a non-trivial memory footprint. So I think currently we keep 1000 events in memory is more controllable.
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 01:16:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8543/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 10:32:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 15:20:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18937
to look at the new patch set (#2).
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
IMPALA-11490: Add more metrics for event processor
This patch adds more metrics to debug event processing lagging behind.
The latest event id in HMS is added so users can compare it with the
last synced event id to know how many events are waiting to be synced.
The event time of the last synced event and latest event in HMS are also
added. Users can compare them to know how long catalogd is lagging
behind. The update of the latest event id and event time are done in a
dedicated thread in case the event-processor thread is blocked by slow
metadata reloading or waiting for table locks.
This patch also fixes the wrong metrics on events fetching and
processing duration. Previously the method we used is
Timer.getMeanRate() which returns the mean rate at which the duration is
recorded. The correct method should be Timer.getSnapshot().getMean(). By
getting the snapshot, we can also expose metrics of the 75th/95th/99th
percentiles.
To facilitate metrics collection, the last durations of events fetching
and processing are also exposed.
Tests:
- Manually verified the metrics when running some Hive workloads
Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
---
M be/src/util/event-metrics.cc
M be/src/util/event-metrics.h
M common/thrift/JniCatalog.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
6 files changed, 375 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/18937/2
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11282/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Sun, 04 Sep 2022 05:39:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@878
PS2, Line 878: CurrentNotificationEventId currentNotificationEventId =
: msClient.getHiveClient().getCurrentNotificationEventId();
Can't this make a slow HMS even slower? If I understand correctly these calls become database queries in HMS.
https://github.com/apache/hive/blob/4e4e39c471094567dcdfd9840edbd99d7eafc230/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L11846
https://github.com/apache/hive/blob/4e4e39c471094567dcdfd9840edbd99d7eafc230/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java#L2603
The idea would be to poll the new events as we are doing it now and keep a queue in Impala, but do the processing on a different thread. This way we could get an update every pollingFrequencyInSec_ without increasing HMS load when the processing is up to date.
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 16:11:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
IMPALA-11490: Add more metrics for event processor
This patch adds more metrics to debug event processing lagging behind.
The latest event id in HMS is added so users can compare it with the
last synced event id to know how many events are waiting to be synced.
The event time of the last synced event and latest event in HMS are also
added. Users can compare them to know how long catalogd is lagging
behind. The update of the latest event id and event time are done in a
dedicated thread in case the event-processor thread is blocked by slow
metadata reloading or waiting for table locks.
This patch also fixes the wrong metrics on events fetching and
processing duration. Previously the method we used is
Timer.getMeanRate() which returns the mean rate at which the duration is
recorded. The correct method should be Timer.getSnapshot().getMean(). By
getting the snapshot, we can also expose metrics of the 75th/95th/99th
percentiles.
To facilitate metrics collection, the last durations of events fetching
and processing are also exposed.
Tests:
- Manually verified the metrics when running some Hive workloads
Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Reviewed-on: http://gerrit.cloudera.org:8080/18937
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/event-metrics.cc
M be/src/util/event-metrics.h
M common/thrift/JniCatalog.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
6 files changed, 375 insertions(+), 30 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 2:
Thanks for your review, Csaba!
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 10:31:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11280/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 04 Sep 2022 02:24:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:
http://gerrit.cloudera.org:8080/#/c/18937/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@878
PS2, Line 878: CurrentNotificationEventId currentNotificationEventId =
: msClient.getHiveClient().getCurrentNotificationEventId();
> I've seen a case that there are around 200k pending events
Ouch, that sounds pretty bad
I am ok with the current solution.
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 08:30:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11490: Add more metrics for event processor
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18937 )
Change subject: IMPALA-11490: Add more metrics for event processor
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7d40a0d8e140e6b0698936e97b454cb9abdc1b
Gerrit-Change-Number: 18937
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 10:32:26 +0000
Gerrit-HasComments: No