You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by co...@apache.org on 2001/10/16 05:12:42 UTC

cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade HttpServletRequestFacade.java

costin      01/10/15 20:12:42

  Modified:    src/facade22/org/apache/tomcat/facade
                        HttpServletRequestFacade.java
  Log:
  Change back a previous fix. Notes are reset when the request is recycled.
  
  Revision  Changes    Path
  1.30      +5 -11     jakarta-tomcat/src/facade22/org/apache/tomcat/facade/HttpServletRequestFacade.java
  
  Index: HttpServletRequestFacade.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/HttpServletRequestFacade.java,v
  retrieving revision 1.29
  retrieving revision 1.30
  diff -u -r1.29 -r1.30
  --- HttpServletRequestFacade.java	2001/10/04 20:18:08	1.29
  +++ HttpServletRequestFacade.java	2001/10/16 03:12:42	1.30
  @@ -110,26 +110,20 @@
           this.request = request;
   	isFacade.setRequest( request );
   	try {
  -	    // we may create facades more often than requests 
  -	    Object o=request.getNote( "req.dateFormats" );
  -	    if( o==null ) {
  -		o=new DateFormat[] {
  +	    // we may create facades more often than requests
  +	    if( dateFormats==null ) {
  +		dateFormats=new DateFormat[] {
   		    new SimpleDateFormat(DateTool.RFC1123_PATTERN, Locale.US),
   		    new SimpleDateFormat(DateTool.rfc1036Pattern, Locale.US),
   		    new SimpleDateFormat(DateTool.asctimePattern, Locale.US)
   		};
  -		request.setNote( "req.dateFormats", o );
   	    }
  -	    dateFormats=(DateFormat[])o;
  -	    o=request.getNote( "req.uencoder" );
  -	    if( o==null ) {
  +	    if( uencoder==null ) {
   		uencoder=new UEncoder();
   		uencoder.addSafeCharacter(';');
   		uencoder.addSafeCharacter('/');
   		request.setNote( "req.uencoder", uencoder );
  -	    } else {
  -		uencoder=(UEncoder)o;
  -	    }
  +	    } 
   	} catch( TomcatException ex ) {
   	    ex.printStackTrace();
   	}