formatting (Re: svn commit: r668715)

[David Blevins <da...@visi.com>]

Rick, fantastic to see some javadoc in that code!!!  Very excellent.

On Jun 17, 2008, at 8:43 AM, rickmcguire@apache.org wrote:

> Author: rickmcguire
> Date: Tue Jun 17 08:43:37 2008
> New Revision: 668715


> -                if (conversion == null) throw new  
> NullPointerException("unsupported conversion for EJB select return  
> type " + to.getName());
> +                {
> +                    if (conversion == null)
> +                        throw new NullPointerException("unsupported  
> conversion for EJB select return type " + to.getName());
> +                }

FYI, you might want to check your editor's settings.  Weird use of  
braces there.

> -            if (!ejbCreate.getName().startsWith("ejbCreate"))  
> continue;
> +            if (!ejbCreate.getName().startsWith("ejbCreate"))
> +            {
> +                continue;
> +            }

Single line ifs are fine.  Splitting them with braces is fine too.   
FYI, make sure you follow the brace format of the rest of the code  
though.

Overall, a quite impressive 268 lines of new javadoc + comments.   
About 260 more lines than before :)

-David

Re: formatting (Re: svn commit: r668715)

[David Blevins <da...@visi.com>]

On Jun 18, 2008, at 1:00 PM, David Blevins wrote:

> Overall, a quite impressive 268 lines of new javadoc + comments.   
> About 260 more lines than before :)

Ok, bad math in that second sentence :)  Joke was to imply that there  
were only about 8 comments before.  Swing and a miss!

-David