You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2008/06/30 17:23:44 UTC

EntityEcaUtil.getEntityEcaRules has a generics bug

org.ofbiz.entityext.eca.EntityEcaUtil.getEntityEcaRules() returns a 
Collection.  If it finds the event that is being requested, then that 
collection contains EntityEcaRule.

However, if eventMap is found, but the event is not, then it returns the 
maps *values*, which is a Collection of Collections of EntityEcaRules. 
This can not be correct.  Calling code would fall over in this case.

I'm leaning towards having it return null, as if the eventMap is not 
found, this is what would already occur.