You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/20 15:17:16 UTC

[GitHub] [nifi] MikeThomsen opened a new pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

MikeThomsen opened a new pull request #4771:
URL: https://github.com/apache/nifi/pull/4771


   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _Enables X functionality; fixes bug NIFI-YYYY._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763708883


   I will simply review code and trust you validated it.  We're good if the build is good on this in my view.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4771:
URL: https://github.com/apache/nifi/pull/4771


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4771:
URL: https://github.com/apache/nifi/pull/4771


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763703079


   assuming build is happy i'll merge


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763711741


   @joewitt cool, but I'm a believer in "trust, but verify" so here is a screenshot of my terminal showing queries against the table matching the steps I showed:
   
   <img width="823" alt="Screen Shot 2021-01-20 at 10 30 10 AM" src="https://user-images.githubusercontent.com/108184/105197394-93a81980-5b0a-11eb-9282-a1a2476c4c3c.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763714975


   Ha!  Me too.  I trust it was broken and you've verified your fix ;)
   
   But yeah thanks for sharing and thanks for tackling.  Will monitor the build.  Tagged to 1.13 so I wont miss it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen edited a comment on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
MikeThomsen edited a comment on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763707997


   @joewitt here are test instructions:
   
   ```
   docker run -p 7000:7000 -p 9042:9042 --name cassandra -d cassandra:3
   ```
   
   ```
   CREATE KEYSPACE byte_test WITH replication = {'class':'SimpleStrategy', 'replication_factor' : 3};
   use byte_test;
   create table binary_test (id text, data blob, primary key(id));
   ```
   
   [Cassandra_Byte_Array_Test.xml.txt](https://github.com/apache/nifi/files/5843448/Cassandra_Byte_Array_Test.xml.txt)
   
   Once it's running, you can test with:
   
   ```
   select id, blobastext(data) from binary_test;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen commented on pull request #4771: NIFI-8156 Fixed byte handling bug in cassandra.

Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on pull request #4771:
URL: https://github.com/apache/nifi/pull/4771#issuecomment-763707997


   @joewitt here are test instructions:
   
   ```
   docker run -p 7000:7000 -p 9042:9042 --name cassandra -d cassandra:3
   ```
   
   ```
   CREATE KEYSPACE byte_test WITH replication = {'class':'SimpleStrategy', 'replication_factor' : 3};
   use byte_test;
   create table binary_test (id text, data blob, primary key(id));
   ```
   
   [Cassandra_Byte_Array_Test.xml.txt](https://github.com/apache/nifi/files/5843448/Cassandra_Byte_Array_Test.xml.txt)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org