[jira] [Commented] (ORC-412) [C++] ORC: Char(n) and Varchar(n) writers truncate to n bytes & corrupts multi-byte data

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642894#comment-16642894 ] 

ASF GitHub Bot commented on ORC-412:
------------------------------------

wgtmac opened a new pull request #317: ORC-412: [C++] Fix Char(n) and Varchar(n) writers with UTF-8
URL: https://github.com/apache/orc/pull/317
 
 
   This patch is the parity of ORC-406 on the C++ side. Now char and varchar writers respect maximum length of UTF-8 characters in the specified file type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] ORC: Char(n) and Varchar(n) writers truncate to n bytes & corrupts multi-byte data
> ----------------------------------------------------------------------------------------
>
>                 Key: ORC-412
>                 URL: https://issues.apache.org/jira/browse/ORC-412
>             Project: ORC
>          Issue Type: Bug
>    Affects Versions: 1.5.2
>            Reporter: Gang Wu
>            Assignee: Gang Wu
>            Priority: Major
>
> https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/writer/CharTreeWriter.java#L41
> {code}
>     itemLength = schema.getMaxLength();
>     padding = new byte[itemLength];
>   }
> {code}
> https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/writer/VarcharTreeWriter.java#L48
> {code}
>       if (vector.noNulls || !vector.isNull[0]) {
>         int itemLength = Math.min(vec.length[0], maxLength);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)