You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/11 14:34:59 UTC
[GitHub] TisonKun commented on a change in pull request #6491: [FLINK-10057]
Update FlinkYarnSessionCli.java
TisonKun commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#discussion_r216692845
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -530,6 +530,11 @@ protected Configuration applyCommandLineOptionsToConfiguration(CommandLine comma
private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
boolean canApplyYarnProperties = !commandLine.hasOption(addressOption.getOpt());
+ // if canApplyYarnProperties is false,return quickly !
+ if (!canApplyYarnProperties) {
+ return canApplyYarnProperties;
Review comment:
+1 to the latter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services