You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "QiuYucheng2003 (via GitHub)" <gi...@apache.org> on 2026/01/13 02:01:47 UTC

[I] [Improvement] Avoid potential OOM in SessionPoolExample by replacing unbounded thread pool [iotdb]

QiuYucheng2003 opened a new issue, #17016:
URL: https://github.com/apache/iotdb/issues/17016

   ### Search before asking
   
   - [x] I searched in the [issues](https://github.com/apache/iotdb/issues) and found nothing similar.
   
   
   ### Version
   
   Master
   
   ### Describe the bug and provide the minimal reproduce step
   
   Description:
   In example/session/src/main/java/org/apache/iotdb/SessionPoolExample.java, the ExecutorService is initialized using Executors.newFixedThreadPool(10) (Line 74).
   
   Problem: 
   Executors.newFixedThreadPool uses an unbounded LinkedBlockingQueue (capacity: Integer.MAX_VALUE) by default. As this is an official example, users often copy-paste this code for production. In high-throughput write scenarios, if the production rate exceeds the consumption rate, tasks accumulate indefinitely in the queue, leading to OutOfMemoryError: Java heap space.
   
   Code Location:
   // org.apache.iotdb.SessionPoolExample.java
   service = Executors.newFixedThreadPool(10); // Unbounded Queue risk
   
   ### What did you expect to see?
   
   Official examples should demonstrate best practices by using bounded queues to ensure system stability. The thread pool should provide backpressure (block or reject) when the queue is full, preventing memory exhaustion.
   
   ### What did you see instead?
   
   The example uses an unbounded queue pattern (UBSCQ), which creates a hidden memory leak risk for downstream users who adopt this code snippet.
   
   ### Anything else?
   
   Suggested Fix: Replace the factory method with a custom ThreadPoolExecutor using a bounded queue (e.g., ArrayBlockingQueue).
   
   Proposed Code:
   service = new ThreadPoolExecutor(
       10, 10, 0L, TimeUnit.MILLISECONDS,
       new ArrayBlockingQueue<>(1000) // Bounded capacity
   );
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement] Avoid potential OOM in SessionPoolExample by replacing unbounded thread pool [iotdb]

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on issue #17016:
URL: https://github.com/apache/iotdb/issues/17016#issuecomment-3741668967

   Welcome to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement] Avoid potential OOM in SessionPoolExample by replacing unbounded thread pool [iotdb]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #17016:
URL: https://github.com/apache/iotdb/issues/17016#issuecomment-3741431847

   Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improvement] Avoid potential OOM in SessionPoolExample by replacing unbounded thread pool [iotdb]

Posted by "QiuYucheng2003 (via GitHub)" <gi...@apache.org>.
QiuYucheng2003 commented on issue #17016:
URL: https://github.com/apache/iotdb/issues/17016#issuecomment-3741879093

   Thank you! I have just submitted the PR to fix this issue. Please take a look when you have a chance. Any feedback is appreciated.
   
   > Welcome to submit a PR!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org