You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 16:21:08 UTC
[GitHub] [spark] johnhany97 opened a new pull request #31902: [SPARK-34803] Pass the raised ImportError if pandas or pyarrow fail to import
johnhany97 opened a new pull request #31902:
URL: https://github.com/apache/spark/pull/31902
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Pass the raised `ImportError` on failing to import pandas/pyarrow. This will help the user identify whether pandas/pyarrow are indeed not in the environment or if they threw a different `ImportError`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This can already happen in Pandas for example where it could throw an `ImportError` on its initialisation path if `dateutil` doesn't satisfy a certain version requirement https://github.com/pandas-dev/pandas/blob/0.24.x/pandas/compat/__init__.py#L438
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598272334
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas "
+ "on importing the library." % minimum_pandas_version, raised_error)
Review comment:
This makes sense for Spark 3.1 - but if we were to backport this to Spark 3.0, 2.4 - we'll need to keep the current syntax as that's the Py2 & Py3-compatible way of doing exception chaining
Happy to move forwards with your suggestion, but keep in mind this will involve us adjusting this implementation in the backports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598155857
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas"
Review comment:
It seems that we need an addition space at the end of this string. `pandas"` -> `pandas "`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804053432
**[Test build #136344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136344/testReport)** for PR 31902 at commit [`b21b67a`](https://github.com/apache/spark/commit/b21b67a187b59d5dae6e2eb7e93e53f06574a5c4).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803140502
**[Test build #136269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136269/testReport)** for PR 31902 at commit [`bf47b43`](https://github.com/apache/spark/commit/bf47b4316f7bc7c00cfc83a299712871446b6c67).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598157264
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas"
Review comment:
Addressed in https://github.com/apache/spark/pull/31902/commits/30542f345f739a63c67c876b4b87f7a0240f228e
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -47,11 +49,13 @@ def require_minimum_pyarrow_version():
try:
import pyarrow
have_arrow = True
- except ImportError:
+ except ImportError as error:
have_arrow = False
+ raised_error = error
if not have_arrow:
raise ImportError("PyArrow >= %s must be installed; however, "
- "it was not found." % minimum_pyarrow_version)
+ "it was not found or an error was thrown by pyarrow"
Review comment:
Addressed in https://github.com/apache/spark/pull/31902/commits/30542f345f739a63c67c876b4b87f7a0240f228e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804105765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40928/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598651987
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,12 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
Review comment:
I would just remove this one though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804105700
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40928/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803463066
**[Test build #136288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136288/testReport)** for PR 31902 at commit [`30542f3`](https://github.com/apache/spark/commit/30542f345f739a63c67c876b4b87f7a0240f228e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598684246
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,12 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
Review comment:
Addressed in b21b67a187b59d5dae6e2eb7e93e53f06574a5c4 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598155939
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -47,11 +49,13 @@ def require_minimum_pyarrow_version():
try:
import pyarrow
have_arrow = True
- except ImportError:
+ except ImportError as error:
have_arrow = False
+ raised_error = error
if not have_arrow:
raise ImportError("PyArrow >= %s must be installed; however, "
- "it was not found." % minimum_pyarrow_version)
+ "it was not found or an error was thrown by pyarrow"
Review comment:
ditto. A space? `pyarrow"` -> `pyarrow "`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804165436
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803127142
**[Test build #136269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136269/testReport)** for PR 31902 at commit [`bf47b43`](https://github.com/apache/spark/commit/bf47b4316f7bc7c00cfc83a299712871446b6c67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-802974701
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804012687
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803156412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-802974701
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803994282
**[Test build #136342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136342/testReport)** for PR 31902 at commit [`02ba207`](https://github.com/apache/spark/commit/02ba207ccd0c9e89985cfbd4b9f61478e6487b46).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804052703
**[Test build #136344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136344/testReport)** for PR 31902 at commit [`b21b67a`](https://github.com/apache/spark/commit/b21b67a187b59d5dae6e2eb7e93e53f06574a5c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803157905
This looks like a flake in the tests:
```
Err:20 http://security.debian.org/debian-security buster/updates/main amd64 libldap-common all 2.4.47+dfsg-3+deb10u4
404 Not Found [IP: 151.101.194.132 80]
Err:21 http://security.debian.org/debian-security buster/updates/main amd64 libldap-2.4-2 amd64 2.4.47+dfsg-3+deb10u4
404 Not Found [IP: 151.101.194.132 80]
Fetched 7590 kB in 1s (12.4 MB/s)
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/o/openldap/libldap-common_2.4.47+dfsg-3+deb10u4_all.deb 404 Not Found [IP: 151.101.194.132 80]
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/o/openldap/libldap-2.4-2_2.4.47+dfsg-3+deb10u4_amd64.deb 404 Not Found [IP: 151.101.194.132 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command '/bin/sh -c echo "deb http://cloud.r-project.org/bin/linux/debian buster-cran35/" >> /etc/apt/sources.list && apt install -y gnupg && (apt-key adv --keyserver keys.gnupg.net --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF' || apt-key adv --keyserver keys.openpgp.org --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF') && apt-get update && apt install -y -t buster-cran35 r-base r-base-dev && rm -rf /var/cache/apt/*' returned a non-zero code: 100
Failed to build SparkR Docker image, please refer to Docker build output for details.
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804053457
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136344/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804053457
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136344/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804125070
**[Test build #136350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136350/testReport)** for PR 31902 at commit [`e63f4cf`](https://github.com/apache/spark/commit/e63f4cf19b2a2d433c4fe0096fd9ec63ad7b9cfa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804190673
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804179915
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803468096
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40870/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804012717
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804009112
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598206542
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas "
+ "on importing the library." % minimum_pandas_version, raised_error)
Review comment:
what about we just leverage exception chaining: https://docs.python.org/3/tutorial/errors.html#exception-chaining?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804135656
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804012717
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40926/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803458536
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598206508
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas "
+ "on importing the library." % minimum_pandas_version, raised_error)
Review comment:
```suggestion
"it was not found or an error was thrown by pandas "
"it was not found." % minimum_pandas_version) from error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 edited a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 edited a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803157905
This looks like a flake in the tests:
```
Err:20 http://security.debian.org/debian-security buster/updates/main amd64 libldap-common all 2.4.47+dfsg-3+deb10u4
404 Not Found [IP: 151.101.194.132 80]
Err:21 http://security.debian.org/debian-security buster/updates/main amd64 libldap-2.4-2 amd64 2.4.47+dfsg-3+deb10u4
404 Not Found [IP: 151.101.194.132 80]
Fetched 7590 kB in 1s (12.4 MB/s)
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/o/openldap/libldap-common_2.4.47+dfsg-3+deb10u4_all.deb 404 Not Found [IP: 151.101.194.132 80]
E: Failed to fetch http://security.debian.org/debian-security/pool/updates/main/o/openldap/libldap-2.4-2_2.4.47+dfsg-3+deb10u4_amd64.deb 404 Not Found [IP: 151.101.194.132 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command '/bin/sh -c echo "deb http://cloud.r-project.org/bin/linux/debian buster-cran35/" >> /etc/apt/sources.list && apt install -y gnupg && (apt-key adv --keyserver keys.gnupg.net --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF' || apt-key adv --keyserver keys.openpgp.org --recv-key 'E19F5F87128899B192B1A2C2AD5F960A256A04AF') && apt-get update && apt install -y -t buster-cran35 r-base r-base-dev && rm -rf /var/cache/apt/*' returned a non-zero code: 100
Failed to build SparkR Docker image, please refer to Docker build output for details.
[ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803156411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803469446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804011921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136342/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803977558
**[Test build #136342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136342/testReport)** for PR 31902 at commit [`02ba207`](https://github.com/apache/spark/commit/02ba207ccd0c9e89985cfbd4b9f61478e6487b46).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803463066
**[Test build #136288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136288/testReport)** for PR 31902 at commit [`30542f3`](https://github.com/apache/spark/commit/30542f345f739a63c67c876b4b87f7a0240f228e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31902: [SPARK-34803] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803114495
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803469446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598758005
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,12 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
Review comment:
Looks like we can't do that https://github.com/apache/spark/pull/31902/checks?check_run_id=2166094118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804190673
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804135656
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136350/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31902:
URL: https://github.com/apache/spark/pull/31902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804011921
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136342/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804105765
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40928/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803977558
**[Test build #136342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136342/testReport)** for PR 31902 at commit [`02ba207`](https://github.com/apache/spark/commit/02ba207ccd0c9e89985cfbd4b9f61478e6487b46).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803465650
**[Test build #136288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136288/testReport)** for PR 31902 at commit [`30542f3`](https://github.com/apache/spark/commit/30542f345f739a63c67c876b4b87f7a0240f228e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803151203
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40851/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803467475
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40870/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803154977
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40851/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] johnhany97 commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
johnhany97 commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598609881
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas "
+ "on importing the library." % minimum_pandas_version, raised_error)
Review comment:
Gotcha - addressed in 02ba207ccd0c9e89985cfbd4b9f61478e6487b46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804052703
**[Test build #136344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136344/testReport)** for PR 31902 at commit [`b21b67a`](https://github.com/apache/spark/commit/b21b67a187b59d5dae6e2eb7e93e53f06574a5c4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-803127142
**[Test build #136269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136269/testReport)** for PR 31902 at commit [`bf47b43`](https://github.com/apache/spark/commit/bf47b4316f7bc7c00cfc83a299712871446b6c67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31902:
URL: https://github.com/apache/spark/pull/31902#discussion_r598374978
##########
File path: python/pyspark/sql/pandas/utils.py
##########
@@ -26,11 +26,13 @@ def require_minimum_pandas_version():
try:
import pandas
have_pandas = True
- except ImportError:
+ except ImportError as error:
have_pandas = False
+ raised_error = error
if not have_pandas:
raise ImportError("Pandas >= %s must be installed; however, "
- "it was not found." % minimum_pandas_version)
+ "it was not found or an error was thrown by pandas "
+ "on importing the library." % minimum_pandas_version, raised_error)
Review comment:
This is just about improvement in exceptions that are usually not ported back in any event. I think it's fine just to land the fix it in master and branch-3.1 only (considering that this is a very safe fix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804098519
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40928/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804107242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804103076
**[Test build #136350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136350/testReport)** for PR 31902 at commit [`e63f4cf`](https://github.com/apache/spark/commit/e63f4cf19b2a2d433c4fe0096fd9ec63ad7b9cfa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31902: [SPARK-34803][PYSPARK] Pass the raised ImportError if pandas or pyarrow fail to import
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31902:
URL: https://github.com/apache/spark/pull/31902#issuecomment-804103076
**[Test build #136350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136350/testReport)** for PR 31902 at commit [`e63f4cf`](https://github.com/apache/spark/commit/e63f4cf19b2a2d433c4fe0096fd9ec63ad7b9cfa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org