You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2022/07/29 17:26:00 UTC
[jira] [Commented] (RATIS-1646) Fix suppressed Findbugs warnings
[ https://issues.apache.org/jira/browse/RATIS-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573080#comment-17573080 ]
Tsz-wo Sze commented on RATIS-1646:
-----------------------------------
Below are the results of searching "SuppressFBWarnings". Let's files subtasks for fixing them.
- ./ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamRequestByteBuffer.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
43: @SuppressFBWarnings("EI_EXPOSE_REP")
2 occurrence(s)
{code}
- ./ratis-common/src/main/java/org/apache/ratis/datastream/impl/DataStreamRequestFilePositionCount.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
52: @SuppressFBWarnings("EI_EXPOSE_REP")
2 occurrence(s)
{code}
- ./ratis-common/src/main/java/org/apache/ratis/io/MD5Hash.java --------------
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
56: @SuppressFBWarnings("EI_EXPOSE_REP2")
85: @SuppressFBWarnings("EI_EXPOSE_REP")
3 occurrence(s)
{code}
- ./ratis-common/src/main/java/org/apache/ratis/protocol/DataStreamRequestHeader.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
33: @SuppressFBWarnings("EI_EXPOSE_REP2")
41: @SuppressFBWarnings("EI_EXPOSE_REP")
3 occurrence(s)
{code}
- ./ratis-common/src/main/java/org/apache/ratis/util/PureJavaCrc32C.java -----
{code}
23: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
54: @SuppressFBWarnings("SF_SWITCH_NO_DEFAULT")
2 occurrence(s)
{code}
- ./ratis-common/src/main/java/org/apache/ratis/util/SlidingWindow.java ------
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
217: @SuppressFBWarnings("IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD")
2 occurrence(s)
{code}
- ./ratis-examples/src/main/java/org/apache/ratis/examples/counter/client/CounterClient.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
50: @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
2 occurrence(s)
{code}
- ./ratis-examples/src/main/java/org/apache/ratis/examples/filestore/cli/Client.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
146: @SuppressFBWarnings("DM_EXIT")
2 occurrence(s)
{code}
- ./ratis-grpc/src/main/java/org/apache/ratis/grpc/metrics/intercept/server/MetricServerCallListener.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
26: @SuppressFBWarnings("URF_UNREAD_FIELD")
2 occurrence(s)
{code}
- ./ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServerProtocolService.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
109: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
2 occurrence(s)
{code}
- ./ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
126: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
2 occurrence(s)
{code}
- ./ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamRequestByteBuf.java
{code}
21: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
40: @SuppressFBWarnings("EI_EXPOSE_REP2")
63: @SuppressFBWarnings("EI_EXPOSE_REP")
3 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/impl/PendingRequest.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
105: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/leader/InstallSnapshotRequests.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
85: @SuppressFBWarnings("IT_NO_SUCH_ELEMENT")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderDefault.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
46: @SuppressFBWarnings("RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegment.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
401: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegmentPath.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
61: @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS")
103: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
113: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
4 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogWorker.java
{code}
22: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
361: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
2 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/statemachine/impl/BaseStateMachine.java
{code}
22: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
135: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
198: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
3 occurrence(s)
{code}
- ./ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
77: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
142: @SuppressFBWarnings("NP_NULL_ON_SOME_PATH")
185: @SuppressFBWarnings("SE_COMPARATOR_SHOULD_BE_SERIALIZABLE")
4 occurrence(s)
{code}
- ./ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java
{code}
20: import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
84: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
95: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
110: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
121: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
133: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
261: @SuppressFBWarnings("NP_NULL_PARAM_DEREF")
7 occurrence(s)
{code}
Totally 55 occurrence(s) in 592 file(s).
> Fix suppressed Findbugs warnings
> --------------------------------
>
> Key: RATIS-1646
> URL: https://issues.apache.org/jira/browse/RATIS-1646
> Project: Ratis
> Issue Type: Bug
> Reporter: Tsz-wo Sze
> Priority: Major
>
> There are quite a few {{@SuppressFBWarnings}} tags in the code. We should fix the underlying problems or document the reason of the suppression.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)