You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ritchie46 (via GitHub)" <gi...@apache.org> on 2023/09/03 19:52:24 UTC

[GitHub] [arrow-rs] ritchie46 commented on issue #4764: [parquet]: feature gate functionality in parquet.

ritchie46 commented on issue #4764:
URL: https://github.com/apache/arrow-rs/issues/4764#issuecomment-1704387454

   > Really cool to see this happening.
   
   Gotta start somewhere. :)
   
   > It also has a tendency to result in poor test iteration times as different crates set different sets of features forcing recompilation.
   
   This should not hurt your test times as I will ensure the default features remain the same. This will only make it possible for end-users as polars to cherry pick some stuff. For testing we use `cargo hack` to test every feature gate (not all combinations). But I don't think it's needed here as I don't plan to mess with the defaults.
   
   > is there a particular crate that is showing up as a bottleneck during compilation?
   
   The compile times in polars are already way longer than we want. That's why I'd like to cherry pick on functionality. For the `parquet` crate I was looking add feature gating the IPC readers and `take` kernels out. Again this should not have any impact on the arrow-rs defaults/ repo and consumers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org