You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/02 15:15:02 UTC
[GitHub] [netbeans] Akshay-Gupta-Oracle opened a new pull request #2724: nbjavac15001
Akshay-Gupta-Oracle opened a new pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724
Updating nbjavac to version 15.0.0.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arvindaprameya commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
arvindaprameya commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773227009
> > Clearly the decision what goes into 12.3 belongs into the hands of release coordinators (e.g. @neilcsmith-net and @geertjanw) as the integration window has already been closed. E.g. let's simplify our options and let this PR target master branch.
>
> Thanks @JaroslavTulach but a few points here -
>
> * The point of the release process is to try and take this decision _out_ of the hands of release managers. On dev@ I suggested to @matthiasblaesing we either delay the integration window on this or it would have to wait unless it fixed a critical / blocking issue. nb-javac landing late in the process has caused problems and delays before, so we need to ensure adequate beta testing with it.
> * If this was just fixing NETBEANS-5109 there would be no issue IMO. It's conflating where nb-javac is distributed from with an nb-javac update that hasn't been in testing yet. I'm not sure if there is a list of changes in the update? To be considered for 12.3 we'd need to be able to assess what other issues are fixed and whether to roll further betas with emphasis on testing those things.
> * Leaving aside ASF and release issues, there are two big end user things to consider - the OSUOSL connection and delivery of prompt updates - as things are we rarely deliver nb-javac updates (I think I RM'd the only one so far), and the update process is confusing for ends users due to multiple cycles.
> * Assuming binary compatibility(?) my entire reason for pushing for an NBM on the Oracle side of this is that I think it would be nice to look at pushing fixes to users of 12.3 if needed within weeks, rather than having to wait until 12.4.
Some of the changes that have been made in the nb-javac 15.0.0.1 release is:
• Moving the code into githib away from Oracle and OSSOUL Infrastructure
• Bug fix, usage of “permits” as variable throws error ; https://issues.apache.org/jira/browse/NETBEANS-5055
• Build and readme related changes so as to enable uploading of nb-javac jar's on Maven central
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-778034469
The PR is merged and I've built and uploaded the bits to a staging repository in case you want to test before I release them to Maven Central:
https://oss.sonatype.org/content/repositories/comdukescript-1138/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774005042
@Akshay-Gupta-Oracle please check the binaries list format - should be the Maven coordinates I think.
If we're definitely targetting this to 12.3, given NETBEANS-5055, once the tests are passing here I'd suggest a new PR with a single commit and base of delivery branch. And if so, it'll get to master via that route, and this can be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776872232
My 2¢: NETBEANS-5109 is IMHO not a reason to delay the release. For NETBEANS-5055 is ugly, but the work around to switch to the system JDK exists, but it would be more worth a fix. @Akshay-Gupta-Oracle can you say when you will be able to have a look at @JaroslavTulach PR against nb-javac?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-778688063
This PR is superseded by #2758 and/or #2759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773404049
The 15.0.0.1 version is available at: https://oss.sonatype.org/content/repositories/comdukescript-1137/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-772366450
> Clearly the decision what goes into 12.3 belongs into the hands of release coordinators (e.g. @neilcsmith-net and @geertjanw) as the integration window has already been closed. E.g. let's simplify our options and let this PR target master branch.
Thanks @JaroslavTulach but a few points here -
- The point of the release process is to try and take this decision _out_ of the hands of release managers. On dev@ I suggested to @matthiasblaesing we either delay the integration window on this or it would have to wait unless it fixed a critical / blocking issue. nb-javac landing late in the process has caused problems and delays before, so we need to ensure adequate beta testing with it.
- If this was just fixing NETBEANS-5109 there would be no issue IMO. It's conflating where nb-javac is distributed from with an nb-javac update that hasn't been in testing yet. I'm not sure if there is a list of changes in the update? To be considered for 12.3 we'd need to be able to assess what other issues are fixed and whether to roll further betas with emphasis on testing those things.
- Leaving aside ASF and release issues, there are two big end user things to consider - the OSUOSL connection and delivery of prompt updates - as things are we rarely deliver nb-javac updates (I think I RM'd the only one so far), and the update process is confusing for ends users due to multiple cycles.
- Assuming binary compatibility(?) my entire reason for pushing for an NBM on the Oracle side of this is that I think it would be nice to look at pushing fixes to users of 12.3 if needed within weeks, rather than having to wait until 12.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#discussion_r568703685
##########
File path: nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
##########
@@ -1,6 +1,5 @@
-CRC:2157920864
-SIZE:252431
-URL:https://netbeans.osuosl.org/binaries/267AFC87A08301145B10D86DA674724B884F010C-nb-javac-15-api.jar
-URL:https://hg.netbeans.org/binaries/267AFC87A08301145B10D86DA674724B884F010C-nb-javac-15-api.jar
-MessageDigest: SHA-256 0a5e9b6afbdb86deb3286f37e1dee230c91f39438e55dc77910c9a48f38a2ffb
-MessageDigest: SHA-512 5b16a0c6466dc14cf2d428d4a84398f9de2d1782acf445c8da5ca874f807ac550db8b551ec41495963a29c2f400ca24ee8a70b1d589d0cdf2f05af5cb0f4ff56
\ No newline at end of file
+CRC:2454529625
+SIZE:3700020
+URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
Review comment:
Let's use the `m2:` "Maven URLs" here too. Please find an example of such approach in our [Java FX libraries integration](https://github.com/apache/netbeans/blob/master/extra/libs.javafx.linux/external/javafx-media-13-linux.jar.external#L2).
##########
File path: java/libs.javacapi/external/binaries-list
##########
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-267AFC87A08301145B10D86DA674724B884F010C nb-javac-15-api.jar
\ No newline at end of file
+A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
Review comment:
It would be better if @eppleton can upload these JARs to Maven central. Then we can use Maven co-ordinates and SHA1 content just as we do with [HTML/Java JARs](https://github.com/apache/netbeans/blob/master/platform/net.java.html.boot.fx/external/binaries-list#L17).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-772201568
Thank you @neilcsmith-net and @matthiasblaesing for summarizing your opinions here (I have noticed your discussions elsewhere, but I wasn't sure what still applies and what not).
Clearly the decision what goes into 12.3 belongs into the hands of release coordinators (e.g. @neilcsmith-net and @geertjanw) as the integration window has already been closed. E.g. let's simplify our options and let this PR target `master` branch.
There are many aspects of [NETBEANS-5109](https://issues.apache.org/jira/browse/NETBEANS-5109), but the most visible for end-users is: The current nbjavac external URL pointing to https://netbeans.osuosl.org/binaries isn't fully reliable (there were moments, when the server was down). Let's simplify our discussions and focus on fixing this one first, please!
Assuming Toni Epple publishes the bits of nbjavac 15.0.0.1 on Maven central, then let this PR just update the URLs to these new bits. That may be just a small step forward (from Neil's perspective), however it is a step forward towards the right direction (I am deliberately not saying _goal_, as I don't think there is a mutual agreement what the goal should be). It wouldn't be fair to let end-users suffer by not making the small step (which is actually a giant leap from the nbjavac distribution perspective).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774231385
> @JaroslavTulach @eppleton looks like nb-javac-15.0.0.1-impl.jar is not present at https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar. If the file nb-javac-15.0.0.1.jar is impl jar please change the name of jar to add -impl at the end.
@Akshay-Gupta-Oracle this won't work. Sonatype requires for artifacts distributed via OSSRH to contain at least one primary artifact, which has to be named with a type suffix.
The modifications to the nbjavac build create two jars:
- `nb-javac-15.0.0.1.jar` is the old "-impl"
- `nb-javac-15.0.0.1-api.jar is and was the "-api" package
It was done this way, so that the two artifacts can be published together.
I had a look at this PR yesterday and here you can see how I tackled it (feel free to pull if you agree):
https://github.com/matthiasblaesing/netbeans/commit/277e1583ae29fa493a15ccb894da5ae1415833ea
Changes in the referenced commit:
- moved dependencies to maven central download
- updated `nbbuild/templates/projectized.xml` to reference the correct artifact
- fixed naming of `nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15.0.0.1-api.jar.external` and ` nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external` (this is an independent problem from the maven central move, just a bugfix for the original PR) and moved to the maven central dependency
- fixed for `binary-origin` in `java/libs.javacimpl/nbproject/project.xml ` (this is an independent problem from the maven central move, just a bugfix for the original PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774005042
@Akshay-Gupta-Oracle please check the binaries list format - should be the Maven coordinates I think.
If we're definitely targetting this to 12.3, given NETBEANS-5055, once the tests are passing here I'd suggest a new PR with a single commit and base of delivery branch. And if so, it'll get to master via that route, and this can be closed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773777737
Thanks Toni for publishing nb-javac. The following diff shows how I would download your bits during build (tested) and runtime (not tested):
```
diff --git a/java/libs.javacapi/external/binaries-list b/java/libs.javacapi/external/binaries-list
index 36b5b9bc28dc..8e38bdb5b740 100644
--- a/java/libs.javacapi/external/binaries-list
+++ b/java/libs.javacapi/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
\ No newline at end of file
+BFD705684E0BAD86038EAF01D33FCF7EF5D5DFB3 com.dukescript.nbjavac:nb-javac:15.0.0.1:api
diff --git a/java/libs.javacimpl/external/binaries-list b/java/libs.javacimpl/external/binaries-list
index 1e15481e7e99..107cc9a9a0d6 100644
--- a/java/libs.javacimpl/external/binaries-list
+++ b/java/libs.javacimpl/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-0788681E011A58CE17E5583718F4919A nb-javac-15.0.0.1-impl.jar
\ No newline at end of file
+CBCB2F5C1CB99B672E6217BE853ABB2A0939AA72 com.dukescript.nbjavac:nb-javac:15.0.0.1
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
index 7d81e6c5959b..991d4db992e7 100644
--- a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
+++ b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
@@ -1,5 +1,5 @@
CRC:2454529625
SIZE:3700020
-URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar:api
MessageDigest: SHA-256 f8b6a5e66e219eaa37e771f3f4dacd2a312ea1f94e8d94e48f36f7208e8fc655
MessageDigest: SHA-512 8c15a663def325f19a6810d929148e7b315bf61dad32433515c9aebcec952eb0916c4383a9745e3af93b3011306d43e3214318120299a78e3b847c18f26f3873
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
index bcb929a4d315..cf85eb2011db 100644
--- a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
+++ b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
@@ -1,5 +1,5 @@
CRC:1887704140
SIZE:246374
-URL:https://github.com/oracle/nb-javac/releases/download/release130/A152261F8D708A5E1A7FCDAA3981663E-nb-javac-15.0.0.1-api.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar
MessageDigest: SHA-256 c1fbbbcb30e283a6477248bf4adf202188d55c2e7ef9aa29d343018a68571794
MessageDigest: SHA-512 bc9ac9f68b21190e2d4231908ce0aa7d88c3f054c8ac226a13fd6b7fd05d63eebc59308c5a7f6df5518f9b8b01f85fd18334ce115b54e2b4994aec2253c33040
\ No newline at end of file
```
the name of the "impl" JAR changed to `nb-javac-15.0.0.1.jar` - e.g. it will be necessary to adjust other files in its module. I leave that and testing to Akshay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771760691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773404049
The 15.0.0.1 version is available at: https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773777737
Thanks Toni for publishing nb-javac. The following diff shows how I would download your bits during build (tested) and runtime (not tested):
```
diff --git a/java/libs.javacapi/external/binaries-list b/java/libs.javacapi/external/binaries-list
index 36b5b9bc28dc..8e38bdb5b740 100644
--- a/java/libs.javacapi/external/binaries-list
+++ b/java/libs.javacapi/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
\ No newline at end of file
+BFD705684E0BAD86038EAF01D33FCF7EF5D5DFB3 com.dukescript.nbjavac:nb-javac:15.0.0.1:api
diff --git a/java/libs.javacimpl/external/binaries-list b/java/libs.javacimpl/external/binaries-list
index 1e15481e7e99..107cc9a9a0d6 100644
--- a/java/libs.javacimpl/external/binaries-list
+++ b/java/libs.javacimpl/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-0788681E011A58CE17E5583718F4919A nb-javac-15.0.0.1-impl.jar
\ No newline at end of file
+CBCB2F5C1CB99B672E6217BE853ABB2A0939AA72 com.dukescript.nbjavac:nb-javac:15.0.0.1
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
index 7d81e6c5959b..991d4db992e7 100644
--- a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
+++ b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
@@ -1,5 +1,5 @@
CRC:2454529625
SIZE:3700020
-URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar
MessageDigest: SHA-256 f8b6a5e66e219eaa37e771f3f4dacd2a312ea1f94e8d94e48f36f7208e8fc655
MessageDigest: SHA-512 8c15a663def325f19a6810d929148e7b315bf61dad32433515c9aebcec952eb0916c4383a9745e3af93b3011306d43e3214318120299a78e3b847c18f26f3873
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
index bcb929a4d315..cf85eb2011db 100644
--- a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
+++ b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
@@ -1,5 +1,5 @@
CRC:1887704140
SIZE:246374
-URL:https://github.com/oracle/nb-javac/releases/download/release130/A152261F8D708A5E1A7FCDAA3981663E-nb-javac-15.0.0.1-api.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar:api
MessageDigest: SHA-256 c1fbbbcb30e283a6477248bf4adf202188d55c2e7ef9aa29d343018a68571794
MessageDigest: SHA-512 bc9ac9f68b21190e2d4231908ce0aa7d88c3f054c8ac226a13fd6b7fd05d63eebc59308c5a7f6df5518f9b8b01f85fd18334ce115b54e2b4994aec2253c33040
\ No newline at end of file
```
the name of the "impl" JAR changed to `nb-javac-15.0.0.1.jar` - e.g. it will be necessary to adjust other files in its module. I leave that and testing to Akshay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#discussion_r568703685
##########
File path: nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
##########
@@ -1,6 +1,5 @@
-CRC:2157920864
-SIZE:252431
-URL:https://netbeans.osuosl.org/binaries/267AFC87A08301145B10D86DA674724B884F010C-nb-javac-15-api.jar
-URL:https://hg.netbeans.org/binaries/267AFC87A08301145B10D86DA674724B884F010C-nb-javac-15-api.jar
-MessageDigest: SHA-256 0a5e9b6afbdb86deb3286f37e1dee230c91f39438e55dc77910c9a48f38a2ffb
-MessageDigest: SHA-512 5b16a0c6466dc14cf2d428d4a84398f9de2d1782acf445c8da5ca874f807ac550db8b551ec41495963a29c2f400ca24ee8a70b1d589d0cdf2f05af5cb0f4ff56
\ No newline at end of file
+CRC:2454529625
+SIZE:3700020
+URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
Review comment:
Let's use the `m2:` "Maven URLs" here too. Please find an example of such approach in our [Java FX libraries integration](https://github.com/apache/netbeans/blob/master/extra/libs.javafx.linux/external/javafx-media-13-linux.jar.external#L2).
##########
File path: java/libs.javacapi/external/binaries-list
##########
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-267AFC87A08301145B10D86DA674724B884F010C nb-javac-15-api.jar
\ No newline at end of file
+A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
Review comment:
It would be better if @eppleton can upload these JARs to Maven central. Then we can use Maven co-ordinates and SHA1 content just as we do with [HTML/Java JARs](https://github.com/apache/netbeans/blob/master/platform/net.java.html.boot.fx/external/binaries-list#L17).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771760691
@JaroslavTulach as discussed elsewhere, the update for nb-javac is intended for 12.4.
I would really like to see us publish the NBM's via Maven if at all possible. That would allow us to move away from the third-party UC and be able to push updates of nb-javac independently of IDE releases (and also allow for the Oracle team to have an opt-in UC for testing new versions).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776517168
I made a terrible mistake - the `nbjavac@15.0.0.1` cannot be executed on JDK8 (which is it's primary purpose). No surprise the gates are failing.
I am organizing an update https://github.com/oracle/nb-javac/pull/9, but I don't have any time estimate. Depends when @Akshay-Gupta-Oracle accepts the pull request. When @eppleton handles the upload. When the gates pass without errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-775356396
Can @geertjanw and I get a confirmation whether we are targeting this for 12.3 now, and if so a rough ETA? We need to roll another (hopefully final) beta, ideally mid-week if this is ready.
Incidentally, if not, we could also discuss pushing an NBM update of this to 12.3 via hosting elsewhere (eg. GitHub) - realise why we want JARs on Maven, but updates are somewhat more transient than builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776850450
> Whether to include the (Maven) based nbjavac in release 12.3 or not is a decision fully in hands of release coordinators.
@JaroslavTulach that decision is never fully in the hands of release coordinators, and never should be! It was a call for input, from anyone - we don't want to proceed with all the workload of a voting candidate if people are inclined to -1 the release. Now, while personally, I don't think NETBEANS-5109 is enough of a concern to hold things up, I'm slightly more inclined to think fixing NETBEANS-5055 might be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771938281
@neilcsmith-net ok, I'll step away from this then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773777737
Thanks Toni for publishing nb-javac. The following diff shows how I would download your bits during build (tested) and runtime (not tested):
```
diff --git a/java/libs.javacapi/external/binaries-list b/java/libs.javacapi/external/binaries-list
index 36b5b9bc28dc..8e38bdb5b740 100644
--- a/java/libs.javacapi/external/binaries-list
+++ b/java/libs.javacapi/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
\ No newline at end of file
+BFD705684E0BAD86038EAF01D33FCF7EF5D5DFB3 com.dukescript.nbjavac:nb-javac:15.0.0.1:api
diff --git a/java/libs.javacimpl/external/binaries-list b/java/libs.javacimpl/external/binaries-list
index 1e15481e7e99..107cc9a9a0d6 100644
--- a/java/libs.javacimpl/external/binaries-list
+++ b/java/libs.javacimpl/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-0788681E011A58CE17E5583718F4919A nb-javac-15.0.0.1-impl.jar
\ No newline at end of file
+CBCB2F5C1CB99B672E6217BE853ABB2A0939AA72 com.dukescript.nbjavac:nb-javac:15.0.0.1
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
index 7d81e6c5959b..991d4db992e7 100644
--- a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
+++ b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
@@ -1,5 +1,5 @@
CRC:2454529625
SIZE:3700020
-URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar:api
MessageDigest: SHA-256 f8b6a5e66e219eaa37e771f3f4dacd2a312ea1f94e8d94e48f36f7208e8fc655
MessageDigest: SHA-512 8c15a663def325f19a6810d929148e7b315bf61dad32433515c9aebcec952eb0916c4383a9745e3af93b3011306d43e3214318120299a78e3b847c18f26f3873
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
index bcb929a4d315..cf85eb2011db 100644
--- a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
+++ b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
@@ -1,5 +1,5 @@
CRC:1887704140
SIZE:246374
-URL:https://github.com/oracle/nb-javac/releases/download/release130/A152261F8D708A5E1A7FCDAA3981663E-nb-javac-15.0.0.1-api.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar
MessageDigest: SHA-256 c1fbbbcb30e283a6477248bf4adf202188d55c2e7ef9aa29d343018a68571794
MessageDigest: SHA-512 bc9ac9f68b21190e2d4231908ce0aa7d88c3f054c8ac226a13fd6b7fd05d63eebc59308c5a7f6df5518f9b8b01f85fd18334ce115b54e2b4994aec2253c33040
\ No newline at end of file
```
the name of the "impl" JAR changed to `nb-javac-15.0.0.1.jar` - e.g. it will be necessary to adjust other files in its module. I leave that and testing to Akshay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773251441
Thanks @arvindaprameya Assuming the only functional fix is for NETBEANS-5055, and the possibility of regressions is low, then whether we target this for 12.3 or 12.4 comes down to assessing how important it is to get that fix in place. We'll need to then roll another beta and push back release enough to allow testing. If we go ahead with that, we need to look at the Maven distribution too and (partially!) solve [NETBEANS-5109] in the process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776839576
> So, do we proceed with 12.3 release as is, or do NETBEANS-5055 and NETBEANS-5109 warrant ... few more days?
Whether to include the (Maven) based `nbjavac` in release 12.3 or not is a decision fully in hands of release coordinators. I have no control over actions needed to be done by others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776829343
Thanks @JaroslavTulach very glad that got picked up! Need to look at that Travis setup - be good to be able to fully rely on and not be merging anything without a green tick. And nice fix.
So, do we proceed with 12.3 release as is, or do NETBEANS-5055 and NETBEANS-5109 warrant pushing back a few more days?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771936902
@matthiasblaesing I want a working solution that decouples the schedules so we don't keep trying to push changes in at the last minute, past freeze! As illustrated here again.
We need JARs for build, and an NBM for user distribution, which is what we used to do. NBM isn't difficult to put together, UC is easy - for now we already manually edit the XML of the main IDE one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773777737
Thanks Toni for publishing nb-javac. The following diff shows how I would download your bits during build (tested) and runtime (not tested):
```
diff --git a/java/libs.javacapi/external/binaries-list b/java/libs.javacapi/external/binaries-list
index 36b5b9bc28dc..8e38bdb5b740 100644
--- a/java/libs.javacapi/external/binaries-list
+++ b/java/libs.javacapi/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-A152261F8D708A5E1A7FCDAA3981663E nb-javac-15.0.0.1-api.jar
\ No newline at end of file
+BFD705684E0BAD86038EAF01D33FCF7EF5D5DFB3 com.dukescript.nbjavac:nb-javac:15.0.0.1:api
diff --git a/java/libs.javacimpl/external/binaries-list b/java/libs.javacimpl/external/binaries-list
index 1e15481e7e99..107cc9a9a0d6 100644
--- a/java/libs.javacimpl/external/binaries-list
+++ b/java/libs.javacimpl/external/binaries-list
@@ -14,4 +14,4 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-0788681E011A58CE17E5583718F4919A nb-javac-15.0.0.1-impl.jar
\ No newline at end of file
+CBCB2F5C1CB99B672E6217BE853ABB2A0939AA72 com.dukescript.nbjavac:nb-javac:15.0.0.1
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
index 7d81e6c5959b..991d4db992e7 100644
--- a/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
+++ b/nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external
@@ -1,5 +1,5 @@
CRC:2454529625
SIZE:3700020
-URL:https://github.com/oracle/nb-javac/releases/download/release130/0788681E011A58CE17E5583718F4919A-nb-javac-15.0.0.1-impl.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar
MessageDigest: SHA-256 f8b6a5e66e219eaa37e771f3f4dacd2a312ea1f94e8d94e48f36f7208e8fc655
MessageDigest: SHA-512 8c15a663def325f19a6810d929148e7b315bf61dad32433515c9aebcec952eb0916c4383a9745e3af93b3011306d43e3214318120299a78e3b847c18f26f3873
\ No newline at end of file
diff --git a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
index bcb929a4d315..cf85eb2011db 100644
--- a/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
+++ b/nb/updatecenters/extras/nbjavac.impl/release/modules/ext/nb-javac-15-impl.jar.external
@@ -1,5 +1,5 @@
CRC:1887704140
SIZE:246374
-URL:https://github.com/oracle/nb-javac/releases/download/release130/A152261F8D708A5E1A7FCDAA3981663E-nb-javac-15.0.0.1-api.jar
+URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.1:jar:api
MessageDigest: SHA-256 c1fbbbcb30e283a6477248bf4adf202188d55c2e7ef9aa29d343018a68571794
MessageDigest: SHA-512 bc9ac9f68b21190e2d4231908ce0aa7d88c3f054c8ac226a13fd6b7fd05d63eebc59308c5a7f6df5518f9b8b01f85fd18334ce115b54e2b4994aec2253c33040
\ No newline at end of file
```
the name of the "impl" JAR changed to `nb-javac-15.0.0.1.jar` - e.g. it will be necessary to adjust other files in its module. I leave that and testing to Akshay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771924171
@neilcsmith-net I'm willing to update the build process to use external jars from maven central, building nbms or setting up an update center is a different ball park. So it comes down to the question. do we want the perfect solution, that won't be implemented, or do we at least take the less perfect one, where someone will step up and fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-777490697
The only fix that is part of this has been broken since 12.2, that the keyword "permits" cannot be used (https://issues.apache.org/jira/browse/NETBEANS-5055), so if we don't include this in 12.3, we will be in the same position as 12.2, @neilcsmith-net and I as release managers have now decided this: if by end of Monday EOB this issue is not resolved completely, we're going to go ahead with Beta-3, which will be the release candidate, without this fix, which will then be (hopefully) part of 12.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773251441
Thanks @arvindaprameya Assuming the only functional fix is for NETBEANS-5055, and the possibility of regressions is low, then whether we target this for 12.3 or 12.4 comes down to assessing how important it is to get that fix in place. We'll need to then roll another beta and push back release enough to allow testing. If we go ahead with that, we need to look at the Maven distribution too and (partially!) solve [NETBEANS-5109] in the process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-776517168
I made a terrible mistake - the `nbjavac@15.0.0.1` cannot be executed on JDK8 (which is it's primary purpose). No surprise the gates are failing.
I am organizing an update https://github.com/oracle/nb-javac/pull/9, but I don't have any time estimates. Depends when @Akshay-Gupta-Oracle accepts the pull request. When @eppleton handles to upload. When the gates pass without errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2724: nbjavac15001
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-771924171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774231385
> @JaroslavTulach @eppleton looks like nb-javac-15.0.0.1-impl.jar is not present at https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar. If the file nb-javac-15.0.0.1.jar is impl jar please change the name of jar to add -impl at the end.
@Akshay-Gupta-Oracle this won't work. Sonatype requires for artifacts distributed via OSSRH to contain at least one primary artifact, which has to be named with a type suffix.
The modifications to the nbjavac build create two jars:
- `nb-javac-15.0.0.1.jar` is the old "-impl"
- `nb-javac-15.0.0.1-api.jar` is and was the "-api" package
It was done this way, so that the two artifacts can be published together.
I had a look at this PR yesterday and here you can see how I tackled it (feel free to pull if you agree):
https://github.com/matthiasblaesing/netbeans/commit/277e1583ae29fa493a15ccb894da5ae1415833ea
Changes in the referenced commit:
- moved dependencies to maven central download
- updated `nbbuild/templates/projectized.xml` to reference the correct artifact
- fixed naming of `nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15.0.0.1-api.jar.external` and ` nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external` (this is an independent problem from the maven central move, just a bugfix for the original PR) and moved to the maven central dependency
- fixed for `binary-origin` in `java/libs.javacimpl/nbproject/project.xml ` (this is an independent problem from the maven central move, just a bugfix for the original PR)
PS: @eppleton thank you for the quick upload!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-778034469
The PR against nb-javac is merged and I've built and uploaded the bits to a staging repository in case you want to test before I release them to Maven Central:
https://oss.sonatype.org/content/repositories/comdukescript-1138/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773404049
The 15.0.0.1 version is available at: https://oss.sonatype.org/content/repositories/comdukescript-1137/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eppleton edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
eppleton edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773404049
The 15.0.0.1 version is available at: https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
matthiasblaesing edited a comment on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774231385
> @JaroslavTulach @eppleton looks like nb-javac-15.0.0.1-impl.jar is not present at https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar. If the file nb-javac-15.0.0.1.jar is impl jar please change the name of jar to add -impl at the end.
@Akshay-Gupta-Oracle this won't work. Sonatype requires for artifacts distributed via OSSRH to contain at least one primary artifact, which has to be named with a type suffix.
The modifications to the nbjavac build create two jars:
- `nb-javac-15.0.0.1.jar` is the old "-impl"
- `nb-javac-15.0.0.1-api.jar` is and was the "-api" package
It was done this way, so that the two artifacts can be published together.
I had a look at this PR yesterday and here you can see how I tackled it (feel free to pull if you agree):
https://github.com/matthiasblaesing/netbeans/commit/277e1583ae29fa493a15ccb894da5ae1415833ea
Changes in the referenced commit:
- moved dependencies to maven central download
- updated `nbbuild/templates/projectized.xml` to reference the correct artifact
- fixed naming of `nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15.0.0.1-api.jar.external` and ` nb/updatecenters/extras/nbjavac.api/release/modules/ext/nb-javac-15-api.jar.external` (this is an independent problem from the maven central move, just a bugfix for the original PR) and moved to the maven central dependency
- fixed for `binary-origin` in `java/libs.javacimpl/nbproject/project.xml ` (this is an independent problem from the maven central move, just a bugfix for the original PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Akshay-Gupta-Oracle commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
Akshay-Gupta-Oracle commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-774073376
@JaroslavTulach @eppleton looks like nb-javac-15.0.0.1-impl.jar is not present at https://search.maven.org/artifact/com.dukescript.nbjavac/nb-javac/15.0.0.1/jar. If the file nb-javac-15.0.0.1.jar is impl jar please change the name of jar to add -impl at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] arvindaprameya commented on pull request #2724: [NETBEANS-5109] Update to (Maven distributed) nbjavac15.0.0.1
Posted by GitBox <gi...@apache.org>.
arvindaprameya commented on pull request #2724:
URL: https://github.com/apache/netbeans/pull/2724#issuecomment-773227009
> > Clearly the decision what goes into 12.3 belongs into the hands of release coordinators (e.g. @neilcsmith-net and @geertjanw) as the integration window has already been closed. E.g. let's simplify our options and let this PR target master branch.
>
> Thanks @JaroslavTulach but a few points here -
>
> * The point of the release process is to try and take this decision _out_ of the hands of release managers. On dev@ I suggested to @matthiasblaesing we either delay the integration window on this or it would have to wait unless it fixed a critical / blocking issue. nb-javac landing late in the process has caused problems and delays before, so we need to ensure adequate beta testing with it.
> * If this was just fixing NETBEANS-5109 there would be no issue IMO. It's conflating where nb-javac is distributed from with an nb-javac update that hasn't been in testing yet. I'm not sure if there is a list of changes in the update? To be considered for 12.3 we'd need to be able to assess what other issues are fixed and whether to roll further betas with emphasis on testing those things.
> * Leaving aside ASF and release issues, there are two big end user things to consider - the OSUOSL connection and delivery of prompt updates - as things are we rarely deliver nb-javac updates (I think I RM'd the only one so far), and the update process is confusing for ends users due to multiple cycles.
> * Assuming binary compatibility(?) my entire reason for pushing for an NBM on the Oracle side of this is that I think it would be nice to look at pushing fixes to users of 12.3 if needed within weeks, rather than having to wait until 12.4.
Some of the changes that have been made in the nb-javac 15.0.0.1 release is:
• Moving the code into githib away from Oracle and OSSOUL Infrastructure
• Bug fix, usage of “permits” as variable throws error ; https://issues.apache.org/jira/browse/NETBEANS-5055
• Build and readme related changes so as to enable uploading of nb-javac jar's on Maven central
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists