You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/25 09:45:09 UTC

[GitHub] [pulsar] HQebupt commented on a diff in pull request #17803: [fix][common] make managedLedgerOffloadedReadPriority compatible with broker property

HQebupt commented on code in PR #17803:
URL: https://github.com/apache/pulsar/pull/17803#discussion_r979382676


##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java:
##########
@@ -256,9 +257,9 @@ public void compatibleWithBrokerConfigFile(Properties properties) {
                     Long.parseLong(properties.getProperty(DELETION_LAG_NAME_IN_CONF_FILE)));
         }
 
-        if (properties.containsKey("managedLedgerDataReadPriority")) {
+        if (properties.containsKey(DATA_READ_PRIORITY_NAME_IN_CONF_FILE)) {
             setManagedLedgerOffloadedReadPriority(

Review Comment:
   This is better.
   ```
   if (!properties.containsKey("managedLedgerOffloadedReadPriority")
                   && properties.containsKey("DATA_READ_PRIORITY_NAME_IN_CONF_FILE")) {
               setManagedLedgerOffloadedReadPriority(
                       OffloadedReadPriority.fromString(properties.getProperty("DATA_READ_PRIORITY_NAME_IN_CONF_FILE")));
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org