You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/25 07:53:30 UTC

[GitHub] [flink] matriv commented on pull request #17550: [FLINK-24599][table] Replace static methods with member methods

matriv commented on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-950626529


   > Does it makes sense for you to push `is(LogicalTypeFamily)` method inside `LogicalTypeRoot` and then have it `LogicalType` as well?
   
   The point of the ticket and PR is to move those methods as member methods and have them on the LogicalType which is always what we have at hand, and want to check to which LogicalTypeRoot or LogicalTypeFamily it belongs to. If we move the method inside LogicalTypeFamily then we'd have calls like: `LogicalTypeFamily.NUMERIC.is(myType)` which IMHO is slightly more weird than the inverse, considering also that `LogicalTypeFamily` is an enum and not a class.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org