You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Biestro (JIRA)" <ji...@apache.org> on 2009/08/14 19:19:14 UTC
[jira] Created: (JEXL-85) 2.0 grammar finishing touches
2.0 grammar finishing touches
-----------------------------
Key: JEXL-85
URL: https://issues.apache.org/jira/browse/JEXL-85
Project: Commons JEXL
Issue Type: Improvement
Reporter: Henri Biestro
Fix For: 2.0
The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
There are a few places where the LOOKAHEAD can be reduced or more explicit.
Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:11 AM:
------------------------------------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312&view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Assignee: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Got rid of the ';' at end of statements - allows to write blocks without an inner ';' like:
{a; b}
Commented / refactored the grammar
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745163#action_12745163 ]
Sebb commented on JEXL-85:
--------------------------
I'm not sure about the way the trailing ';' has been eliminated in the grammar. It's difficult to see where ';' is required.
In fact I think there's a problem, as the following is allowed:
while (false) while (false)
I think it should insist on a ';' between the statements.
It's also really difficult to follow the grammar changes as some of the sections seem to have been re-ordered.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: (was: JEXL-85.patch)
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro edited comment on JEXL-85 at 8/29/09 10:35 AM:
-------------------------------------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Re-added statement requirement for 'for','while', 'if/else' ( the 'while(false) while(false)' case ) since this was indeed too lax. (EmptyStatement aka ';' is sufficient).
Added Java Unicode escape sequence in parse (through StringParser).
Removed the difference between Script & Expression (svn del ScriptImpl.java); can't see any need for the functional difference - it could only generate warnings - and the only parsing entry point was anyway generating ASTJexlScript.
Kept the Script interface as a convenience allowing to import another package Expression.
As for the grammar reordering, although I understand the inconvenience this creates to review the changes, it radically improves reading / following / maintaining the grammar Statement are now logically grouped instead of being spread accross the file.
(Having spent quite a few hours on it, this makes a huge difference)
All tests pass, no regressions.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745154#action_12745154 ]
Sebb commented on JEXL-85:
--------------------------
Elimination of ';' at the end of a statement is good. If I undestand correctly, this changes:
if (cond) 1; else 2;
to
if (cond) 1 else 2
which seems more logical.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:35 AM:
------------------------------------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312&view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809316&view=rev
Log:
Refactored BitwiseOperator to use asserter.
Removed main methods from tests (use JexlTestCase instead).
Added parenthesized expression tests & further Debugger checking.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/ArithmeticTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BitwiseOperatorTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BlockTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312&view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Assignee: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743504#action_12743504 ]
Henri Biestro edited comment on JEXL-85 at 8/14/09 5:42 PM:
------------------------------------------------------------
Fixing JEXL-86 is dependant upon grammar which changes in JEXL-85.
was (Author: henrib):
Fix is dependant upon grammar which changes in JEXL-85.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745419#action_12745419 ]
Sebb commented on JEXL-85:
--------------------------
Currently the behaviour of a multi-statement Expression is that a warning is logged, and the FIRST statement is taken as the value.
The patch changes the behaviour so that there is no warning, and the LAST statement is taken as the value.
I don't know which is more sensible going forward, nor do I mind which approach is taken, but it seems to me that the change needs to be agreed.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Reverted Script & Expression javadoc
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Added fix for debugger not adding ';' at end of statements that needed it.
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro resolved JEXL-85.
-------------------------------
Resolution: Fixed
Per previous commits.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Assignee: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro commented on JEXL-85:
-----------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
Debugger.java: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
JexlEngine.java: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Description:
The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
There are a few places where the LOOKAHEAD can be reduced or more explicit.
Some expressions (Reference) are really hard to read partly due to formatting.
The Debugger is also out of sync with the latest grammar updates (Map literals, for).
was:
The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
There are a few places where the LOOKAHEAD can be reduced or more explicit.
Some expressions (Reference) are really hard to read partly due to formatting.
Summary: 2.0 grammar finishing touches & debugger update (was: 2.0 grammar finishing touches)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745389#action_12745389 ]
Sebb commented on JEXL-85:
--------------------------
Sorry, but I think there are far too many changes in the patch.
It's really difficult to follow the patch, and it will be difficult to follow the SVN history.
I think the patch needs to be broken down into more manageable chunks.
Also, there needs to be a vote on whether it makes sense to change the behaviour of an Expression so that it behaves like a Script.
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743374#action_12743374 ]
Sebb commented on JEXL-85:
--------------------------
There are two instances of the following change in JexlEngine:
- JexlNode node = tree.jjtGetChild(0).jjtGetChild(0);
+ JexlNode node = tree.jjtGetChild(0);
Not sure how that relates to the Parser changes mentioned in the Description.
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Reverted Script / Expression behavior (stll with removal of ScriptImpl; ExpressionImpl does extends both Expression and Script).
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745413#action_12745413 ]
Henri Biestro commented on JEXL-85:
-----------------------------------
I'm still surprised when contributing ends up being such an unpleasant & dry experience...
The only thing that makes an Expression not behave like a Script is a warning; do you have any functional need for this warning yourself ?
Besides, knowing this wont change anything, creating 5 patches versus 5 commits is very different in time consumption; it will ultimately allow the same level of change tracking and all of them relate to changes in the grammar.
*StringParser.java* : allow Unicode escape sequence \uxxxx .
*Parser.jjt / Interpreter.java* : changes statement to avoid the need for ';' at end - make grammar readable .
*Debugger.java* : reflect changes in grammar for statements .
**Test.java* : test Debugger, verify it can roundtrip all expressions in tests .
*Expression.java, ExpressionImpl.java* change, *ScriptImpl.java* removal : simplify code, remove dubious warning .
Thanks so much for your help and trust...
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: (was: JEXL-85.patch)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches &
debugger update
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745720#action_12745720 ]
Rahul Akolkar commented on JEXL-85:
-----------------------------------
Given the size of this patch and an upcoming vacation, I won't be able to look at this for a couple of weeks atleast. Hopefully someone will get here sooner. I agree with sebb that whoever examines and applies the patch -- could be you, Henri, once your account is set up -- should apply it in multiple commits. Ideally, one commit for each functional change (but given where we are, as close as possible). Also, any non-functional changes such as moving grammar statements to match some logical grouping should be clearly separated from functional changes in terms of SVN commit history. This is time-consuming now, but is good for the long term health of the code so its worth spending time on, IMO. Finally, once your account is setup, it'll get much easier to do all this ofcourse, so perhaps this is the last patch we'll have to wrestle with a bit :-)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
The finishing touches.
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: (was: JEXL-85.patch)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch, JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Remaining Estimate: 0h
Original Estimate: 0h
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JEXL-85) 2.0 grammar finishing touches
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743392#action_12743392 ]
Henri Biestro commented on JEXL-85:
-----------------------------------
StatementExpression are no longer creating objects (they are #void in the Parser.jjt).
Thus there is one child level that does not exist anymore.
The {s,g}etProperty are checked through the AssignTest.java.
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743392#action_12743392 ]
Henri Biestro edited comment on JEXL-85 at 8/14/09 12:46 PM:
-------------------------------------------------------------
StatementExpression are no longer creating objects (they are #void in the Parser.jjt).
Thus there is one child level that does not exist anymore.
The JexlEngine.{s,g}etProperty methods where the change occur are checked through the AssignTest.java.
was (Author: henrib):
StatementExpression are no longer creating objects (they are #void in the Parser.jjt).
Thus there is one child level that does not exist anymore.
The {s,g}etProperty are checked through the AssignTest.java.
> 2.0 grammar finishing touches
> -----------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:37 AM:
------------------------------------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312&view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809316&view=rev
Log:
Refactored BitwiseOperator to use asserter.
Removed main methods from tests (use JexlTestCase instead).
Added parenthesized expression tests & further Debugger checking.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/ArithmeticTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BitwiseOperatorTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BlockTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809317&view=rev
Log:
Implementation moved to ExpressionImpl.java
Removed:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/ScriptImpl.java
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169&view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312&view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809316&view=rev
Log:
Refactored BitwiseOperator to use asserter.
Removed main methods from tests (use JexlTestCase instead).
Added parenthesized expression tests & further Debugger checking.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/ArithmeticTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BitwiseOperatorTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BlockTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Assignee: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Made Java 1.5 compatible (@Override error on interface implementation)
Incorporates JEXL-88 (changes in o.a.c.jexl.introspection)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing
touches & debugger update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749166#action_12749166 ]
Henri Biestro edited comment on JEXL-85 at 8/29/09 10:11 AM:
-------------------------------------------------------------
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099&view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160&view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';') optional.
This implied a change in AdditiveOperation and the introduction of AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced by AdditiveNode.
Debugger.java: made debugger expression-AST roundtrip enabled; the Debugger can regenerate an expression from AST that when parsed, will give back an equivalent AST (fixes JEXL-86).
JexlEngine.java: modified because StatementExpression are no longer creating nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JEXL-85) 2.0 grammar finishing touches & debugger
update
Posted by "Henri Biestro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Biestro updated JEXL-85:
------------------------------
Attachment: JEXL-85.patch
Added more tests for the Debugger (roundtrips correctly tests expressions)
> 2.0 grammar finishing touches & debugger update
> -----------------------------------------------
>
> Key: JEXL-85
> URL: https://issues.apache.org/jira/browse/JEXL-85
> Project: Commons JEXL
> Issue Type: Improvement
> Reporter: Henri Biestro
> Fix For: 2.0
>
> Attachments: JEXL-85.patch, JEXL-85.patch
>
>
> The Parser.jjt carries some extras that are not (longer) necessary (the "debug" field, NODE_USES_PARSER option).
> Tthe {Expression,Statement,Reference}Expression dont need to create real nodes.
> There are a few places where the LOOKAHEAD can be reduced or more explicit.
> Some expressions (Reference) are really hard to read partly due to formatting.
> The Debugger is also out of sync with the latest grammar updates (Map literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.