You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/16 15:34:40 UTC

[GitHub] [arrow] jpedroantunes opened a new pull request #9726: ARROW-11987: [C++] Implement trigonometric functions in Gandiva module

jpedroantunes opened a new pull request #9726:
URL: https://github.com/apache/arrow/pull/9726


   Implement base trigonometric functions (sin; cos; asin; acos; tan; atan; sinh; cosh; tanh; cotg; radians; degrees;)
   
   JIRA issue: https://issues.apache.org/jira/browse/ARROW-11987


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] projjal commented on a change in pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions

Posted by GitBox <gi...@apache.org>.
projjal commented on a change in pull request #9726:
URL: https://github.com/apache/arrow/pull/9726#discussion_r598375361



##########
File path: cpp/src/gandiva/function_registry_math_ops.cc
##########
@@ -59,6 +59,13 @@ std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
       BINARY_SAFE_NULL_NEVER_BOOL_FN(is_distinct_from, {}),
       BINARY_SAFE_NULL_NEVER_BOOL_FN(is_not_distinct_from, {}),
 
+      // trigonometry functions
+      MATH_UNARY_OPS(sin, {}), MATH_UNARY_OPS(cos, {}), MATH_UNARY_OPS(asin, {}),
+      MATH_UNARY_OPS(acos, {}), MATH_UNARY_OPS(tan, {}), MATH_UNARY_OPS(atan, {}),
+      MATH_UNARY_OPS(sinh, {}), MATH_UNARY_OPS(cosh, {}), MATH_UNARY_OPS(tanh, {}),
+      MATH_UNARY_OPS(cot, {}), MATH_UNARY_OPS(radians, {}), MATH_UNARY_OPS(degrees, {}),
+      BINARY_SYMMETRIC_SAFE_NULL_IF_NULL(atan2, {}, float64),

Review comment:
       atan should also be able to take other numeric types (int32, int64, and float32) as arguments. Use MATH_BINARY_UNSAFE marcro




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] praveenbingo closed pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions

Posted by GitBox <gi...@apache.org>.
praveenbingo closed pull request #9726:
URL: https://github.com/apache/arrow/pull/9726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jpedroantunes commented on pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions

Posted by GitBox <gi...@apache.org>.
jpedroantunes commented on pull request #9726:
URL: https://github.com/apache/arrow/pull/9726#issuecomment-804389337


   @emkornfield any idea about this AMD64 Conda build problem (do not seems related to my pull request)?
   https://github.com/apache/arrow/pull/9726/checks?check_run_id=2166216447
   
   It seems to be inconsistent, sometimes it fails, other times it passes.
   Just this is missing so this can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jpedroantunes removed a comment on pull request #9726: ARROW-11987: [C++][Gandiva] Implement trigonometric functions

Posted by GitBox <gi...@apache.org>.
jpedroantunes removed a comment on pull request #9726:
URL: https://github.com/apache/arrow/pull/9726#issuecomment-804389337


   @emkornfield any idea about this AMD64 Conda build problem (do not seems related to my pull request)?
   https://github.com/apache/arrow/pull/9726/checks?check_run_id=2166216447
   
   It seems to be inconsistent, sometimes it fails, other times it passes.
   Just this is missing so this can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9726: ARROW-11987: [C++] Implement trigonometric functions in Gandiva module

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9726:
URL: https://github.com/apache/arrow/pull/9726#issuecomment-800636945


   https://issues.apache.org/jira/browse/ARROW-11987


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org