You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org> on 2008/12/19 10:45:19 UTC
[jira] Created: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
eclipse:eclipse always adds project-facet for ejb 2.1
-----------------------------------------------------
Key: MECLIPSE-514
URL: http://jira.codehaus.org/browse/MECLIPSE-514
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Components: WTP support
Affects Versions: 2.5.1
Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
Reporter: Thorsten Gawantka
I have an ejb-project with ejb-version 3.0 specified. (see below)
Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
--- pom.xml Sniplets ---
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.5</source>
<target>1.5</target>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<configuration>
<wtpversion>2.0</wtpversion>
<downloadSources>true</downloadSources>
</configuration>
</plugin>
<plugin>
<artifactId>maven-ejb-plugin</artifactId>
<configuration>
<ejbVersion>3.0</ejbVersion>
<archive>
<manifest>
<addClasspath>true</addClasspath>
</manifest>
</archive>
</configuration>
</plugin>
</plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196473#action_196473 ]
Thorsten Gawantka commented on MECLIPSE-514:
--------------------------------------------
OK, now its clear, sorry for the harsh words, if we can help improving the plugin and/or its code-base we will do ;-)
Kind Regards
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MECLIPSE-514:
-------------------------------------
Patch Submitted: [Yes]
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Gawantka updated MECLIPSE-514:
---------------------------------------
Attachment: JeeUtils.patch
The diff/patch-file for JeeUtils-Class
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Gawantka updated MECLIPSE-514:
---------------------------------------
Attachment: JeeUtils.java
My modified version of JeeUtils
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Joerg Schaible (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158693#action_158693 ]
Joerg Schaible commented on MECLIPSE-514:
-----------------------------------------
Did you call eclipse:clean before? The eclipse-plugin will not overwrite existing settings.
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196437#action_196437 ]
Thorsten Gawantka commented on MECLIPSE-514:
--------------------------------------------
Hey are you serious? Are you expecting to your contributors to make the work of the core-team? You should be happy that the users report such obvious errors.
If you expect to write a patch and the resulting test-case for all you reporter then this project will be dead soon, i think.
If I have to write a test case for you, you should think about you role in the development of this pice of software!
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158698#action_158698 ]
Thorsten Gawantka commented on MECLIPSE-514:
--------------------------------------------
No, i called no "eclipse:clean".
I have checked out the sourcecode, so i can see, if I made a misstake or there is a real bug.
>From the sourcecode I can see, that the facet for ejb is set by a search over the dependencies,
but i cannot understand why it is not set by the value of the ejb-build-plugin, as you can see from my sniplets, you can set the ejbVersion there.
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Benno Vogel (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196386#action_196386 ]
Benno Vogel commented on MECLIPSE-514:
--------------------------------------
This is quite old, but apparently still open.
A patch seems to be available, please fix....
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158704#action_158704 ]
Arnaud Heritier commented on MECLIPSE-514:
------------------------------------------
Can you generate a diff of the file. It's easier to us to apply a patch.
thx
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-514) eclipse:eclipse always
adds project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158701#action_158701 ]
Thorsten Gawantka edited comment on MECLIPSE-514 at 12/19/08 5:26 AM:
----------------------------------------------------------------------
I have patched the JeeUtils-Class, so it recognises the maven-ejb-plugin->ejbVersion Configuration.
was (Author: thgaw):
I have patched the JeeUtils-Class, so it recognises the maven-ejb-plugin->ejbVersion Configuration.
Where can I upload my modified Source-File?
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196470#action_196470 ]
Arnaud Heritier commented on MECLIPSE-514:
------------------------------------------
Really serious !!! When I'm talking about testcase it's not a unit test but an integration test that shows what you have in your pom and what you expect in your generated eclipse configuration files.
Why ? because this plugin is the more complex of our plugins with the larger base code to try to handle all versions of eclipse, its proprietary versions, its extensions and more.
This plugin is quite dead because of not having created enough tests and each change today is more and more dangerous.
Latests versions had many important regressions because that.
Thus excuse me to try to ask to have test case to validate our developments but this for me the only solution to improve things.
In the case of this issue I agree that your description should allow us to create a such integration testcase and your fix seems to be good. But when someone who didn't delivered the patch comes to just say "hey !! what are you doing you just have to fix...." I'm not agree. No we don't just have to ... We have to spend some time on it to do all of that.
Cheers,
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Messó (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253791#action_253791 ]
Messó commented on MECLIPSE-514:
--------------------------------
Please add support for JavaEE 6.0 and EJB 3.1, just add some constants to JeeDescriptor, and add a row to JeeUtils. Easy-peasy. Thanks!
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Thorsten Gawantka (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158701#action_158701 ]
Thorsten Gawantka commented on MECLIPSE-514:
--------------------------------------------
I have patched the JeeUtils-Class, so it recognises the maven-ejb-plugin->ejbVersion Configuration.
Where can I upload my modified Source-File?
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-514) eclipse:eclipse always adds
project-facet for ejb 2.1
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196413#action_196413 ]
Arnaud Heritier commented on MECLIPSE-514:
------------------------------------------
We have no testcase attached and I'm less and less open to modify the plugin without it.
> eclipse:eclipse always adds project-facet for ejb 2.1
> -----------------------------------------------------
>
> Key: MECLIPSE-514
> URL: http://jira.codehaus.org/browse/MECLIPSE-514
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.5.1
> Environment: Ubuntu Linux 8.10, Eclipse Ganymede, maven 2.0.9, java 1.6.10
> Reporter: Thorsten Gawantka
> Attachments: JeeUtils.java, JeeUtils.patch
>
>
> I have an ejb-project with ejb-version 3.0 specified. (see below)
> Now if i execute "mvn eclipse:eclipse" the genereated eclipse project always contains the facet for ejb 2.1
> If i edit the the facet in the corresponding file to ejb 3.0, and execute "mvn eclipse:eclipse" again, the facet is reseted to ejb 2.1
> If i add the additonalFacet for ejb 3.0 to the pom, then the corresponding file contains facets for ejb 2.1 *and* ejb 3.0
> --- pom.xml Sniplets ---
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <configuration>
> <wtpversion>2.0</wtpversion>
> <downloadSources>true</downloadSources>
> </configuration>
> </plugin>
> <plugin>
> <artifactId>maven-ejb-plugin</artifactId>
> <configuration>
> <ejbVersion>3.0</ejbVersion>
> <archive>
> <manifest>
> <addClasspath>true</addClasspath>
> </manifest>
> </archive>
> </configuration>
> </plugin>
> </plugins>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira