[GitHub] [airflow] JulesTriomphe commented on issue #29273: Status of testing of Apache Airflow Helm Chart 1.8.0rc1

["JulesTriomphe (via GitHub)" <gi...@apache.org>]

JulesTriomphe commented on issue #29273:
URL: https://github.com/apache/airflow/issues/29273#issuecomment-1411750516

   I have spotted multiple issues:
   
   - There is a missing prefixing `-` [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/jobs/migrate-database-job.yaml#L111) to cleanly render the volume mounts for the migrate-database-job, same [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/dag-processor/dag-processor-deployment.yaml#L155) for the dag-processor, [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/scheduler/scheduler-deployment.yaml#L145), [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/scheduler/scheduler-deployment.yaml#L224) and [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/scheduler/scheduler-deployment.yaml#L253) for the scheduler, [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/triggerer/triggerer-deployment.yaml#L125) and [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/triggerer
 /triggerer-deployment.yaml#L164) for the triggerer, [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/webserver/webserver-deployment.yaml#L137) and [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/webserver/webserver-deployment.yaml#L193) for the webserver, [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/workers/worker-deployment.yaml#L155), [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/workers/worker-deployment.yaml#L212), [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/workers/worker-deployment.yaml#L274) and [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/workers/worker-deployment.yaml#L306) for the workers
   - Globally defined volumes are missing in the [pod-template-file](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/files/pod-template-file.kubernetes-helm-yaml) which will make pod spawning fail on clusters where readOnlyRootFilesystem is True and a volume for airflow home has been set globally. Workaround would be to set that volume in each system's extraVolumes and extraVolumeMounts but that would greatly reduce the functionality of global volumes and volume mounts.
   - There is a missing trailing `-` [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/_helpers.yaml#L431) to cleanly render the "airflow_dags_mount"
   - There is a missing prefixing `-` [here](https://github.com/apache/airflow/blob/helm-chart/1.8.0rc1/chart/templates/webserver/webserver-service.yaml#L45) to cleanly render webserver service ports, and I didn't manage to clean the rendering of the fields themselves (name aligned with the dash). The current state looks like this:
   ```yaml
   ports:
   
       - 
         name: airflow-ui
         port: 8080
   ```
   
   I will try adding the missing globally defined volumes to the pod template file, deploy and then open a PR to correct this and another for the rendering issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org