You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2025/04/04 14:15:00 UTC
[jira] [Comment Edited] (HTTPCLIENT-2366) HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940992#comment-17940992 ]
Gary D. Gregory edited comment on HTTPCLIENT-2366 at 4/4/25 2:14 PM:
---------------------------------------------------------------------
I'll create a PR with a unit test and the main change over the weekend...
was (Author: garydgregory):
I create a PR with a unit test and the main change over the weekend...
> HttpClient5 - RequestEntityProxy#isRepeatable incorrectly returns false before entity is consumed
> -------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2366
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2366
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (classic)
> Reporter: Nicklas Wallgren
> Priority: Major
>
> The behavior of {{RequestEntityProxy#isRepeatable}} changed in [this commit|https://github.com/apache/httpcomponents-client/commit/a1eed8084de7c58203a6acb799b7e4b04f669d39#r154843658], where the method now returns {{false}} unless {{writeTo()}} has already been called.
> This appears to be a regression. Previously, an entity was considered repeatable as long as it hadn't been consumed yet and the original entity itself was repeatable. The new logic incorrectly assumes that an entity is only repeatable _after_ it's been consumed, which defeats the purpose of determining retry eligibility _before_ transmission.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org