[GitHub] [arrow] nbauernfeind commented on a change in pull request #10058: ARROW-12111: [Java] Generate flatbuffer files using flatc 1.12.0

[GitBox <gi...@apache.org>]

nbauernfeind commented on a change in pull request #10058:
URL: https://github.com/apache/arrow/pull/10058#discussion_r614263386



##########
File path: java/README.md
##########
@@ -64,26 +64,46 @@ and arrow-format into a single JAR.  Using the classifier "shade-format-flatbuff
 pom.xml will make use of this JAR, you can then exclude/resolve the original dependency to
 a version of your choosing.
 
+### Updating the flatbuffers generated code
+
+To update the checked-in flatbuffer generated code perform the following:
+
+```bash
+cd $ARROW_HOME
+
+# remove the existing files
+rm -rf java/format/src
+
+# regenerate from the .fbs files
+flatc --java -o java/format/src/main/java format/*.fbs
+
+# prepend license header
+find java/format/src -type f | while read file; do
+  (cat header | while read line; do echo "// $line"; done; cat $file) > $file.tmp

Review comment:
       The header is already checked into the root of apache/arrow.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org