You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/01 04:25:48 UTC

[GitHub] [beam] TobKed commented on a change in pull request #12150: [BEAM-10398] Use GitHub Actions in wheels release process for Python

TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r463920065



##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -170,7 +170,7 @@ def get_last_run_id(
       f"GCS location corresponding to artifacts built in this run: "
       f"gs://beam-wheels-staging/{release_branch}/{release_commit}-{last_run_id}/"
   )
-  return safe_get(last_run, "id")
+  return last_run_id

Review comment:
       I checked what is the quota for operations on GCS and it seems huge:
   
   > There is no limit to writes across multiple objects, which includes uploading, updating, and deleting objects. Buckets initially support roughly 1000 writes per second and then scale as needed.
   
   source: https://cloud.google.com/storage/quotas#objects
   
   What do you think about this lifecycle bucket settings? I checked and size of the files on the bucket is approximately 42GB, github actions are enabled for 1 month now. Rounding this numbers up, after one year it storage occupancy will be ~600GB and remains more or less constant.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org