You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/11/24 13:20:03 UTC
Review Request 40638: Base framework for scheduler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java PRE-CREATION
lens-api/src/main/resources/example-job.xml PRE-CREATION
lens-api/src/main/resources/job-0.1.xsd PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 5f268cb
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml b19857f
src/site/apt/admin/config.apt 88c1489
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/example-job.xml, line 1
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line1>
> >
> > Seems forgot to remove the class from lens-api.
Oops. Will remove it.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/example-job.xml, line 31
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147006#file1147006line31>
> >
> > session_db here is the db name : like default or db1 or mydb or any
I see, will change. Thanks.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, line 29
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147009#file1147009line29>
> >
> > Is this the class returned to client. It should be moved to lens-api module
Yes, that's the intention. will move.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java, line 27
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147010#file1147010line27>
> >
> > move to lens-api module
Will move.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java, line 42
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147002#file1147002line42>
> >
> > I feel we should call the class ScheduleHandle instead of SchedulerJobHandler.
> >
> > and similarly others. what do you think?
Do you mean to use Schedule instead of SchedulerJob everywhere? I had given my reasons above for not incorporating those changes earlier. If it still looks out of place to you then I am happy to change it. Just let me know what would you like for the following:
SchdulerJob -> ?
SchedulerJobInstance -> ?
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108188
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java, line 42
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147002#file1147002line42>
> >
> > I feel we should call the class ScheduleHandle instead of SchedulerJobHandler.
> >
> > and similarly others. what do you think?
>
> Ajay Yadava wrote:
> Do you mean to use Schedule instead of SchedulerJob everywhere? I had given my reasons above for not incorporating those changes earlier. If it still looks out of place to you then I am happy to change it. Just let me know what would you like for the following:
> SchdulerJob -> ?
> SchedulerJobInstance -> ?
OK. Thinking again, current naming seems fine. Dropping my comment.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108188
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108188
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java (line 42)
<https://reviews.apache.org/r/40638/#comment167514>
I feel we should call the class ScheduleHandle instead of SchedulerJobHandler.
and similarly others. what do you think?
lens-api/src/main/resources/example-job.xml (line 1)
<https://reviews.apache.org/r/40638/#comment167515>
Seems forgot to remove the class from lens-api.
lens-examples/src/main/resources/example-job.xml (line 31)
<https://reviews.apache.org/r/40638/#comment167516>
session_db here is the db name : like default or db1 or mydb or any
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java (line 29)
<https://reviews.apache.org/r/40638/#comment167517>
Is this the class returned to client. It should be moved to lens-api module
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java (line 27)
<https://reviews.apache.org/r/40638/#comment167518>
move to lens-api module
- Amareshwari Sriramadasu
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 27, 2015, 11:03 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java, line 27
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147007#file1147007line27>
> >
> > `SchedulerJobStats`?
Will rename.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108210
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108210
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java (line 27)
<https://reviews.apache.org/r/40638/#comment167552>
`SchedulerJobStats`?
- Rajat Khandelwal
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 46
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line46>
> >
> > I feel like `resource_path` should be part of `execution`. Since it's a session's property. Across two different sessions spaced in a long enough time frame, adding same resource might end up in addition of different jars.
>
> Amareshwari Sriramadasu wrote:
> +1. Should be part of execution. But it will be added once in each schedule's session.
Will make it a part of the execution.
> On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 48
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147005#file1147005line48>
> >
> > What will job_conf contain?
>
> Amareshwari Sriramadasu wrote:
> I think it should be configuration for the schedule itself. For example: for specifying number of retries and etc. @ajay, please add documentaion for elements also :)
Added documentation for the elements.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108207
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 46
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line46>
> >
> > I feel like `resource_path` should be part of `execution`. Since it's a session's property. Across two different sessions spaced in a long enough time frame, adding same resource might end up in addition of different jars.
+1. Should be part of execution. But it will be added once in each schedule's session.
> On Nov. 27, 2015, 11 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 48
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147005#file1147005line48>
> >
> > What will job_conf contain?
I think it should be configuration for the schedule itself. For example: for specifying number of retries and etc. @ajay, please add documentaion for elements also :)
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108207
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108207
-----------------------------------------------------------
lens-api/src/main/resources/example-job.xml (line 46)
<https://reviews.apache.org/r/40638/#comment167549>
I feel like `resource_path` should be part of `execution`. Since it's a session's property. Across two different sessions spaced in a long enough time frame, adding same resource might end up in addition of different jars.
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 48)
<https://reviews.apache.org/r/40638/#comment167547>
What will job_conf contain?
- Rajat Khandelwal
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
>
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they all be from same user?
>
> Amareshwari Sriramadasu wrote:
> I agree with Ajay, one schedule would only work with one session, I don't think we need to support multiple sessions at all.
>
> Let us keep the version1 simple with one session and one query.
>
> Ajay Yadava wrote:
> Is it possible that we can unblock this JIRA and discuss the use case and requirements for multiple actions/sessions in parallel? I will be happy to incorporate any changes which might result as part of that discussion.
Rajat, are you suggesting any more changes in this jira? If not, can this be dropped?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
>
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they all be from same user?
>
> Amareshwari Sriramadasu wrote:
> I agree with Ajay, one schedule would only work with one session, I don't think we need to support multiple sessions at all.
>
> Let us keep the version1 simple with one session and one query.
Is it possible that we can unblock this JIRA and discuss the use case and requirements for multiple actions/sessions in parallel? I will be happy to incorporate any changes which might result as part of that discussion.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 26, 2015, 12:21 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
Come to think of it, first and third are functionaly equivalent.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > pom.xml, line 61
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147017#file1147017line61>
> >
> > Can you mention which new feature you are using?
> >
> > And please verify this version is backward compatible.
@Utility
Even otherwise it is good to stay on the latest whenever feasible. I went through the change logs before using it and I didn't see any backward incompatible changes.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
>
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they all be from same user?
>
> Amareshwari Sriramadasu wrote:
> I agree with Ajay, one schedule would only work with one session, I don't think we need to support multiple sessions at all.
>
> Let us keep the version1 simple with one session and one query.
>
> Ajay Yadava wrote:
> Is it possible that we can unblock this JIRA and discuss the use case and requirements for multiple actions/sessions in parallel? I will be happy to incorporate any changes which might result as part of that discussion.
>
> Amareshwari Sriramadasu wrote:
> Rajat, are you suggesting any more changes in this jira? If not, can this be dropped?
>
> Rajat Khandelwal wrote:
> +1 for Single session approach. Let us at least rename `query_conf` and `session_conf` to just `conf`. Since in the xml heirarchy `session/conf` and `query/conf` are more readable than `session/session_conf` and `query/query_conf`. Other schema changes can be taken up as and when they make more sense, which will happen as more code is written in the module.
Currently both query_conf and session_conf are under same parent, so I am assuming that you are suggesting this approach(suggested from above).
<execution>
<session>
<db>http://192.168.30.30:5000/</db>
<conf>
<key>sessionKey1</key>
<value>sessionValue1</value>
</conf>
</session>
<query>
<query>select name from name_table;</query>
<conf>
<key>queryKey1</key>
<value>queryValue1</value>
</conf>
</query>
</execution>
I will make the necessary changes accordingly.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 26, 2015, 12:21 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
Considering the important distinction of session conf and query conf, would the following make more sense?
```
<execution>
<session>
<db>http://192.168.30.30:5000/</db>
<conf>
<key>sessionKey1</key>
<value>sessionValue1</value>
</conf>
</session>
<query>
<query>select name from name_table;</query>
<conf>
<key>queryKey1</key>
<value>queryValue1</value>
</conf>
</query>
</execution>
```
As a sequence of two actions, open a session with a conf and run a query with a conf.
The following might also make sense:
```
<execution>
<session>
<id>session1</id>
<db>http://192.168.30.30:5000/</db>
<conf>
<key>sessionKey1</key>
<value>sessionValue1</value>
</conf>
</session>
<query>
<session_id>session1</session_id>
<query>select name from name_table;</query>
<conf>
<key>queryKey1</key>
<value>queryValue1</value>
</conf>
</query>
</execution>
```
With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
Third option is, we note that any execution will happen in a session, so:
```
<execution>
<!-- begin implicit session conf -->
<db>http://192.168.30.30:5000/</db>
<conf>
<key>sessionKey1</key>
<value>sessionValue1</value>
</conf>
<!-- end implicit session conf -->
<query>
<session_id>session1</session_id>
<query>select name from name_table;</query>
<conf>
<key>queryKey1</key>
<value>queryValue1</value>
</conf>
</query>
</execution>
```
Here, opening multiple sessions will happen thorugh multiple `execution` tags.
Would like to hear the views from implementation and use-case standpoints.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
>
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they all be from same user?
I agree with Ajay, one schedule would only work with one session, I don't think we need to support multiple sessions at all.
Let us keep the version1 simple with one session and one query.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
I am still not clear on why multiple sessions are required, won't they all be from same user?
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
We can start with query as one execution and minimally run on a session in a db, as it is put up now.
Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Nov. 26, 2015, 12:21 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > <https://reviews.apache.org/r/40638/diff/2/?file=1147004#file1147004line27>
> >
> > Feels like keeping two conf is only useful when they are present on different heirarchies.
> >
> > If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
> >
> > Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
> >
> > Thoughts?
>
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each action through xsd. I think what we can support is List of REST Actions, we would be generic. Whether we want to support Lens REST actions to be schedulable or not is something debatable. But can be done later.
>
> We can start with query as one execution and minimally run on a session in a db, as it is put up now.
>
> Coming back to merging session conf and query conf into single one, it should be fine as long as it is single query, but we should not take away the fact that query conf can be different for each query when there are multiple queries. So, I'm fine merging them into one in this jira.
>
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, would the following make more sense?
>
> ```
> <execution>
> <session>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> As a sequence of two actions, open a session with a conf and run a query with a conf.
>
> The following might also make sense:
>
> ```
> <execution>
> <session>
> <id>session1</id>
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> </session>
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
>
> With this you can open multiple sessions and associate any other action to take place in any of the sessions. Also, it's more explicit. Here, there will be an implicit parallel execution of actions of a different sessions.
>
>
> Third option is, we note that any execution will happen in a session, so:
>
> ```
> <execution>
> <!-- begin implicit session conf -->
> <db>http://192.168.30.30:5000/</db>
> <conf>
> <key>sessionKey1</key>
> <value>sessionValue1</value>
> </conf>
> <!-- end implicit session conf -->
> <query>
> <session_id>session1</session_id>
> <query>select name from name_table;</query>
> <conf>
> <key>queryKey1</key>
> <value>queryValue1</value>
> </conf>
> </query>
> </execution>
>
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` tags.
>
>
> Would like to hear the views from implementation and use-case standpoints.
>
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
>
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they all be from same user?
>
> Amareshwari Sriramadasu wrote:
> I agree with Ajay, one schedule would only work with one session, I don't think we need to support multiple sessions at all.
>
> Let us keep the version1 simple with one session and one query.
>
> Ajay Yadava wrote:
> Is it possible that we can unblock this JIRA and discuss the use case and requirements for multiple actions/sessions in parallel? I will be happy to incorporate any changes which might result as part of that discussion.
>
> Amareshwari Sriramadasu wrote:
> Rajat, are you suggesting any more changes in this jira? If not, can this be dropped?
+1 for Single session approach. Let us at least rename `query_conf` and `session_conf` to just `conf`. Since in the xml heirarchy `session/conf` and `query/conf` are more readable than `session/session_conf` and `query/query_conf`. Other schema changes can be taken up as and when they make more sense, which will happen as more code is written in the module.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
-----------------------------------------------------------
lens-api/src/main/resources/example-job.xml (lines 27 - 35)
<https://reviews.apache.org/r/40638/#comment167469>
Feels like keeping two conf is only useful when they are present on different heirarchies.
If we are creating session just to run a single query, then there is no point of having session level and query level configurations. One configuration should be enough
Thinking in those terms, an execution shouldn't be a `query`, it should be a session. Inside that session there can be multiple actions, which might decide the next actions. Any of those actions can be a `query` action.
Thoughts?
pom.xml (line 61)
<https://reviews.apache.org/r/40638/#comment167468>
Can you mention which new feature you are using?
And please verify this version is backward compatible.
- Rajat Khandelwal
On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 9:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, line 38
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148018#file1148018line38>
> >
> > Is this not ScheduleJobHandle ?
Yes. It changed after review request and I forgot to update. Will fix it.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, lines 47-87
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148018#file1148018line47>
> >
> > I think all of these fields should be replaced with single object XJob
Agreed, will fix.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 33
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148020#file1148020line33>
> >
> > Should be SchedulerJobInstanceHandle
Yes. Will fix it.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 36
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148020#file1148020line36>
> >
> > Why is this new session handle. Should be "session handle in which instance was run"
The thought was that the setter gets the new value which needs to be set.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 39
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148020#file1148020line39>
> >
> > Return LensSessionHandle ?
Will fix.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 42
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148020#file1148020line42>
> >
> > StartTime - when the instance started to run.
> >
> > I see all other comments are also saying the values to be set. Instead they are actually when it ran.
These are the documentations which will be generated on the setter methods. You pass in the value which you want to be set and hence the language. @returns documentation is exactly what you have suggested. I think it is correct, let me know if you think otherwise.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 47
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148021#file1148021line47>
> >
> > Should be "Name of the scheduled job" ?
Yes. Will update.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 102
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148021#file1148021line102>
> >
> > If we are separating session into separate type, resource_path should be actually part of session.
Sure. Fixed it.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 117
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148021#file1148021line117>
> >
> > Can we be consistent with names for types and elements? All types can start with x_type and elements would contain actual names and no x_ ?
Definitely. Sorry for the oversight.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148021#file1148021line153>
> >
> > Comment needs to be updated.
Will fix.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 122
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148021#file1148021line122>
> >
> > Can you change the comment to "Database name to be used in session" ?
Sure. Will update.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 81
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148020#file1148020line81>
> >
> > I dont think we would allow modification of an instance, so should not be required.
Yes. will fix
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, line 55
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148018#file1148018line55>
> >
> > we should return XJob instead of Clob.
Makes sense, will fix.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, line 63
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148018#file1148018line63>
> >
> > Instead of Clob we should return correspondig objects. Applies for all Clob objects.
Yes, will fix.
> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/example-job.xml, line 1
> > <https://reviews.apache.org/r/40638/diff/3/?file=1148022#file1148022line1>
> >
> > Can we update the client packaging to include schedule-examples/ ?
The files under resources don't follow a fixed convention for prefix or suffix and hence it is not possible to separate the scheduler examples from others using a few generic regular expressions e.g. there are files like city.xml, customer.xml etc. If you want then I can try solving it in a separate JIRA.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108280
-----------------------------------------------------------
On Nov. 27, 2015, 7:46 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 7:46 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108280
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 38)
<https://reviews.apache.org/r/40638/#comment167633>
Is this not ScheduleJobHandle ?
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (lines 47 - 87)
<https://reviews.apache.org/r/40638/#comment167650>
I think all of these fields should be replaced with single object XJob
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 55)
<https://reviews.apache.org/r/40638/#comment167634>
we should return XJob instead of Clob.
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java (line 63)
<https://reviews.apache.org/r/40638/#comment167635>
Instead of Clob we should return correspondig objects. Applies for all Clob objects.
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 33)
<https://reviews.apache.org/r/40638/#comment167636>
Should be SchedulerJobInstanceHandle
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 36)
<https://reviews.apache.org/r/40638/#comment167638>
Why is this new session handle. Should be "session handle in which instance was run"
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 39)
<https://reviews.apache.org/r/40638/#comment167639>
Return LensSessionHandle ?
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 42)
<https://reviews.apache.org/r/40638/#comment167640>
StartTime - when the instance started to run.
I see all other comments are also saying the values to be set. Instead they are actually when it ran.
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 81)
<https://reviews.apache.org/r/40638/#comment167641>
I dont think we would allow modification of an instance, so should not be required.
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 47)
<https://reviews.apache.org/r/40638/#comment167642>
Should be "Name of the scheduled job" ?
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 102)
<https://reviews.apache.org/r/40638/#comment167643>
If we are separating session into separate type, resource_path should be actually part of session.
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 117)
<https://reviews.apache.org/r/40638/#comment167644>
Can we be consistent with names for types and elements? All types can start with x_type and elements would contain actual names and no x_ ?
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 122)
<https://reviews.apache.org/r/40638/#comment167646>
Can you change the comment to "Database name to be used in session" ?
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 153)
<https://reviews.apache.org/r/40638/#comment167647>
Comment needs to be updated.
lens-examples/src/main/resources/example-job.xml (line 1)
<https://reviews.apache.org/r/40638/#comment167649>
Can we update the client packaging to include schedule-examples/ ?
- Amareshwari Sriramadasu
On Nov. 27, 2015, 7:46 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 7:46 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155940#file1155940line153>
> >
> > Needs update
Sorry, I fixed it but looks like I missed it in the patch. willf ix.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, lines 102-106
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155940#file1155940line102>
> >
> > Please add comments for these also.
will do.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, line 57
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155944#file1155944line57>
> >
> > Shouldnt this take SchedulerJobHandle as the param?
Yes. Will fix.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java, line 34
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155939#file1155939line34>
> >
> > Shouldnt we add its corresponding scheduleJobHandle also ?
Makes sense. Will add.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, line 47
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155944#file1155944line47>
> >
> > return object should be SchedulerJobHandle for all three methods below.
Will fix everywhere.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
-----------------------------------------------------------
On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, line 93
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155944#file1155944line93>
> >
> > Please update the comment with "updates will be applied only for newer instances. Running instances will be running with old definition"
Done.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, line 192
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155944#file1155944line192>
> >
> > Should there be api to kill/stop running instance ?
Added a kill api.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
-----------------------------------------------------------
On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, lines 102-106
> > <https://reviews.apache.org/r/40638/diff/4/?file=1155940#file1155940line102>
> >
> > Please add comments for these also.
>
> Ajay Yadava wrote:
> will do.
These are simple element types. XSD doesn't support xs:annotation element on these, hence I didn't add it in the earlier patch. I will add the xml comments instead.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
-----------------------------------------------------------
On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java (line 34)
<https://reviews.apache.org/r/40638/#comment169297>
Shouldnt we add its corresponding scheduleJobHandle also ?
lens-api/src/main/resources/scheduler-job-0.1.xsd (lines 102 - 106)
<https://reviews.apache.org/r/40638/#comment169295>
Please add comments for these also.
lens-api/src/main/resources/scheduler-job-0.1.xsd (line 153)
<https://reviews.apache.org/r/40638/#comment169296>
Needs update
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 47)
<https://reviews.apache.org/r/40638/#comment169299>
return object should be SchedulerJobHandle for all three methods below.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 57)
<https://reviews.apache.org/r/40638/#comment169298>
Shouldnt this take SchedulerJobHandle as the param?
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 93)
<https://reviews.apache.org/r/40638/#comment169301>
Please update the comment with "updates will be applied only for newer instances. Running instances will be running with old definition"
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 192)
<https://reviews.apache.org/r/40638/#comment169302>
Should there be api to kill/stop running instance ?
- Amareshwari Sriramadasu
On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:06 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 10, 2015, 8:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java, line 57
> > <https://reviews.apache.org/r/40638/diff/5/?file=1158260#file1158260line57>
> >
> > return would be void.
It's just to be consistent with SubmitAndSchedule. If you want I can change it.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109707
-----------------------------------------------------------
On Dec. 10, 2015, 8:01 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 8:01 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109707
-----------------------------------------------------------
Ship it!
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 57)
<https://reviews.apache.org/r/40638/#comment169323>
return would be void.
- Amareshwari Sriramadasu
On Dec. 10, 2015, 8:01 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 8:01 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 39b72dc
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml 732b3bb
> src/site/apt/admin/config.apt bcf4b7d
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 8:47 a.m.)
Review request for lens.
Changes
-------
Changed the return type to void for scheduleJob method.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
lens-examples/src/main/resources/example-job.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 39b72dc
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml 732b3bb
src/site/apt/admin/config.apt bcf4b7d
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 8:01 a.m.)
Review request for lens.
Changes
-------
Addressed the review comments.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
lens-examples/src/main/resources/example-job.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 39b72dc
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml 732b3bb
src/site/apt/admin/config.apt bcf4b7d
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 2:06 p.m.)
Review request for lens.
Changes
-------
Addressed the latest review comments.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
lens-examples/src/main/resources/example-job.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 39b72dc
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml 732b3bb
src/site/apt/admin/config.apt bcf4b7d
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
(Updated Nov. 27, 2015, 7:46 p.m.)
Review request for lens.
Changes
-------
Addressed the review comments.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java PRE-CREATION
lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
lens-examples/src/main/resources/example-job.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 5f268cb
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml b19857f
src/site/apt/admin/config.apt 88c1489
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 3:57 p.m.)
Review request for lens.
Changes
-------
Addressed review comments.
Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879
Repository: lens
Description
-------
Base framework for lens scheduler service and job definition.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
lens-api/src/main/resources/example-job.xml PRE-CREATION
lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
lens-examples/src/main/resources/example-job.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
lens-server/src/main/resources/lensserver-default.xml 5f268cb
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
pom.xml b19857f
src/site/apt/admin/config.apt 88c1489
Diff: https://reviews.apache.org/r/40638/diff/
Testing
-------
Thanks,
Ajay Yadava
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 35
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138731#file1138731line35>
> >
> > Please add <xs:annotation><xs:documentation> for all elements and attributes.
> >
> > See cube-0.1.xsd, for example.
>
> Ajay Yadava wrote:
> <xs:annotation> is added at the definition of type not at the usage of type, it is already there for this type(and most others). I will again do a thorough check again if I have missed something.
>
> Amareshwari Sriramadasu wrote:
> I feel xs:annotation should be added for elements, because type documentation will be very much generic and context will be misisng. For ex: map_type is saying key, value pairs. session_conf which is a map_type element needs further explanation wrt what the configuration is for. Same applies to session_db and so on.
Sorry I didn't understand what you meant the first time. Got it. Will add documentation.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 56
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138728#file1138728line56>
> >
> > Instead of RuntimeException, can they defined as LensException or LensAPIException with error codes added?
>
> Ajay Yadava wrote:
> Makes sense, will add.
Removed these classes and used xs:dateTime
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 35
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138731#file1138731line35>
> >
> > Please add <xs:annotation><xs:documentation> for all elements and attributes.
> >
> > See cube-0.1.xsd, for example.
>
> Ajay Yadava wrote:
> <xs:annotation> is added at the definition of type not at the usage of type, it is already there for this type(and most others). I will again do a thorough check again if I have missed something.
I feel xs:annotation should be added for elements, because type documentation will be very much generic and context will be misisng. For ex: map_type is saying key, value pairs. session_conf which is a map_type element needs further explanation wrt what the configuration is for. Same applies to session_db and so on.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
-----------------------------------------------------------
On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 3:57 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION
> lens-examples/src/main/resources/example-job.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/example-job.xml, line 43
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138730#file1138730line43>
> >
> > start_time says it is starting from 2014, but cron says run in 2005. We should change this to be a different year - something between start and end
Yes. Makes sense, will fix.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 35
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138731#file1138731line35>
> >
> > Please add <xs:annotation><xs:documentation> for all elements and attributes.
> >
> > See cube-0.1.xsd, for example.
<xs:annotation> is added at the definition of type not at the usage of type, it is already there for this type(and most others). I will again do a thorough check again if I have missed something.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java, line 32
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138734#file1138734line32>
> >
> > I would say lets have class name as SchedulerService for interface and SchedulerServiceImpl for implementation to be consistent with other classes.
The thought behind this was that names which contain suffix (like "Impl" for implementations) and prefix (like "I" for interface) are bad conventions, just like java doesn't have such conventions. However, I agree it is better to follow any convention consistently rather than mixing it up. Will change it.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java, line 67
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138734#file1138734line67>
> >
> > Please explain return value for all methods
Will fix.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java, line 134
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138734#file1138734line134>
> >
> > why is getAllJobStats taking jobId?
> >
> > Also lets add state, user, name, long fromDate and toDate as other filters for getAllJobStats. You can look at getAllQueries in QueryExecutionService
It's a copy paste error :( thanks for catching it.
I will add filters.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, line 31
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138735#file1138735line31>
> >
> > Shall we name the class ScheduleJobInfo instead of SchedulerJobInfo ?
I actually wanted to keep it only job, just like Quartz but this terms is heavily overloaded so on the lines of MRJob (<component/framework>Job) I renamed it to SchedulerJob. SchedulerJob does look better to me as this name implies that this job belongs to scheduler.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, line 75
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138735#file1138735line75>
> >
> > Please add comments to all params in all classes
Will fix.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java, line 29
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138736#file1138736line29>
> >
> > ScheduleJobInstanceInfo?
Same as above. Let me know if you still feel differently and I will be happy to rename it.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java, line 71
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138734#file1138734line71>
> >
> > We should add getJobDetails - which returns SchedulerJobInfo.
Makes sense. Will add.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 1
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138731#file1138731line1>
> >
> > file name as job-0.1.xsd seems very generic. We should have it as schedule-0.1.xsd or schedule-job-0.1.xsd
I will rename it to scheduler-job-0.1.xsd (on lines of SchedulerJobInfo, unless that also changes, see below)
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 56
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138728#file1138728line56>
> >
> > Instead of RuntimeException, can they defined as LensException or LensAPIException with error codes added?
Makes sense, will add.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 32
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138728#file1138728line32>
> >
> > Can you add comments on what each method is for here? Since this goes in lens-api, i'm thinking you are planning to use all these on client side.
> >
> > If validation happens server side, we should move the class to lens-server-api
I will add comments.
Validations will happen on server side but since these classes are referred by jaxb, they need to be accessible in lens-api.
> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java, line 70
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138734#file1138734line70>
> >
> > Instead of simple String for jobID, Should we have a pojo similar to QueryHandle ?
Will look at it, thanks for the suggestion.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
-----------------------------------------------------------
On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 12:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/job-0.1.xsd PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 32)
<https://reviews.apache.org/r/40638/#comment167254>
Can you add comments on what each method is for here? Since this goes in lens-api, i'm thinking you are planning to use all these on client side.
If validation happens server side, we should move the class to lens-server-api
lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 56)
<https://reviews.apache.org/r/40638/#comment167255>
Instead of RuntimeException, can they defined as LensException or LensAPIException with error codes added?
lens-api/src/main/resources/example-job.xml (line 43)
<https://reviews.apache.org/r/40638/#comment167256>
start_time says it is starting from 2014, but cron says run in 2005. We should change this to be a different year - something between start and end
lens-api/src/main/resources/job-0.1.xsd (line 1)
<https://reviews.apache.org/r/40638/#comment167265>
file name as job-0.1.xsd seems very generic. We should have it as schedule-0.1.xsd or schedule-job-0.1.xsd
lens-api/src/main/resources/job-0.1.xsd (line 35)
<https://reviews.apache.org/r/40638/#comment167267>
Please add <xs:annotation><xs:documentation> for all elements and attributes.
See cube-0.1.xsd, for example.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java (line 32)
<https://reviews.apache.org/r/40638/#comment167268>
I would say lets have class name as SchedulerService for interface and SchedulerServiceImpl for implementation to be consistent with other classes.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java (line 67)
<https://reviews.apache.org/r/40638/#comment167271>
Please explain return value for all methods
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java (line 70)
<https://reviews.apache.org/r/40638/#comment167269>
Instead of simple String for jobID, Should we have a pojo similar to QueryHandle ?
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java (line 71)
<https://reviews.apache.org/r/40638/#comment167273>
We should add getJobDetails - which returns SchedulerJobInfo.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java (line 134)
<https://reviews.apache.org/r/40638/#comment167270>
why is getAllJobStats taking jobId?
Also lets add state, user, name, long fromDate and toDate as other filters for getAllJobStats. You can look at getAllQueries in QueryExecutionService
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java (line 31)
<https://reviews.apache.org/r/40638/#comment167274>
Shall we name the class ScheduleJobInfo instead of SchedulerJobInfo ?
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java (line 75)
<https://reviews.apache.org/r/40638/#comment167276>
Please add comments to all params in all classes
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java (line 29)
<https://reviews.apache.org/r/40638/#comment167275>
ScheduleJobInstanceInfo?
- Amareshwari Sriramadasu
On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 12:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/job-0.1.xsd PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Ajay Yadava <aj...@gmail.com>.
> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 26
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138730#file1138730line26>
> >
> > remove semicolon. And we should give cube queries in examples.
Will fix.
> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 32
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138728#file1138728line32>
> >
> > We already have a class with this name in lens-cube module. Maybe we can re-think on the name?
As long as these are in different packages it should be fine.
> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 22
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138730#file1138730line22>
> >
> > Maybe this can be in lens-examples module
Will move.
> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java, line 31
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138735#file1138735line31>
> >
> > What are intended usages of this class? I couldn't find any.
This was slightly future looking. Amareshwari has also pointed a use case for the same.
> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java, line 28
> > <https://reviews.apache.org/r/40638/diff/1/?file=1138736#file1138736line28>
> >
> > see https://projectlombok.org/features/Data.html
Will fix.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107770
-----------------------------------------------------------
On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 12:20 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/job-0.1.xsd PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 40638: Base framework for scheduler.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107770
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 32)
<https://reviews.apache.org/r/40638/#comment167057>
We already have a class with this name in lens-cube module. Maybe we can re-think on the name?
lens-api/src/main/resources/example-job.xml (line 22)
<https://reviews.apache.org/r/40638/#comment167059>
Maybe this can be in lens-examples module
lens-api/src/main/resources/example-job.xml (line 26)
<https://reviews.apache.org/r/40638/#comment167058>
remove semicolon. And we should give cube queries in examples.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java (line 31)
<https://reviews.apache.org/r/40638/#comment167061>
What are intended usages of this class? I couldn't find any.
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java (line 28)
<https://reviews.apache.org/r/40638/#comment167060>
see https://projectlombok.org/features/Data.html
- Rajat Khandelwal
On Nov. 24, 2015, 5:50 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 5:50 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
>
>
> Repository: lens
>
>
> Description
> -------
>
> Base framework for lens scheduler service and job definition.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java PRE-CREATION
> lens-api/src/main/resources/example-job.xml PRE-CREATION
> lens-api/src/main/resources/job-0.1.xsd PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java 9f48d27
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 3389aba
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 24949bd
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java PRE-CREATION
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java e11413e
> pom.xml b19857f
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/40638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ajay Yadava
>
>