[GitHub] [cloudstack] shwstppr commented on a change in pull request #4167: Adding missing fields to API responses

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #4167:
URL: https://github.com/apache/cloudstack/pull/4167#discussion_r444689109



##########
File path: api/src/main/java/org/apache/cloudstack/api/response/DomainRouterResponse.java
##########
@@ -145,6 +149,10 @@
     @Param(description = "the template ID for the router")
     private String templateId;
 
+    @SerializedName(ApiConstants.TEMPLATE_NAME)

Review comment:
       same as above

##########
File path: api/src/main/java/org/apache/cloudstack/api/response/DomainRouterResponse.java
##########
@@ -77,6 +77,10 @@
     @Param(description = "the Pod ID for the router")
     private String podId;
 
+    @SerializedName(ApiConstants.POD_NAME)
+    @Param(description = "the Pod name for the router")

Review comment:
       @davidjumani can we have `since` key here

##########
File path: api/src/main/java/org/apache/cloudstack/api/response/PrivateGatewayResponse.java
##########
@@ -58,9 +58,13 @@
     private String broadcastUri;
 
     @SerializedName(ApiConstants.VPC_ID)
-    @Param(description = "VPC the private gateaway belongs to")
+    @Param(description = "VPC id the private gateway belongs to")
     private String vpcId;
 
+    @SerializedName(ApiConstants.VPC_NAME)

Review comment:
       `since` key

##########
File path: api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##########
@@ -136,8 +136,13 @@
     private String purpose;
 
     @SerializedName(ApiConstants.VPC_ID)
-    @Param(description = "VPC the ip belongs to")
+    @Param(description = "VPC id the ip belongs to")
     private String vpcId;
+
+    @SerializedName(ApiConstants.VPC_NAME)

Review comment:
       `since` key




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org