You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/26 05:46:42 UTC
[GitHub] [commons-cli] arturobernalg opened a new pull request #61: Minor Improvements:
arturobernalg opened a new pull request #61:
URL: https://github.com/apache/commons-cli/pull/61
* Use empty array
* Simplify conditions
* Inline variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] coveralls edited a comment on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-807955880
[](https://coveralls.io/builds/43292721)
Coverage increased (+0.003%) to 95.973% when pulling **2b48d1da6d97ecf7ba5beb9e88cc4318d408552e on arturobernalg:feature/minor_performances** into **d63b4bd3e61e83b6dbe7b3d6f81a06967f17e784 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] coveralls edited a comment on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-807955880
[](https://coveralls.io/builds/43300561)
Coverage increased (+0.003%) to 95.973% when pulling **08bc73b9708e9132b59337747c0251783ea4bf19 on arturobernalg:feature/minor_performances** into **d63b4bd3e61e83b6dbe7b3d6f81a06967f17e784 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory merged pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #61:
URL: https://github.com/apache/commons-cli/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] arturobernalg commented on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-934544597
> @arturobernalg
> Sorry, lots of changes recently, may you please rebase on master if you are still interested?
HI @garydgregory
Rebased
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] arturobernalg commented on a change in pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#discussion_r722888091
##########
File path: src/main/java/org/apache/commons/cli/Util.java
##########
@@ -21,6 +21,12 @@ Licensed to the Apache Software Foundation (ASF) under one or more
* Contains useful helper methods for classes within this package.
*/
final class Util {
+
+ /**
+ * An empty immutable {@code String} array.
+ */
+ public static final String[] EMPTY_STRING_ARRAY = new String[0];
Review comment:
HI @garydgregory
Changed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-933707964
@arturobernalg
Sorry, lots of changes recently, may you please rebase on master if you are still interested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] coveralls commented on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-807955880
[](https://coveralls.io/builds/38272943)
Coverage decreased (-0.01%) to 96.346% when pulling **1c8c1caf2615180e544ed6e091c49e721bc9e729 on arturobernalg:feature/minor_performances** into **621edeae1df1ea62b84b0d420ff73c8fc6902d9d on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] arturobernalg commented on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-934700389
> Hi @arturobernalg
> The builds are failing.
Hi @garydgregory
Solved.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#issuecomment-934629230
Hi @arturobernalg
The builds are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-cli] garydgregory commented on a change in pull request #61: Minor Improvements:
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #61:
URL: https://github.com/apache/commons-cli/pull/61#discussion_r722715047
##########
File path: src/main/java/org/apache/commons/cli/Util.java
##########
@@ -21,6 +21,12 @@ Licensed to the Apache Software Foundation (ASF) under one or more
* Contains useful helper methods for classes within this package.
*/
final class Util {
+
+ /**
+ * An empty immutable {@code String} array.
+ */
+ public static final String[] EMPTY_STRING_ARRAY = new String[0];
Review comment:
@arturobernalg
Please let this be package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org