You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/12 10:23:06 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1213:
[MAJOR] Move old docs to docs-old folder
lamber-ken opened a new pull request #1213: [MAJOR] Move old docs to docs-old folder
URL: https://github.com/apache/incubator-hudi/pull/1213
## What is the purpose of the pull request
1, It's better remove the whole old docs after the new site content has been published for a while.
2, **Next step**: In the next week, generate new site content && replace the old site content.
## Brief change log
- Move `docs` to `docs-old` folder.
## Verify this pull request
This pull request is code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1213: [MAJOR] Move
old docs to docs-old folder
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1213: [MAJOR] Move old docs to docs-old folder
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573490717
> * regeneration
Okay, got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1213: [MAJOR]
Move old docs to docs-old folder
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1213: [MAJOR] Move old docs to docs-old folder
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573489140
@lamber-ken thanks for that explanation. Really helps.
I suggest we avoid the whole `docs-old` stages (3,4,5). if we want the old docs back, we can get from the git history anyway. .. I suggest, then just
- Removing the current `docs` (and all content underneath)
- Move `docs-new` to `docs`
- Replace `content` with a regeneration of new site.
in this PR itself.. It will avoid some intermediate steps..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1213: [MAJOR]
Remove docs && move docs-new to docs
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1213: [MAJOR] Remove docs && move docs-new to docs
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573503139
@lamber-ken so, one final push hopefully.. and we should be home..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1213: [MAJOR] Move
old docs to docs-old folder
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1213: [MAJOR] Move old docs to docs-old folder
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573484842
> @lamber-ken just ensuring this change is the new docs. [6433e14](https://github.com/apache/incubator-hudi/commit/6433e14bcd6e8036bdeeba9a2e8af273589511e9)
Sure, already sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1213: [MAJOR]
Remove docs && move docs-new to docs
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1213: [MAJOR] Remove docs && move docs-new to docs
URL: https://github.com/apache/incubator-hudi/pull/1213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1213: [MAJOR]
Remove docs && move docs-new to docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1213: [MAJOR] Remove docs && move docs-new to docs
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573507810
> @lamber-ken so, one final push hopefully.. and we should be home..
Right, 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1213: [MAJOR]
Remove docs && move docs-new to docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1213: [MAJOR] Remove docs && move docs-new to docs
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573493974
Hi @vinothchandar, follow your advice.
This pr contains:
- Remove `docs`
- Move `docs-new` to `docs`
Next step:
Generate site && replace content with `_site`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1213: [MAJOR] Move
old docs to docs-old folder
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1213: [MAJOR] Move old docs to docs-old folder
URL: https://github.com/apache/incubator-hudi/pull/1213#issuecomment-573485164
> @lamber-ken should n't we remove https://github.com/apache/incubator-hudi/tree/asf-site/docs/newsite-content ? why do we have generated html under `docs` now? Give we have git/version control anyway... I am wondering if we should just remove docs and replace it with new `docs-new`.. next step can be to republish the site content with the new site alone (remove the cross references/banners etc)
>
> I pointed out one commit that I am not sure is in the new site.
Thanks for you review, let me make a detailed explanation, it's not a easy job to support old site and new site at one domain, it needs some smart tricks to generate newsite-content.
**1, Generate site with newsite-content**
**2, Clean plan**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services