You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/29 22:54:52 UTC
[GitHub] [maven] jmax01 opened a new pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
jmax01 opened a new pull request #422:
URL: https://github.com/apache/maven/pull/422
https://issues.apache.org/jira/browse/MNG-6727
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549934255
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
I believe I have handled both cases and properly updated the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on pull request #422:
URL: https://github.com/apache/maven/pull/422#issuecomment-755527958
> Some thing is wrong with this PR.
Yeah I am going to kill it and recreate it. I don't get why it it fails the ITS on java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549882027
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
Should be and I should have committed the test fix the dang test (which I am doing now) sorry!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549880766
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
Shouldn't it be equals?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 closed pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 closed pull request #422:
URL: https://github.com/apache/maven/pull/422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549891345
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
Update: So the funny thing is the thing we are trying to avoid by checking the version for property replacement *doesn't* work in the test with the most likely case one would see in the wild (which is why I *can't* get the test to throw properly).
When the test is actually executed with the below pom the `childModel.getVersion()` returns `1` not `${project.version}`.
```
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>[1,1]</version>
</parent>
<artifactId>child</artifactId>
<!-- Must not be project.version from parent due to version range. -->
<version>${project.version}</version>
<packaging>pom</packaging>
</project>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549891345
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
Update: So the funny thing is the thing we are trying to avoid by checking the version for property replacement *doesn't* work in the test with the most likely case one would see in the wild (which is why I *can't* get the test to throw properly).
When the test is actually executed with the below pom the `childModel.getVersion()` returns `1` not `${project.version}`.
```
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>[1,1]</version>
</parent>
<artifactId>child</artifactId>
<!-- Must not be project.version from parent due to version range. -->
<version>${project.version}</version>
<packaging>pom</packaging>
</project>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #422:
URL: https://github.com/apache/maven/pull/422#issuecomment-755480478
Some thing is wrong with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] jmax01 commented on a change in pull request #422: MNG-6727 Check for ${project.version} not ${ when parent has a version range
Posted by GitBox <gi...@apache.org>.
jmax01 commented on a change in pull request #422:
URL: https://github.com/apache/maven/pull/422#discussion_r549891345
##########
File path: maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1200,7 +1200,7 @@ public ModelSource getModelSource()
}
else
{
- if ( childModel.getVersion().contains( "${" ) )
+ if ( childModel.getVersion().contains( "${project.version}" ) )
Review comment:
Update: So the funny thing is the thing we are trying to avoid by checking the version for property replacement *doesn't* work with the most likely case one would see in the wild (which is why I *can't* get the test to throw properly).
When the test is actually executed with the below pom the `childModel.getVersion()` returns `1` not `${project.version}`!
```
<project>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>[1,1]</version>
</parent>
<artifactId>child</artifactId>
<!-- Must not be project.version from parent due to version range. -->
<version>${project.version}</version>
<packaging>pom</packaging>
</project>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org