You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/03/03 11:30:43 UTC

Review Request 31674: LENS-308 Issue while getting persistent result of finished JDBC query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31674/
-----------------------------------------------------------

Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-308
    https://issues.apache.org/jira/browse/LENS-308


Repository: lens


Description
-------

make jdbc result set deserializable for jackson


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 5cf282e9ab044928bdc50e65358c804a83519151 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 89c408416c6dca92121dccd459e09631697ace19 

Diff: https://reviews.apache.org/r/31674/diff/


Testing
-------

Changed TestLendDAO to validate serialization and deserialization of JDBC result set into finished query.


Thanks,

Jaideep dhok


Re: Review Request 31674: LENS-308 Issue while getting persistent result of finished JDBC query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31674/#review75158
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On March 3, 2015, 10:51 a.m., Jaideep dhok wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31674/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 10:51 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-308
>     https://issues.apache.org/jira/browse/LENS-308
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> make jdbc result set deserializable for jackson
> 
> 
> Diffs
> -----
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 5cf282e9ab044928bdc50e65358c804a83519151 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 89c408416c6dca92121dccd459e09631697ace19 
> 
> Diff: https://reviews.apache.org/r/31674/diff/
> 
> 
> Testing
> -------
> 
> Changed TestLendDAO to validate serialization and deserialization of JDBC result set into finished query.
> 
> Test output
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.175s]
> [INFO] Lens .............................................. SUCCESS [1.881s]
> [INFO] Lens API .......................................... SUCCESS [5.363s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.374s]
> [INFO] Lens Cube ......................................... SUCCESS [6:25.262s]
> [INFO] Lens DB storage ................................... SUCCESS [9.849s]
> [INFO] Lens Query Library ................................ SUCCESS [4.963s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.894s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [24.938s]
> [INFO] Lens Server ....................................... SUCCESS [4:35.175s]
> [INFO] Lens client ....................................... SUCCESS [20.819s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.425s]
> [INFO] Lens Examples ..................................... SUCCESS [0.911s]
> [INFO] Lens Distribution ................................. SUCCESS [10.763s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.026s]
> [INFO] Lens Regression ................................... SUCCESS [0.626s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:37.381s
> [INFO] Finished at: Tue Mar 03 10:47:16 UTC 2015
> [INFO] Final Memory: 110M/1253M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jaideep dhok
> 
>


Re: Review Request 31674: LENS-308 Issue while getting persistent result of finished JDBC query

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31674/
-----------------------------------------------------------

(Updated March 3, 2015, 10:51 a.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-308
    https://issues.apache.org/jira/browse/LENS-308


Repository: lens


Description
-------

make jdbc result set deserializable for jackson


Diffs
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 5cf282e9ab044928bdc50e65358c804a83519151 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 89c408416c6dca92121dccd459e09631697ace19 

Diff: https://reviews.apache.org/r/31674/diff/


Testing (updated)
-------

Changed TestLendDAO to validate serialization and deserialization of JDBC result set into finished query.

Test output

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.175s]
[INFO] Lens .............................................. SUCCESS [1.881s]
[INFO] Lens API .......................................... SUCCESS [5.363s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.374s]
[INFO] Lens Cube ......................................... SUCCESS [6:25.262s]
[INFO] Lens DB storage ................................... SUCCESS [9.849s]
[INFO] Lens Query Library ................................ SUCCESS [4.963s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.894s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.938s]
[INFO] Lens Server ....................................... SUCCESS [4:35.175s]
[INFO] Lens client ....................................... SUCCESS [20.819s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.425s]
[INFO] Lens Examples ..................................... SUCCESS [0.911s]
[INFO] Lens Distribution ................................. SUCCESS [10.763s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.026s]
[INFO] Lens Regression ................................... SUCCESS [0.626s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:37.381s
[INFO] Finished at: Tue Mar 03 10:47:16 UTC 2015
[INFO] Final Memory: 110M/1253M
[INFO] ------------------------------------------------------------------------


Thanks,

Jaideep dhok