[GitHub] [nuttx] lupyuen commented on pull request #10193: Draft: Pinephone Pro Port

["lupyuen (via GitHub)" <gi...@apache.org>]

lupyuen commented on PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#issuecomment-1675654794

   Hi @annerajb: Thank you so much for porting NuttX to PinePhone Pro! As Alan mentioned, we need to tidy up the code, here are some tips...
   
   I wrote a guide on submitting a NuttX PR, it might be helpful:
   
   - ["Preparing a Pull Request for Apache NuttX RTOS"](https://lupyuen.github.io/articles/pr)
   
   To support PinePhone Pro we'll need to add a new NuttX Arch (SoC) and NuttX Board:
   
   - NuttX Arch: arch/arm64/src/rk3399
   
   - NuttX Board: boards/arm64/rk3399/pinephonepro
   
   The steps are explained here:
   
   -  ["Add the NuttX Arch and Board"](https://lupyuen.github.io/articles/release#add-the-nuttx-arch-and-board)
   
   But that's for RISC-V. For Arm64 we can follow this PR (but probably better to split into one PR for Arch and another PR for Board):
   
   -  ["arch/arm64: Add support for PINE64 PinePhone"](https://github.com/apache/nuttx/pull/7692)
   
   We might be able to reuse the NuttX 16550 UART Driver:
   
   - ["Star64 JH7110 + NuttX RTOS: RISC-V PLIC Interrupts and Serial I/O"](https://lupyuen.github.io/articles/plic)
   
   Remember to enable [16550_WAIT_LCR](https://lupyuen.github.io/articles/plic#appendix-fix-the-spurious-uart-interrupts). And set [16550_REGINCR](https://lupyuen.github.io/articles/privilege#uart-registers-are-spaced-differently) to 4. (I think)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org