You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/30 02:15:04 UTC
Review Request: Added double-checked locking when using the paused clock,
made sure that processes clocks advanced when events arrived even if they
had no sender, did some minor refactorings for delivering events,
and changed some logging levels.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5262/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Summary
-------
See summary.
Diffs
-----
third_party/libprocess/include/process/clock.hpp 9480952
third_party/libprocess/src/process.cpp 13bb713
Diff: https://reviews.apache.org/r/5262/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Added double-checked locking when using the paused clock,
made sure that processes clocks advanced when events arrived even if they
had no sender, did some minor refactorings for delivering events,
and changed some logging levels.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5262/#review8276
-----------------------------------------------------------
lgtm..though i dont completely understand the libprocess internals. i will let john take a look too, before giving a shipit
third_party/libprocess/include/process/clock.hpp
<https://reviews.apache.org/r/5262/#comment17905>
sweet
- Vinod
On 2012-05-31 19:10:59, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5262/
> -----------------------------------------------------------
>
> (Updated 2012-05-31 19:10:59)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/clock.hpp 9480952
> third_party/libprocess/src/process.cpp 13bb713
>
> Diff: https://reviews.apache.org/r/5262/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Added double-checked locking when using the paused clock,
made sure that processes clocks advanced when events arrived even if they
had no sender, did some minor refactorings for delivering events,
and changed some logging levels.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5262/
-----------------------------------------------------------
(Updated 2012-05-31 19:10:59.363545)
Review request for mesos, John Sirois and Vinod Kone.
Changes
-------
Added Vinod as a reviewer.
Summary
-------
See summary.
Diffs
-----
third_party/libprocess/include/process/clock.hpp 9480952
third_party/libprocess/src/process.cpp 13bb713
Diff: https://reviews.apache.org/r/5262/diff
Testing
-------
make check
Thanks,
Benjamin