You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/24 02:48:40 UTC
[GitHub] [skywalking] HendSame opened a new pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
HendSame opened a new pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194
### <Feature description>
- As we know, it supports configure `sampling rate` and `trace latency` on the backend side, but it is global.
- Can I configure sampling rate dynamically follow every service or instance or interface latitude in some cases when I only want to see the exception trace, or the trace that has cost a very long time? But I do not want to configure the global `sampling rate` and `trace latency`, by reason of the storage layer cannot support large data load.
- We can configure in a yaml:
```
services:
- name: serverName # the server name which show skywalking-ui
instances:
- name: hostName@127.0.0.1 # the server instance which show skywalking-ui
sampleRate: 900 # instance latitude
duration: 10000 # trace latency time
endpoints:
- name: '/url' # the endpoint
sampleRate: 800
duration: 10000 # trace latency time
sampleRate: 1000 # endpoint latitude
duration: 10000 # trace latency time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `1.47%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 57.55% -1.48%
+ Complexity 4342 4285 -57
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15187 -310
- Misses 9389 9840 +451
+ Partials 1370 1361 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **increase** coverage by `1.76%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 53.57% 55.34% +1.76%
+ Complexity 4301 4157 -144
============================================
Files 1887 1025 -862
Lines 40730 26308 -14422
Branches 4572 2620 -1952
============================================
- Hits 21820 14559 -7261
+ Misses 17836 10464 -7372
- Partials 1074 1285 +211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1344 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-873760663
> The boundary between `custom-trace-sample-rate` and existing `sampleRate` is not clear. If you want to do service based sample rate setting, the first step should make it supported in static configuration. Sample rate is a static configuration in the `application.yml`, you should make it separate in another `trace-sample-rate-setting.yml`, then, make the dynamic configuration works. Also, this should not be a different configuration than existing logic, otherwise, the users would be very confused, which sample rate would take effect if they set both.
Like that configure sampling rate by the same configuration in the `application.yml`?
```
agent-analyzer:
selector: ${SW_AGENT_ANALYZER:default}
default:
#sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.sampleRate' that the config in 'traceSampleRateSettingFile'.
#slowTraceSegmentThreshold: ${SW_SLOW_TRACE_SEGMENT_THRESHOLD:-1} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.duration' that the config in 'traceSampleRateSettingFile'.
traceSampleRateSettingFile: ${SW_TRACE_SAMPLE_RATE_SETTING_FILE:trace-sample-rate-setting.yml}
```
And `trace-sample-rate-setting.yml`:
```
global:
sampleRate: 10000 # the replace the old config `sampleRate` in the application.yml.
duration: 10000 # the replace the old config `slowTraceSegmentThreshold` in the application.yml
services:
- name: serverName # the server name which show skywalking-ui
sampleRate: 1000 # endpoint latitude. It has a higher priority than `global.sampleRate`
duration: 10000 # trace latency time. It has a higher priority than `global.duration`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.86%`.
> The diff coverage is `52.32%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.21% +5.86%
- Complexity 2692 4180 +1488
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14807 +5609
- Misses 8337 10209 +1872
- Partials 730 1322 +592
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-873762187
> # the server name which show skywalking-ui
Notice, this is not a correct comment for the service name. Service has been defined clearly in the document, you don't need to mention it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `7.42%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 51.59% -7.43%
+ Complexity 4342 3219 -1123
============================================
Files 1020 862 -158
Lines 26256 22409 -3847
Branches 2600 2162 -438
============================================
- Hits 15497 11562 -3935
- Misses 9389 9886 +497
+ Partials 1370 961 -409
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [269 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.42%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.78% +7.42%
- Complexity 2692 4290 +1598
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15253 +6055
- Misses 8337 9814 +1477
- Partials 730 1330 +600
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.42%`.
> The diff coverage is `52.22%`.
> :exclamation: Current head 84b40b3 differs from pull request most recent head 8d1aa72. Consider uploading reports for the commit 8d1aa72 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.78% +7.42%
- Complexity 2692 4290 +1598
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15253 +6055
- Misses 8337 9814 +1477
- Partials 730 1330 +600
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.55%`.
> The diff coverage is `52.32%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.91% +5.55%
- Complexity 2692 4157 +1465
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14726 +5528
- Misses 8337 10292 +1955
- Partials 730 1320 +590
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `1.97%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 48.38% -1.98%
- Complexity 2692 3079 +387
============================================
Files 740 866 +126
Lines 18265 22451 +4186
Branches 1766 2159 +393
============================================
+ Hits 9198 10862 +1664
- Misses 8337 10713 +2376
- Partials 730 876 +146
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <14.28%> (-17.87%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [780 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.00%`.
> The diff coverage is `51.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.36% +5.00%
- Complexity 2692 4123 +1431
============================================
Files 740 1022 +282
Lines 18265 26257 +7992
Branches 1766 2596 +830
============================================
+ Hits 9198 14538 +5340
- Misses 8337 10454 +2117
- Partials 730 1265 +535
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `39.09% <0.00%> (-1.48%)` | :arrow_down: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870204884
2 arguments about this kind of changes.
1. Instance is up and down, with scaling. The name of instance could/should change from time to time, especially in today's k8s deployment. I can't see the point of set sampling for a single instance.
2. About endpoint, a.k.a. your interface. This would be a huge number of sampling, and as this sampler has to keep the seed for every endpoint(URI), if URI is parameterized, your OAP will be OOM eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `27.69%`.
> The diff coverage is `37.16%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.55% 25.86% -27.70%
+ Complexity 4298 1696 -2602
=============================================
Files 1887 833 -1054
Lines 40730 20839 -19891
Branches 4572 1975 -2597
=============================================
- Hits 21813 5389 -16424
+ Misses 17842 15042 -2800
+ Partials 1075 408 -667
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `7.69% <5.88%> (-67.31%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `52.27% <52.27%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `18.07% <75.00%> (-56.05%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1578 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `8.07%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 58.43% +8.07%
- Complexity 2692 4316 +1624
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15409 +6211
- Misses 8337 9578 +1241
- Partials 730 1381 +651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb69b3c) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `10.32%`.
> The diff coverage is `42.47%`.
> :exclamation: Current head fb69b3c differs from pull request most recent head 6d19040. Consider uploading reports for the commit 6d19040 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.57% 43.24% -10.33%
+ Complexity 4301 2760 -1541
=============================================
Files 1887 865 -1022
Lines 40730 22181 -18549
Branches 4572 2153 -2419
=============================================
- Hits 21820 9593 -12227
+ Misses 17836 11821 -6015
+ Partials 1074 767 -307
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1480 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.39%`.
> The diff coverage is `52.24%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.75% +5.39%
- Complexity 2692 4150 +1458
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14685 +5487
- Misses 8337 10344 +2007
- Partials 730 1309 +579
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `8.37%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 41.98% -8.38%
+ Complexity 2692 2608 -84
============================================
Files 740 835 +95
Lines 18265 21330 +3065
Branches 1766 2050 +284
============================================
- Hits 9198 8956 -242
- Misses 8337 11642 +3305
- Partials 730 732 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <14.28%> (-17.87%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [796 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `4.27%`.
> The diff coverage is `52.24%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 54.63% +4.27%
- Complexity 2692 4110 +1418
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14389 +5191
- Misses 8337 10669 +2332
- Partials 730 1280 +550
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `18.58%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 31.77% -18.59%
+ Complexity 2692 2016 -676
=============================================
Files 740 835 +95
Lines 18265 21140 +2875
Branches 1766 2017 +251
=============================================
- Hits 9198 6717 -2481
- Misses 8337 13908 +5571
+ Partials 730 515 -215
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [796 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.17%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.52% +7.17%
- Complexity 2692 4282 +1590
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15186 +5988
- Misses 8337 9898 +1561
- Partials 730 1313 +583
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `0.15%`.
> The diff coverage is `32.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 50.20% -0.16%
- Complexity 2692 3180 +488
============================================
Files 740 866 +126
Lines 18265 22464 +4199
Branches 1766 2163 +397
============================================
+ Hits 9198 11278 +2080
- Misses 8337 10285 +1948
- Partials 730 901 +171
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [773 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `1.90%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.56% 51.65% -1.91%
+ Complexity 4298 3238 -1060
============================================
Files 1887 865 -1022
Lines 40730 22402 -18328
Branches 4572 2170 -2402
============================================
- Hits 21815 11572 -10243
+ Misses 17841 9894 -7947
+ Partials 1074 936 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1427 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.85%`.
> The diff coverage is `53.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.21% +6.85%
- Complexity 2692 4270 +1578
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 15076 +5878
- Misses 8337 9936 +1599
- Partials 730 1338 +608
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `0.90%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 58.11% -0.91%
+ Complexity 4342 4316 -26
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15335 -162
- Misses 9389 9660 +271
- Partials 1370 1393 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `5.76% <0.00%> (-63.47%)` | :arrow_down: |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `3.70%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 55.31% -3.71%
+ Complexity 4342 4153 -189
============================================
Files 1020 1022 +2
Lines 26256 26341 +85
Branches 2600 2613 +13
============================================
- Hits 15497 14571 -926
- Misses 9389 10464 +1075
+ Partials 1370 1306 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on a change in pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on a change in pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#discussion_r663617240
##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/AnalyzerModuleProvider.java
##########
@@ -111,18 +117,18 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
public void start() throws ModuleStartException {
// load official analysis
getManager().find(CoreModule.NAME)
- .provider()
- .getService(OALEngineLoaderService.class)
- .load(CoreOALDefine.INSTANCE);
+ .provider()
+ .getService(OALEngineLoaderService.class)
+ .load(CoreOALDefine.INSTANCE);
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `5.04%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.56% 48.51% -5.05%
+ Complexity 4298 3112 -1186
============================================
Files 1887 865 -1022
Lines 40730 22392 -18338
Branches 4572 2169 -2403
============================================
- Hits 21815 10864 -10951
+ Misses 17841 10670 -7171
+ Partials 1074 858 -216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1436 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870204884
2 arguments about this kind of changes.
1. Instance is up and down, with scaling. The name of instance could/should change from time to time, especially in today's k8s deployment. I can't see the point of set sampling for a single instance.
2. About endpoint, a.k.a. your interface. This would be a huge number of sampling, and as this sampler has to keep the seed for every endpoint(URI), if URI is parameterized, your OAP will be OOM eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `1.93%`.
> The diff coverage is `32.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 52.29% +1.93%
- Complexity 2692 3280 +588
============================================
Files 740 866 +126
Lines 18265 22464 +4199
Branches 1766 2163 +397
============================================
+ Hits 9198 11748 +2550
- Misses 8337 9762 +1425
- Partials 730 954 +224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [775 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.48%`.
> The diff coverage is `53.78%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.84% +6.48%
- Complexity 2692 4240 +1548
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14977 +5779
- Misses 8337 10046 +1709
- Partials 730 1325 +595
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [852 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `8.38%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.56% 45.17% -8.39%
+ Complexity 4298 2932 -1366
============================================
Files 1887 865 -1022
Lines 40730 22353 -18377
Branches 4572 2168 -2404
============================================
- Hits 21815 10097 -11718
+ Misses 17841 11438 -6403
+ Partials 1074 818 -256
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1454 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.33%`.
> The diff coverage is `52.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.69% +6.33%
- Complexity 2692 4207 +1515
============================================
Files 740 1023 +283
Lines 18265 26304 +8039
Branches 1766 2604 +838
============================================
+ Hits 9198 14914 +5716
- Misses 8337 10097 +1760
- Partials 730 1293 +563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-904278103
No update?
![image](https://user-images.githubusercontent.com/9264192/130547623-ad939eff-a2f5-4209-a36c-77245367f2c8.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `8.30%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 58.66% +8.30%
- Complexity 2692 4332 +1640
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15468 +6270
- Misses 8337 9517 +1180
- Partials 730 1383 +653
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.87%`.
> The diff coverage is `53.94%`.
> :exclamation: Current head 8d1aa72 differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.23% +6.87%
- Complexity 2692 4271 +1579
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 15082 +5884
- Misses 8337 9929 +1592
- Partials 730 1339 +609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.61%`.
> The diff coverage is `53.90%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.97% +6.61%
- Complexity 2692 4245 +1553
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15024 +5826
- Misses 8337 10014 +1677
- Partials 730 1330 +600
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `1.36%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 57.65% -1.37%
+ Complexity 4342 4289 -53
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15214 -283
- Misses 9389 9808 +419
+ Partials 1370 1366 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| ... and [50 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.55%`.
> The diff coverage is `53.78%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.91% +6.55%
- Complexity 2692 4246 +1554
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 14998 +5800
- Misses 8337 10023 +1686
- Partials 730 1329 +599
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [852 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `1.32%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 57.70% -1.33%
+ Complexity 4342 4290 -52
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15226 -271
- Misses 9389 9795 +406
+ Partials 1370 1367 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb69b3c) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `8.06%`.
> The diff coverage is `42.47%`.
> :exclamation: Current head fb69b3c differs from pull request most recent head 6d19040. Consider uploading reports for the commit 6d19040 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.57% 45.51% -8.07%
+ Complexity 4301 2855 -1446
============================================
Files 1887 865 -1022
Lines 40730 22181 -18549
Branches 4572 2153 -2419
============================================
- Hits 21820 10095 -11725
+ Misses 17836 11256 -6580
+ Partials 1074 830 -244
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-904710584
@wu-sheng I have created a new PR #7554 that is base on 8.8.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **increase** coverage by `0.96%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 53.56% 54.52% +0.96%
+ Complexity 4298 4118 -180
============================================
Files 1887 1025 -862
Lines 40730 26308 -14422
Branches 4572 2620 -1952
============================================
- Hits 21815 14344 -7471
+ Misses 17841 10709 -7132
- Partials 1074 1255 +181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.85%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.21% +6.85%
- Complexity 2692 4262 +1570
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15102 +5904
- Misses 8337 9991 +1654
- Partials 730 1304 +574
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-872723076
> Service level dynamic sampling makes sense to me.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `0.92%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 58.09% -0.93%
+ Complexity 4342 4313 -29
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15330 -167
- Misses 9389 9665 +276
- Partials 1370 1393 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.55%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.91% +5.55%
- Complexity 2692 4200 +1508
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14732 +5534
- Misses 8337 10309 +1972
- Partials 730 1307 +577
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `4.92%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.28% +4.92%
- Complexity 2692 4172 +1480
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14566 +5368
- Misses 8337 10503 +2166
- Partials 730 1279 +549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `10.12%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 48.89% -10.13%
+ Complexity 4342 2986 -1356
=============================================
Files 1020 831 -189
Lines 26256 21431 -4825
Branches 2600 2067 -533
=============================================
- Hits 15497 10479 -5018
- Misses 9389 10090 +701
+ Partials 1370 862 -508
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] GerryYuan commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
GerryYuan commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-875314473
> > The boundary between `custom-trace-sample-rate` and existing `sampleRate` is not clear. If you want to do service based sample rate setting, the first step should make it supported in static configuration. Sample rate is a static configuration in the `application.yml`, you should make it separate in another `trace-sample-rate-setting.yml`, then, make the dynamic configuration works. Also, this should not be a different configuration than existing logic, otherwise, the users would be very confused, which sample rate would take effect if they set both.
>
> Like that configure sampling rate by the same configuration in the `application.yml`?
>
> ```
> agent-analyzer:
> selector: ${SW_AGENT_ANALYZER:default}
> default:
> #sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.sampleRate' that the config in 'traceSampleRateSettingFile'.
> #slowTraceSegmentThreshold: ${SW_SLOW_TRACE_SEGMENT_THRESHOLD:-1} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.duration' that the config in 'traceSampleRateSettingFile'.
> traceSampleRateSettingFile: ${SW_TRACE_SAMPLE_RATE_SETTING_FILE:trace-sample-rate-setting.yml}
> ```
>
> And `trace-sample-rate-setting.yml`:
>
> ```
> global:
> sampleRate: 10000 # the replace the old config `sampleRate` in the application.yml.
> duration: 10000 # the replace the old config `slowTraceSegmentThreshold` in the application.yml
> services:
> - name: serverName # the server name which show skywalking-ui
> sampleRate: 1000 # endpoint latitude. It has a higher priority than `global.sampleRate`
> duration: 10000 # trace latency time. It has a higher priority than `global.duration`
> ```
Support different endpoint sampling rate settings? In many cases, the call volume of the core interface is relatively large
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.33%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.69% +7.33%
- Complexity 2692 4276 +1584
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15213 +6015
- Misses 8337 9791 +1454
- Partials 730 1364 +634
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb69b3c) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `8.22%`.
> The diff coverage is `42.47%`.
> :exclamation: Current head fb69b3c differs from pull request most recent head 6d19040. Consider uploading reports for the commit 6d19040 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.57% 45.34% -8.23%
+ Complexity 4301 2850 -1451
============================================
Files 1887 865 -1022
Lines 40730 22181 -18549
Branches 4572 2153 -2419
============================================
- Hits 21820 10059 -11761
+ Misses 17836 11297 -6539
+ Partials 1074 825 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-904564732
> Please make the submodule untouched, and back the latest status of master branch. Also, you need to resolve conflicts, and make all CI tasks passed.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-875249436
@wu-sheng Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.42%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.78% +7.42%
- Complexity 2692 4290 +1598
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15253 +6055
- Misses 8337 9814 +1477
- Partials 730 1330 +600
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **increase** coverage by `0.70%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 53.56% 54.26% +0.70%
+ Complexity 4298 4099 -199
============================================
Files 1887 1021 -866
Lines 40730 26241 -14489
Branches 4572 2608 -1964
============================================
- Hits 21815 14240 -7575
+ Misses 17841 10762 -7079
- Partials 1074 1239 +165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `9.58%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 40.76% -9.59%
+ Complexity 2692 2564 -128
============================================
Files 740 835 +95
Lines 18265 21330 +3065
Branches 1766 2050 +284
============================================
- Hits 9198 8696 -502
- Misses 8337 11932 +3595
+ Partials 730 702 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [794 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-871135518
> 2 arguments about this kind of changes.
>
> 1. Instance is up and down, with scaling. The name of instance could/should change from time to time, especially in today's k8s deployment. I can't see the point of set sampling for a single instance.
> 2. About endpoint, a.k.a. your interface. This would be a huge number of sampling, and as this sampler has to keep the seed for every endpoint(URI), if URI is parameterized, your OAP will be OOM eventually.
In my opinion, there are some premises of this usage scenario about the tow arguments:
- Maybe in our performance testing environment, it will be of great help to us in troubleshooting performance problems when doing full-link performance tests, that is also a good support point for full-link monitoring to full-link pressure testing.And at the same time, we usually only configure endpoint sampling rate for endpoints according to our needs .
- Or it could be that some instance of our production environment has an exception at that point in time. Of course, in most scenarios, the priority is to fix the problem and keep one or two instances in exception for troubleshooting.
- `URI is parameterized`,I remember that if URI is parameterized, it will be a parameterized URI as the span's `enpointName` such as : `{POST}/urlpath/{id}`.
![image](https://user-images.githubusercontent.com/9264192/123912941-36b16900-d9b0-11eb-8ec7-3d9409fb1c5a.png)
So I think should pay more attention to usage scenarios.And I think this is a kind of ability we should provide, and how to use it depends on the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `7.49%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 51.52% -7.50%
+ Complexity 4342 3109 -1233
============================================
Files 1020 831 -189
Lines 26256 21481 -4775
Branches 2600 2069 -531
============================================
- Hits 15497 11068 -4429
- Misses 9389 9508 +119
+ Partials 1370 905 -465
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `3.64%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 55.37% -3.65%
+ Complexity 4342 4158 -184
============================================
Files 1020 1022 +2
Lines 26256 26341 +85
Branches 2600 2613 +13
============================================
- Hits 15497 14586 -911
- Misses 9389 10450 +1061
+ Partials 1370 1305 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `14.71%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 44.30% -14.72%
+ Complexity 4342 2739 -1603
=============================================
Files 1020 831 -189
Lines 26256 21409 -4847
Branches 2600 2066 -534
=============================================
- Hits 15497 9486 -6011
- Misses 9389 11176 +1787
+ Partials 1370 747 -623
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-871894395
> Can we limit the number of configurations to avoid OOM?
If it is a dynamic configuration, I can't see how to limit it.
> Or not support instances and enpoint dimensions? It is also good to be able to support the service dimension.
Service level dynamic sampling makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `0.79%`.
> The diff coverage is `51.02%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 51.15% +0.79%
- Complexity 2692 3908 +1216
============================================
Files 740 1022 +282
Lines 18265 26221 +7956
Branches 1766 2595 +829
============================================
+ Hits 9198 13414 +4216
- Misses 8337 11650 +3313
- Partials 730 1157 +427
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `39.09% <0.00%> (-1.48%)` | :arrow_down: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [870 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.30%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.66% +6.30%
- Complexity 2692 4217 +1525
============================================
Files 740 1027 +287
Lines 18265 26369 +8104
Branches 1766 2612 +846
============================================
+ Hits 9198 14942 +5744
- Misses 8337 10132 +1795
- Partials 730 1295 +565
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `4.28%`.
> The diff coverage is `52.24%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 54.64% +4.28%
- Complexity 2692 4112 +1420
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14393 +5195
- Misses 8337 10665 +2328
- Partials 730 1280 +550
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `4.92%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.27% +4.92%
- Complexity 2692 4172 +1480
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14565 +5367
- Misses 8337 10503 +2166
- Partials 730 1280 +550
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.81%`.
> The diff coverage is `53.90%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.17% +6.81%
- Complexity 2692 4254 +1562
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15075 +5877
- Misses 8337 9954 +1617
- Partials 730 1339 +609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `3.33%`.
> The diff coverage is `52.24%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 53.69% +3.33%
- Complexity 2692 4064 +1372
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14142 +4944
- Misses 8337 10939 +2602
- Partials 730 1257 +527
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `3.69%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 55.33% -3.70%
+ Complexity 4342 4155 -187
============================================
Files 1020 1022 +2
Lines 26256 26341 +85
Branches 2600 2613 +13
============================================
- Hits 15497 14575 -922
- Misses 9389 10460 +1071
+ Partials 1370 1306 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.28%`.
> The diff coverage is `52.22%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.64% +6.28%
- Complexity 2692 4214 +1522
============================================
Files 740 1027 +287
Lines 18265 26369 +8104
Branches 1766 2612 +846
============================================
+ Hits 9198 14936 +5738
- Misses 8337 10138 +1801
- Partials 730 1295 +565
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `8.28%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 58.63% +8.28%
- Complexity 2692 4329 +1637
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15462 +6264
- Misses 8337 9523 +1186
- Partials 730 1383 +653
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `19.84%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 39.17% -19.85%
+ Complexity 4342 2470 -1872
=============================================
Files 1020 831 -189
Lines 26256 21357 -4899
Branches 2600 2059 -541
=============================================
- Hits 15497 8367 -7130
- Misses 9389 12332 +2943
+ Partials 1370 658 -712
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `62.50% <0.00%> (-25.00%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [427 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.93%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 58.29% +7.93%
- Complexity 2692 4302 +1610
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15372 +6174
- Misses 8337 9614 +1277
- Partials 730 1382 +652
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#discussion_r663532812
##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/AnalyzerModuleProvider.java
##########
@@ -111,18 +117,18 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
public void start() throws ModuleStartException {
// load official analysis
getManager().find(CoreModule.NAME)
- .provider()
- .getService(OALEngineLoaderService.class)
- .load(CoreOALDefine.INSTANCE);
+ .provider()
+ .getService(OALEngineLoaderService.class)
+ .load(CoreOALDefine.INSTANCE);
Review comment:
As far as possible, don't reformat irrelevant code styles. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-871864070
> > URI is parameterized,I remember that if URI is parameterized, it will be a parameterized URI as the span's enpointName such as : {POST}/urlpath/{id}.
>
> It only could be detected by SpringMVC spring, nothing more. Once backend supports a mechanism, we need to consider all language agents.
>
> > Or it could be that some instance of our production environment has an exception at that point in time. Of course, in most scenarios, the priority is to fix the problem and keep one or two instances in exception for troubleshooting.
>
> But still, you haven't explained the OOM risk. As the same as the endpoint case.
That's it. If there are a lots of configurations.
Can we limit the number of configurations to avoid OOM?
Or not support instances and enpoint dimensions? It is also good to be able to support the service dimension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `3.53%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 55.49% -3.54%
+ Complexity 4342 4166 -176
============================================
Files 1020 1022 +2
Lines 26256 26341 +85
Branches 2600 2613 +13
============================================
- Hits 15497 14617 -880
- Misses 9389 10418 +1029
+ Partials 1370 1306 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-871207441
> URI is parameterized,I remember that if URI is parameterized, it will be a parameterized URI as the span's enpointName such as : {POST}/urlpath/{id}.
It only could be detected by SpringMVC spring, nothing more. Once backend supports a mechanism, we need to consider all language agents.
> Or it could be that some instance of our production environment has an exception at that point in time. Of course, in most scenarios, the priority is to fix the problem and keep one or two instances in exception for troubleshooting.
But still, you haven't explained the OOM risk. As the same as the endpoint case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.51%`.
> The diff coverage is `53.78%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.87% +6.51%
- Complexity 2692 4244 +1552
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 14987 +5789
- Misses 8337 10039 +1702
- Partials 730 1324 +594
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [852 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `17.26%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.55% 36.29% -17.27%
+ Complexity 4298 2270 -2028
=============================================
Files 1887 834 -1053
Lines 40730 21094 -19636
Branches 4572 2024 -2548
=============================================
- Hits 21813 7656 -14157
+ Misses 17842 12827 -5015
+ Partials 1075 611 -464
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `71.76% <87.50%> (-2.36%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1517 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.87%`.
> The diff coverage is `53.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.23% +6.87%
- Complexity 2692 4271 +1579
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 15082 +5884
- Misses 8337 9929 +1592
- Partials 730 1339 +609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.24%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.60% +7.24%
- Complexity 2692 4271 +1579
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15189 +5991
- Misses 8337 9819 +1482
- Partials 730 1360 +630
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `0.36%`.
> The diff coverage is `60.52%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head c714b81. Consider uploading reports for the commit c714b81 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 58.66% -0.37%
+ Complexity 4342 4332 -10
============================================
Files 1020 1023 +3
Lines 26256 26368 +112
Branches 2600 2610 +10
============================================
- Hits 15497 15468 -29
- Misses 9389 9517 +128
- Partials 1370 1383 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <ø> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `43.75% <40.00%> (-31.25%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `53.48% <53.48%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
| [.../server/core/alarm/provider/EventHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9FdmVudEhvb2tDYWxsYmFjay5qYXZh) | `30.33% <0.00%> (-25.85%)` | :arrow_down: |
| [...server/core/alarm/EndpointRelationMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRSZWxhdGlvbk1ldGFJbkFsYXJtLmphdmE=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `60.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.43%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `10.10%`.
> The diff coverage is `32.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 40.25% -10.11%
+ Complexity 2692 2614 -78
=============================================
Files 740 866 +126
Lines 18265 22254 +3989
Branches 1766 2126 +360
=============================================
- Hits 9198 8959 -239
- Misses 8337 12629 +4292
+ Partials 730 666 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | :arrow_down: |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [786 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `1.07%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 57.94% -1.08%
+ Complexity 4342 4297 -45
============================================
Files 1020 1023 +3
Lines 26256 26388 +132
Branches 2600 2621 +21
============================================
- Hits 15497 15291 -206
- Misses 9389 9712 +323
- Partials 1370 1385 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| ... and [46 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `7.42%`.
> The diff coverage is `52.22%`.
> :exclamation: Current head 84b40b3 differs from pull request most recent head e93c0d7. Consider uploading reports for the commit e93c0d7 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.78% +7.42%
- Complexity 2692 4290 +1598
============================================
Files 740 1027 +287
Lines 18265 26397 +8132
Branches 1766 2617 +851
============================================
+ Hits 9198 15253 +6055
- Misses 8337 9814 +1477
- Partials 730 1330 +600
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.36% <0.00%> (+5.79%)` | :arrow_up: |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...e93c0d7](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `8.29%`.
> The diff coverage is `53.97%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 58.65% +8.29%
- Complexity 2692 4331 +1639
============================================
Files 740 1023 +283
Lines 18265 26368 +8103
Branches 1766 2610 +844
============================================
+ Hits 9198 15466 +6268
- Misses 8337 9519 +1182
- Partials 730 1383 +653
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `10.51%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.56% 43.04% -10.52%
+ Complexity 4298 2682 -1616
=============================================
Files 1887 834 -1053
Lines 40730 21372 -19358
Branches 4572 2068 -2504
=============================================
- Hits 21815 9199 -12616
+ Misses 17841 11428 -6413
+ Partials 1074 745 -329
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1484 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `4.82%`.
> The diff coverage is `32.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 45.53% -4.83%
- Complexity 2692 2804 +112
============================================
Files 740 835 +95
Lines 18265 21401 +3136
Branches 1766 2057 +291
============================================
+ Hits 9198 9745 +547
- Misses 8337 10905 +2568
- Partials 730 751 +21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [787 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-872140489
Got it!It has been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `15.49%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.55% 38.06% -15.50%
+ Complexity 4298 2363 -1935
=============================================
Files 1887 834 -1053
Lines 40730 21198 -19532
Branches 4572 2032 -2540
=============================================
- Hits 21813 8068 -13745
+ Misses 17842 12490 -5352
+ Partials 1075 640 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `71.76% <87.50%> (-2.36%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1507 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `1.96%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.56% 51.59% -1.97%
+ Complexity 4298 3230 -1068
============================================
Files 1887 865 -1022
Lines 40730 22402 -18328
Branches 4572 2170 -2402
============================================
- Hits 21815 11559 -10256
+ Misses 17841 9907 -7934
+ Partials 1074 936 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1433 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `10.98%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 48.03% -10.99%
+ Complexity 4342 2950 -1392
=============================================
Files 1020 831 -189
Lines 26256 21431 -4825
Branches 2600 2067 -533
=============================================
- Hits 15497 10294 -5203
- Misses 9389 10299 +910
+ Partials 1370 838 -532
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-875324729
> > > The boundary between `custom-trace-sample-rate` and existing `sampleRate` is not clear. If you want to do service based sample rate setting, the first step should make it supported in static configuration. Sample rate is a static configuration in the `application.yml`, you should make it separate in another `trace-sample-rate-setting.yml`, then, make the dynamic configuration works. Also, this should not be a different configuration than existing logic, otherwise, the users would be very confused, which sample rate would take effect if they set both.
> >
> >
> > Like that configure sampling rate by the same configuration in the `application.yml`?
> > ```
> > agent-analyzer:
> > selector: ${SW_AGENT_ANALYZER:default}
> > default:
> > #sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.sampleRate' that the config in 'traceSampleRateSettingFile'.
> > #slowTraceSegmentThreshold: ${SW_SLOW_TRACE_SEGMENT_THRESHOLD:-1} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.duration' that the config in 'traceSampleRateSettingFile'.
> > traceSampleRateSettingFile: ${SW_TRACE_SAMPLE_RATE_SETTING_FILE:trace-sample-rate-setting.yml}
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > And `trace-sample-rate-setting.yml`:
> > ```
> > global:
> > sampleRate: 10000 # the replace the old config `sampleRate` in the application.yml.
> > duration: 10000 # the replace the old config `slowTraceSegmentThreshold` in the application.yml
> > services:
> > - name: serverName # the server name which show skywalking-ui
> > sampleRate: 1000 # endpoint latitude. It has a higher priority than `global.sampleRate`
> > duration: 10000 # trace latency time. It has a higher priority than `global.duration`
> > ```
>
> Support different endpoint sampling rate settings? In many cases, the call volume of the core interface is relatively large
No, this has been rejected. Only service sampling rate would be accepted if this PR is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.36%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.72% +5.36%
- Complexity 2692 4194 +1502
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14683 +5485
- Misses 8337 10371 +2034
- Partials 730 1294 +564
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `5.76%`.
> The diff coverage is `58.51%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 53.25% -5.77%
+ Complexity 4342 4316 -26
============================================
Files 1020 1894 +874
Lines 26256 40952 +14696
Branches 2600 4601 +2001
============================================
+ Hits 15497 21810 +6313
- Misses 9389 18037 +8648
+ Partials 1370 1105 -265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.52% <52.52%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `60.00% <60.00%> (-15.00%)` | :arrow_down: |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `5.76% <0.00%> (-63.47%)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | :arrow_down: |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `8.13%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 50.88% -8.14%
+ Complexity 4342 3195 -1147
============================================
Files 1020 862 -158
Lines 26256 22409 -3847
Branches 2600 2162 -438
============================================
- Hits 15497 11403 -4094
- Misses 9389 10080 +691
+ Partials 1370 926 -444
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [270 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb69b3c) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `15.49%`.
> The diff coverage is `42.47%`.
> :exclamation: Current head fb69b3c differs from pull request most recent head 6d19040. Consider uploading reports for the commit 6d19040 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.57% 38.08% -15.50%
+ Complexity 4301 2472 -1829
=============================================
Files 1887 865 -1022
Lines 40730 22163 -18567
Branches 4572 2153 -2419
=============================================
- Hits 21820 8440 -13380
+ Misses 17836 13055 -4781
+ Partials 1074 668 -406
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1499 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `10.96%`.
> The diff coverage is `32.09%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 39.39% -10.97%
+ Complexity 2692 2575 -117
=============================================
Files 740 866 +126
Lines 18265 22251 +3986
Branches 1766 2126 +360
=============================================
- Hits 9198 8765 -433
- Misses 8337 12838 +4501
+ Partials 730 648 -82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | :arrow_down: |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [790 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-879107923
> > > > The boundary between `custom-trace-sample-rate` and existing `sampleRate` is not clear. If you want to do service based sample rate setting, the first step should make it supported in static configuration. Sample rate is a static configuration in the `application.yml`, you should make it separate in another `trace-sample-rate-setting.yml`, then, make the dynamic configuration works. Also, this should not be a different configuration than existing logic, otherwise, the users would be very confused, which sample rate would take effect if they set both.
> > >
> > >
> > > Like that configure sampling rate by the same configuration in the `application.yml`?
> > > ```
> > > agent-analyzer:
> > > selector: ${SW_AGENT_ANALYZER:default}
> > > default:
> > > #sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.sampleRate' that the config in 'traceSampleRateSettingFile'.
> > > #slowTraceSegmentThreshold: ${SW_SLOW_TRACE_SEGMENT_THRESHOLD:-1} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.duration' that the config in 'traceSampleRateSettingFile'.
> > > traceSampleRateSettingFile: ${SW_TRACE_SAMPLE_RATE_SETTING_FILE:trace-sample-rate-setting.yml}
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > And `trace-sample-rate-setting.yml`:
> > > ```
> > > global:
> > > sampleRate: 10000 # the replace the old config `sampleRate` in the application.yml.
> > > duration: 10000 # the replace the old config `slowTraceSegmentThreshold` in the application.yml
> > > services:
> > > - name: serverName # the server name which show skywalking-ui
> > > sampleRate: 1000 # endpoint latitude. It has a higher priority than `global.sampleRate`
> > > duration: 10000 # trace latency time. It has a higher priority than `global.duration`
> > > ```
> >
> >
> > Support different endpoint sampling rate settings? In many cases, the call volume of the core interface is relatively large
>
> No, this has been rejected. Only service sampling rate would be accepted if this PR is ready.
Yes,Only service sampling rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] HendSame commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-873760663
> The boundary between `custom-trace-sample-rate` and existing `sampleRate` is not clear. If you want to do service based sample rate setting, the first step should make it supported in static configuration. Sample rate is a static configuration in the `application.yml`, you should make it separate in another `trace-sample-rate-setting.yml`, then, make the dynamic configuration works. Also, this should not be a different configuration than existing logic, otherwise, the users would be very confused, which sample rate would take effect if they set both.
Like that configure sampling rate by the same configuration in the `application.yml`?
```
agent-analyzer:
selector: ${SW_AGENT_ANALYZER:default}
default:
#sampleRate: ${SW_TRACE_SAMPLE_RATE:10000} # The config had moved to 'traceSampleRateSettingFile' and had been replaced by 'global.sampleRate' that the config in 'traceSampleRateSettingFile'.
traceSampleRateSettingFile: ${SW_TRACE_SAMPLE_RATE_SETTING_FILE:trace-sample-rate-setting.yml}
```
And `trace-sample-rate-setting.yml`:
```
global:
sampleRate: 10000 # the replace the old config `sampleRate` in the application.yml.
duration: 10000 # the replace the old config `slowTraceSegmentThreshold` in the application.yml
services:
- name: serverName # the server name which show skywalking-ui
sampleRate: 1000 # endpoint latitude. It has a higher priority than `global.sampleRate`
duration: 10000 # trace latency time. It has a higher priority than `global.duration`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `2.89%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head c714b81 differs from pull request most recent head cacde7c. Consider uploading reports for the commit cacde7c to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 53.25% +2.89%
- Complexity 2692 4316 +1624
============================================
Files 740 1894 +1154
Lines 18265 40952 +22687
Branches 1766 4601 +2835
============================================
+ Hits 9198 21810 +12612
- Misses 8337 18037 +9700
- Partials 730 1105 +375
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../log4j/v1/x/SkyWalkingContextPatternConverter.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1NreVdhbGtpbmdDb250ZXh0UGF0dGVybkNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...oolkit/log/log4j/v1/x/TraceIdPatternConverter.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuQ29udmVydGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=) | `0.00% <ø> (ø)` | |
| [...m/toolkit/log/log4j/v1/x/TraceIdPatternParser.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...lkit/log/log4j/v1/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...m/toolkit/log/log4j/v2/x/Log4j2OutputAppender.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L0xvZzRqMk91dHB1dEFwcGVuZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...4j/v2/x/Log4j2SkyWalkingContextOutputAppender.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L0xvZzRqMlNreVdhbGtpbmdDb250ZXh0T3V0cHV0QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...kit/log/log4j/v2/x/SkyWalkingContextConverter.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L1NreVdhbGtpbmdDb250ZXh0Q29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...lkit/log/log4j/v2/x/log/GRPCLogClientAppender.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMi54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92Mi94L2xvZy9HUlBDTG9nQ2xpZW50QXBwZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lkit/log/logback/v1/x/LogbackPatternConverter.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nYmFjay0xLngvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbG9nL2xvZ2JhY2svdjEveC9Mb2diYWNrUGF0dGVybkNvbnZlcnRlci5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [1903 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [982001c...cacde7c](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.86%`.
> The diff coverage is `52.32%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.22% +5.86%
- Complexity 2692 4180 +1488
============================================
Files 740 1023 +283
Lines 18265 26340 +8075
Branches 1766 2605 +839
============================================
+ Hits 9198 14809 +5611
- Misses 8337 10210 +1873
- Partials 730 1321 +591
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `23.73%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 35.28% -23.74%
+ Complexity 4342 2231 -2111
=============================================
Files 1020 831 -189
Lines 26256 21228 -5028
Branches 2600 2050 -550
=============================================
- Hits 15497 7491 -8006
- Misses 9389 13155 +3766
+ Partials 1370 582 -788
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `62.50% <0.00%> (-25.00%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [480 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `3.56%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 53.92% +3.56%
- Complexity 2692 4092 +1400
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14207 +5009
- Misses 8337 10893 +2556
- Partials 730 1248 +518
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `3.52%`.
> The diff coverage is `53.62%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 53.88% +3.52%
- Complexity 2692 4090 +1398
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14198 +5000
- Misses 8337 10903 +2566
- Partials 730 1247 +517
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.24%`.
> The diff coverage is `53.78%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.60% +6.24%
- Complexity 2692 4227 +1535
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14915 +5717
- Misses 8337 10115 +1778
- Partials 730 1318 +588
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [853 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `12.00%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 38.35% -12.01%
+ Complexity 2692 2412 -280
=============================================
Files 740 835 +95
Lines 18265 21305 +3040
Branches 1766 2049 +283
=============================================
- Hits 9198 8172 -1026
- Misses 8337 12487 +4150
+ Partials 730 646 -84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [796 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `19.15%`.
> The diff coverage is `20.98%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 31.20% -19.16%
+ Complexity 2692 2084 -608
=============================================
Files 740 865 +125
Lines 18265 22048 +3783
Branches 1766 2088 +322
=============================================
- Hits 9198 6880 -2318
- Misses 8337 14686 +6349
+ Partials 730 482 -248
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | :arrow_down: |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| ... and [816 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `5.82%`.
> The diff coverage is `52.32%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.18% +5.82%
- Complexity 2692 4178 +1486
============================================
Files 740 1023 +283
Lines 18265 26338 +8073
Branches 1766 2601 +835
============================================
+ Hits 9198 14797 +5599
- Misses 8337 10221 +1884
- Partials 730 1320 +590
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `25.22%`.
> The diff coverage is `18.51%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 25.13% -25.23%
+ Complexity 2692 1603 -1089
=============================================
Files 740 834 +94
Lines 18265 21012 +2747
Branches 1766 1983 +217
=============================================
- Hits 9198 5282 -3916
- Misses 8337 15377 +7040
+ Partials 730 353 -377
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | :arrow_down: |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `14.63% <0.00%> (-35.37%)` | :arrow_down: |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| ... and [828 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **increase** coverage by `2.67%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 53.57% 56.24% +2.67%
+ Complexity 4301 4202 -99
============================================
Files 1887 1025 -862
Lines 40730 26308 -14422
Branches 4572 2620 -1952
============================================
- Hits 21820 14797 -7023
+ Misses 17836 10214 -7622
- Partials 1074 1297 +223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `5.76%`.
> The diff coverage is `58.51%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 53.25% -5.77%
+ Complexity 4342 4316 -26
============================================
Files 1020 1894 +874
Lines 26256 40952 +14696
Branches 2600 4601 +2001
============================================
+ Hits 15497 21810 +6313
- Misses 9389 18037 +8648
+ Partials 1370 1105 -265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.52% <52.52%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `60.00% <60.00%> (-15.00%)` | :arrow_down: |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `5.76% <0.00%> (-63.47%)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | :arrow_down: |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `6.05%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 44.30% -6.06%
- Complexity 2692 2734 +42
============================================
Files 740 835 +95
Lines 18265 21434 +3169
Branches 1766 2058 +292
============================================
+ Hits 9198 9496 +298
- Misses 8337 11172 +2835
- Partials 730 766 +36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <14.28%> (-17.87%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [794 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **increase** coverage by `1.00%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 53.56% 54.56% +1.00%
+ Complexity 4298 4120 -178
============================================
Files 1887 1025 -862
Lines 40730 26308 -14422
Branches 4572 2620 -1952
============================================
- Hits 21815 14354 -7461
+ Misses 17841 10699 -7142
- Partials 1074 1255 +181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8343e5c) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `4.00%`.
> The diff coverage is `31.70%`.
> :exclamation: Current head 8343e5c differs from pull request most recent head ab19ce4. Consider uploading reports for the commit ab19ce4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 50.35% 46.35% -4.01%
- Complexity 2692 2829 +137
============================================
Files 740 835 +95
Lines 18265 21470 +3205
Branches 1766 2059 +293
============================================
+ Hits 9198 9953 +755
- Misses 8337 10713 +2376
- Partials 730 804 +74
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `51.02% <14.28%> (-17.87%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `39.13% <39.13%> (ø)` | |
| ... and [781 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0efc733...ab19ce4](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `5.35%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 53.67% -5.36%
+ Complexity 4342 3329 -1013
============================================
Files 1020 862 -158
Lines 26256 22437 -3819
Branches 2600 2167 -433
============================================
- Hits 15497 12042 -3455
+ Misses 9389 9388 -1
+ Partials 1370 1007 -363
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/agent/kafka/provider/handler/JsonLogHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pzb25Mb2dIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [233 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-904279436
Please make the submodule untouched, and back the latest status of master branch. Also, you need to resolve conflicts, and make all CI tasks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-904278817
@HendSame This PR was in CI broken status. We need you to make all things ready before we do code review. Do you want to do this again? We can open this and continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/982001c63aed54623c94b017afb873df0d679002?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (982001c) will **decrease** coverage by `5.74%`.
> The diff coverage is `58.51%`.
> :exclamation: Current head c714b81 differs from pull request most recent head cacde7c. Consider uploading reports for the commit cacde7c to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.00% 53.25% -5.75%
+ Complexity 4361 4316 -45
============================================
Files 1025 1894 +869
Lines 26388 40952 +14564
Branches 2615 4601 +1986
============================================
+ Hits 15570 21810 +6240
- Misses 9442 18037 +8595
+ Partials 1376 1105 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.52% <52.52%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `60.00% <60.00%> (-15.00%)` | :arrow_down: |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | :arrow_down: |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `5.76% <0.00%> (-63.47%)` | :arrow_down: |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | :arrow_down: |
| ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [982001c...cacde7c](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `4.72%`.
> The diff coverage is `53.70%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 55.08% +4.72%
- Complexity 2692 4154 +1462
============================================
Files 740 1023 +283
Lines 18265 26348 +8083
Branches 1766 2605 +839
============================================
+ Hits 9198 14514 +5316
- Misses 8337 10555 +2218
- Partials 730 1279 +549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb69b3c) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `18.25%`.
> The diff coverage is `42.47%`.
> :exclamation: Current head fb69b3c differs from pull request most recent head 6d19040. Consider uploading reports for the commit 6d19040 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.57% 35.32% -18.26%
+ Complexity 4301 2316 -1985
=============================================
Files 1887 865 -1022
Lines 40730 22163 -18567
Branches 4572 2153 -2419
=============================================
- Hits 21820 7828 -13992
+ Misses 17836 13735 -4101
+ Partials 1074 600 -474
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <87.50%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1504 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b40b3) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.37%`.
> The diff coverage is `52.52%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 56.73% +6.37%
- Complexity 2692 4210 +1518
============================================
Files 740 1023 +283
Lines 18265 26304 +8039
Branches 1766 2604 +838
============================================
+ Hits 9198 14923 +5725
- Misses 8337 10088 +1751
- Partials 730 1293 +563
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27e5986...84b40b3](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `2.14%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 56.87% -2.15%
+ Complexity 4342 4249 -93
============================================
Files 1020 1022 +2
Lines 26256 26343 +87
Branches 2600 2617 +17
============================================
- Hits 15497 14982 -515
- Misses 9389 10038 +649
+ Partials 1370 1323 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-873761461
> Like that configure sampling rate by the same configuration in the `application.yml`?
Yes, something like that. `global` should be renamed as `default`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **increase** coverage by `6.87%`.
> The diff coverage is `53.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
+ Coverage 50.35% 57.23% +6.87%
- Complexity 2692 4271 +1579
============================================
Files 740 1023 +283
Lines 18265 26350 +8085
Branches 1766 2609 +843
============================================
+ Hits 9198 15082 +5884
- Misses 8337 9929 +1592
- Partials 730 1339 +609
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `71.42% <ø> (+71.42%)` | :arrow_up: |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `64.04% <0.00%> (+8.48%)` | :arrow_up: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../commands/executor/ProfileTaskCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvUHJvZmlsZVRhc2tDb21tYW5kRXhlY3V0b3IuamF2YQ==) | `7.69% <0.00%> (ø)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | :arrow_up: |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (-28.64%)` | :arrow_down: |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `45.45% <0.00%> (+4.88%)` | :arrow_up: |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | |
| ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `18.12%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 59.02% 40.89% -18.13%
+ Complexity 4342 2558 -1784
=============================================
Files 1020 831 -189
Lines 26256 21360 -4896
Branches 2600 2059 -541
=============================================
- Hits 15497 8736 -6761
- Misses 9389 11945 +2556
+ Partials 1370 679 -691
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `74.11% <80.00%> (-1.18%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d1aa72) into [master](https://codecov.io/gh/apache/skywalking/commit/002f4c2573399a96649a64fb399dc8b7e80cd175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (002f4c2) will **decrease** coverage by `20.86%`.
> The diff coverage is `20.98%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 50.35% 29.49% -20.87%
+ Complexity 2692 1979 -713
=============================================
Files 740 865 +125
Lines 18265 21901 +3636
Branches 1766 2069 +303
=============================================
- Hits 9198 6460 -2738
- Misses 8337 14996 +6659
+ Partials 730 445 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...commons/datacarrier/common/AtomicRangeInteger.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbW1vbi9BdG9taWNSYW5nZUludGVnZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | :arrow_down: |
| [...tacarrier/partition/ProducerThreadPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9Qcm9kdWNlclRocmVhZFBhcnRpdGlvbmVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | :arrow_down: |
| [.../apache/skywalking/apm/util/StringFormatGroup.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nRm9ybWF0R3JvdXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.56%)` | :arrow_down: |
| [...k/trace/component/command/CommandDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbW1hbmREZXNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `48.97% <14.28%> (-19.91%)` | :arrow_down: |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `66.66% <33.33%> (-9.81%)` | :arrow_down: |
| ... and [816 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04bb667...8d1aa72](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `4.18%`.
> The diff coverage is `42.47%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 53.56% 49.37% -4.19%
+ Complexity 4298 3139 -1159
============================================
Files 1887 865 -1022
Lines 40730 22402 -18328
Branches 4572 2170 -2402
============================================
- Hits 21815 11061 -10754
+ Misses 17841 10459 -7382
+ Partials 1074 882 -192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `83.33% <ø> (-4.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `15.38% <13.72%> (-59.62%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `54.54% <54.54%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <87.50%> (+1.17%)` | :arrow_up: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1436 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7194: Support configure sampling rate dynamically for service dimension on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c714b81) into [master](https://codecov.io/gh/apache/skywalking/commit/d15b67bd97cfe8386df0c61198d9f1ca2060089b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d15b67b) will **decrease** coverage by `1.93%`.
> The diff coverage is `55.97%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
============================================
- Coverage 59.02% 57.08% -1.94%
+ Complexity 4342 4255 -87
============================================
Files 1020 1022 +2
Lines 26256 26343 +87
Branches 2600 2617 +17
============================================
- Hits 15497 15038 -459
- Misses 9389 9969 +580
+ Partials 1370 1336 -34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `40.00% <40.00%> (-35.00%)` | :arrow_down: |
| [.../provider/trace/TraceSampleRateSettingWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL1RyYWNlU2FtcGxlUmF0ZVNldHRpbmdXYXRjaGVyLmphdmE=) | `52.04% <52.04%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.29% <80.00%> (ø)` | |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.50% <100.00%> (-0.18%)` | :arrow_down: |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d15b67b...c714b81](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #7194: Support configure sampling rate dynamically follow every service or instance or interface latitude on the backend side
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870185902
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7194](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d19040) into [master](https://codecov.io/gh/apache/skywalking/commit/de1d0461cc0454d9179ddb98b66e93643d0c754e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de1d046) will **decrease** coverage by `27.69%`.
> The diff coverage is `37.16%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7194/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7194 +/- ##
=============================================
- Coverage 53.55% 25.86% -27.70%
+ Complexity 4298 1696 -2602
=============================================
Files 1887 833 -1054
Lines 40730 20839 -19891
Branches 4572 1975 -2597
=============================================
- Hits 21813 5389 -16424
+ Misses 17842 15042 -2800
+ Partials 1075 408 -667
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...server/analyzer/provider/AnalyzerModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlQ29uZmlnLmphdmE=) | `58.33% <ø> (-29.17%)` | :arrow_down: |
| [...der/trace/parser/listener/TraceSegmentSampler.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9UcmFjZVNlZ21lbnRTYW1wbGVyLmphdmE=) | `7.69% <5.88%> (-67.31%)` | :arrow_down: |
| [...r/provider/trace/CustomTraceSampleRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL0N1c3RvbVRyYWNlU2FtcGxlUmF0ZVdhdGNoZXIuamF2YQ==) | `52.27% <52.27%> (ø)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `18.07% <75.00%> (-56.05%)` | :arrow_down: |
| [...rver/analyzer/provider/AnalyzerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL0FuYWx5emVyTW9kdWxlUHJvdmlkZXIuamF2YQ==) | `97.82% <100.00%> (+0.15%)` | :arrow_up: |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1578 more](https://codecov.io/gh/apache/skywalking/pull/7194/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [de1d046...6d19040](https://codecov.io/gh/apache/skywalking/pull/7194?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org