You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/13 07:46:51 UTC
[GitHub] [doris] ByteYue opened a new pull request, #14228: [enhancement](thriftclient) remove client_map to optimize thrift client lock
ByteYue opened a new pull request, #14228:
URL: https://github.com/apache/doris/pull/14228
# Proposed changes
Issue Number: close #xxx
The former logic of client_cache would use two unordered_map, one for <HostAddress, List<ClientPointer>> while the other for <ClientPointer, ImplPointer>. Lock should be acquired no matter accessing whichever map. Actually we can use one pair to maintain the <ClientPointer, ImplPointer> relation to reduce the lock pressure.
## Problem summary
Describe your changes.
Remove client_cache map and use pair to maintain the <ClientPointer, ImplPointer> relation.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #14228: [enhancement](thriftclient) remove client_map to optimize thrift client lock
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #14228: [enhancement](thriftclient) remove client_map to optimize thrift client lock
URL: https://github.com/apache/doris/pull/14228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14228: [enhancement](thriftclient) remove client_map to optimize thrift client lock
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14228:
URL: https://github.com/apache/doris/pull/14228#issuecomment-1547038790
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14228: [enhancement](thriftclient) remove client_map to optimize thrift client lock
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14228:
URL: https://github.com/apache/doris/pull/14228#issuecomment-1312746615
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.39 seconds
load time: 458 seconds
storage size: 17179712717 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221113144032_clickbench_pr_45198.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org