You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2017/05/03 12:15:23 UTC
[GitHub] incubator-metron pull request #562: METRON-915 add node and npm to platform_...
GitHub user ottobackwards opened a pull request:
https://github.com/apache/incubator-metron/pull/562
METRON-915 add node and npm to platform_info.sh
## Contributor Comments
Now that we depend on node and npm, put them into the platform_info.sh for troubleshooting build failures.
We may want to follow on with the pr template?
to verify.. run the script on platforms you use
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ NA] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ x] Have you included steps or a guide to how the change may be verified and tested manually?
- [NA ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ NA] Have you written or updated unit tests and or integration tests to verify your changes?
- [ NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [NA ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [NA ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/incubator-metron METRON-915
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit f7951ea1a55bf7d0b368bbf9e2121e65f39ab4dc
Author: Otto Fowler <ot...@gmail.com>
Date: 2017-05-03T12:12:26Z
add node and npm to platform_info.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #562: METRON-915 add node and npm to platform_...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm
to platform_info.sh
Posted by Otto Fowler <ot...@gmail.com>.
I’m sorry Ryan, I was looking at :
https://issues.apache.org/jira/browse/METRON-914 ( which you may need to
take a peek at ),
and thought that it was missing from the script.
I was not aware of the plugin.
On May 3, 2017 at 08:32:31, Ryan Merriman (merrimanr@gmail.com) wrote:
We are using a mvn plugin that automatically installs the correct version
of node and npm locally, at least for the management UI.
Are there other parts of the project that depend on these tools? Is it
desirable to include this even if they aren't a prerequisite for building?
I don't think it's a bad idea to include it either way, just want people to
be aware of the plugin.
> On May 3, 2017, at 7:19 AM, nickwallen <gi...@git.apache.org> wrote:
>
> Github user nickwallen commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/562
>
> +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected.
>
>
> ---
> If your project is set up for it, you can reply to this email and have
your
> reply appear on GitHub as well. If your project does not have this
feature
> enabled and wishes so, or if the feature is enabled but not working,
please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm
to platform_info.sh
Posted by Nick Allen <ni...@nickallen.org>.
I think it still makes sense to add these to the platform script. What if
the mvn plugin breaks or starts working in an unexpected way? This would
help us uncover issues there.
But good point to bring up, Ryan.
On Wed, May 3, 2017 at 8:32 AM, Ryan Merriman <me...@gmail.com> wrote:
> We are using a mvn plugin that automatically installs the correct version
> of node and npm locally, at least for the management UI.
>
> Are there other parts of the project that depend on these tools? Is it
> desirable to include this even if they aren't a prerequisite for building?
> I don't think it's a bad idea to include it either way, just want people to
> be aware of the plugin.
>
> > On May 3, 2017, at 7:19 AM, nickwallen <gi...@git.apache.org> wrote:
> >
> > Github user nickwallen commented on the issue:
> >
> > https://github.com/apache/incubator-metron/pull/562
> >
> > +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh
Posted by Ryan Merriman <me...@gmail.com>.
We are using a mvn plugin that automatically installs the correct version of node and npm locally, at least for the management UI.
Are there other parts of the project that depend on these tools? Is it desirable to include this even if they aren't a prerequisite for building? I don't think it's a bad idea to include it either way, just want people to be aware of the plugin.
> On May 3, 2017, at 7:19 AM, nickwallen <gi...@git.apache.org> wrote:
>
> Github user nickwallen commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/562
>
> +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/562
+1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---