You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zekai-li (via GitHub)" <gi...@apache.org> on 2023/05/25 07:13:02 UTC
[GitHub] [rocketmq] zekai-li opened a new pull request, #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
zekai-li opened a new pull request, #6811:
URL: https://github.com/apache/rocketmq/pull/6811
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6808
### Brief Description
Fix the following three as
1，TraceBean： private static final String LOCAL_ADDRESS = UtilAll.ipToIPv4Str(UtilAll.getIP()); getIP mayby ipv6
2，NetworkUtil：if (ip.startsWith("127.0") || ip.startsWith("192.168") || ip.startsWith("0."))；Check whether Intranet errors exist
3，NetworkUtil, MixAll, UtilAll three code repeats, refactoring NetworkUtil related code as a tool outlet for network unified logic
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
networkutiltest was set up for code testing
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li commented on pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1736866511
@RongtongJin Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li commented on pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1582215227
@RongtongJin Please take a look and resubmit to check the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #6808] Fixed network bugs and merged networkutil code [rocketmq]
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1751663865
@RongtongJin Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li commented on pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1565227032
@HScarb Please take a look and resubmit to check the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li commented on pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1565226305
@xiaoyifang Please take a look and resubmit to check the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li closed pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li closed pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
URL: https://github.com/apache/rocketmq/pull/6811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zekai-li commented on pull request #6811: [ISSUE #6808] Fixed network bugs and merged networkutil code
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #6811:
URL: https://github.com/apache/rocketmq/pull/6811#issuecomment-1706029001
@RongtongJin Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org